Reuse the same translation keystrings for the same labels in milestone dropdown menus #13768

Closed
opened 2025-11-02 10:52:37 -06:00 by GiteaMirror · 1 comment
Owner

Originally created by @Simandara on GitHub (Nov 28, 2024).

Description

I noticed the Milestone dropdown selector used in the sidebar of an issue/PR doesn't use the same translation keystring as the ones used in the filters and actions menubars

Keystring used in the sidebar

Screenshot 2024-11-28 at 17-10-27

Keystring used in the actionbar & filterbar

Screenshot 2024-11-28 at 17-09-56

Screenshot 2024-11-28 at 17-18-41


Further more, the actions menubars misuses the 'open' keystring for both opened and closed milestones, whereas it should use the 'close' keystring.

Screenshots

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Macos

Browser Version

Firefox 132

Originally created by @Simandara on GitHub (Nov 28, 2024). ### Description I noticed the Milestone dropdown selector used in the _sidebar_ of an issue/PR doesn't use the same translation keystring as the ones used in the _filters_ and _actions_ menubars **Keystring used in the sidebar** ![Screenshot 2024-11-28 at 17-10-27](https://github.com/user-attachments/assets/c1718af1-b82c-414c-9338-e15679918a11) **Keystring used in the actionbar & filterbar** ![Screenshot 2024-11-28 at 17-09-56](https://github.com/user-attachments/assets/9dc095f6-371f-4056-ac7e-04207c835706) ![Screenshot 2024-11-28 at 17-18-41](https://github.com/user-attachments/assets/319d0cfb-caa1-4dd0-99d5-7ba2daacd1de) --- Further more, the _actions_ menubars misuses the 'open' keystring for both opened and closed milestones, whereas it should use the 'close' keystring. ![](https://cdn.discordapp.com/attachments/977026554909581334/1311728890154323978/Screenshot_2024-11-28_at_17-18-41_Issues_-_celeste-docker_-_Gitea_Git_with_a_cup_of_tea.png?ex=6749ea3a&is=674898ba&hm=c519b82342b01028db422c9633064e7ff7fb291f6f49d2c02c2a565a1cd13357&) ### Screenshots ### Gitea Version 1.22.3 ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System Macos ### Browser Version Firefox 132
GiteaMirror added the topic/uitype/bug labels 2025-11-02 10:52:37 -06:00
Author
Owner

@Simandara commented on GitHub (Nov 28, 2024):

Suggested changes:

  • Fix the off-label about closed milestones on the actionbar dropdown
  • Change keystrings used in the sidebar to reuse the ones used in the actionbar and the filterbar
  • Remove the now unused keystrings (idk how crowdin handle keystring deletions in the code)
@Simandara commented on GitHub (Nov 28, 2024): Suggested changes: - Fix the off-label about closed milestones on the _actionbar_ dropdown - Change keystrings used in the _sidebar_ to reuse the ones used in the _actionbar_ and the _filterbar_ - Remove the now unused keystrings (idk how crowdin handle keystring deletions in the code)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13768