github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-10 13:56:06 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Off-by-one error in notification page total computation #13673

New Issue
Closed
opened 2025-11-02 10:49:52 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 10:49:52 -06:00
Owner
Copy Link

Originally created by @colejohnson66 on GitHub (Nov 4, 2024).

Description

There's what appears to be an off-by-one error when computing the number of pages of notifications. In the screenshots below, page 94 contains 16 notifications (out of 20 nominal), yet page 95 still exists (albeit empty).

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

Untested

Log Gist

No response

Screenshots

image

image

Git Version

No response

Operating System

No response

How are you running Gitea?

N/A

Database

None

Originally created by @colejohnson66 on GitHub (Nov 4, 2024). ### Description There's what appears to be an off-by-one error when computing the number of pages of notifications. In the screenshots below, page 94 contains 16 notifications (out of 20 nominal), yet page 95 still exists (albeit empty). ### Gitea Version 1.22.3 ### Can you reproduce the bug on the Gitea demo site? Untested ### Log Gist _No response_ ### Screenshots ![image](https://github.com/user-attachments/assets/347c3df2-0461-4856-bc4c-95a37f6404bc) ![image](https://github.com/user-attachments/assets/7b8894af-2697-4354-8730-57804919123e) ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? N/A ### Database None
GiteaMirror added the issue/needs-feedbacktype/bug labels 2025-11-02 10:49:52 -06:00
GiteaMirror commented 2025-11-02 10:49:54 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 23, 2025):

If you refresh that page, does the "last empty page" still exist? If no, what you have seen was caused by the "ajax partial reloading", then the page number doesn't match. If yes, then it is a backend bug.

@wxiaoguang commented on GitHub (Apr 23, 2025): If you refresh that page, does the "last empty page" still exist? If no, what you have seen was caused by the "ajax partial reloading", then the page number doesn't match. If yes, then it is a backend bug.
GiteaMirror commented 2025-11-02 10:49:54 -06:00
Author
Owner
Copy Link

@colejohnson66 commented on GitHub (Apr 23, 2025):

Issue looks resolved in 1.23.5:

Image

@colejohnson66 commented on GitHub (Apr 23, 2025): Issue looks resolved in 1.23.5: ![Image](https://github.com/user-attachments/assets/492bafff-59e4-4cff-ab12-c1b4714fb9c1)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/needs-feedback type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13673
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?