Team in the Reviewers will be replaced by username #13633

New Issue

GiteaMirror · 2025-11-02T10:48:51-06:00

GiteaMirror commented

2025-11-02 10:48:51 -06:00

Originally created by @jetaime092 on GitHub (Oct 24, 2024).

Description

i start a pull request and set a team as the Reviewers ,the members in the team can see the pull request in the Review requested page.
then someone in the team reviewed the code,the team in the Reviewers will be replaced by the name who has reviewed the code,
and others in the team can no longer see the pull request in the Review requested page.

Gitea Version

1.21.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

windows server 2019 standard

How are you running Gitea?

gitea-1.21.5-windows-4.0-amd64.exe

Database

SQLite

Originally created by @jetaime092 on GitHub (Oct 24, 2024). ### Description i start a pull request and set a team as the Reviewers ,the members in the team can see the pull request in the Review requested page. then someone in the team reviewed the code,the team in the Reviewers will be replaced by the name who has reviewed the code, and others in the team can no longer see the pull request in the Review requested page. ### Gitea Version 1.21.5 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots ![image](https://github.com/user-attachments/assets/704563c7-f1a2-4880-9032-c92dcb1be2ee) ![image](https://github.com/user-attachments/assets/f56f1949-79d1-493a-b4b3-9c18839e5459) ### Git Version _No response_ ### Operating System windows server 2019 standard ### How are you running Gitea? gitea-1.21.5-windows-4.0-amd64.exe ### Database SQLite

GiteaMirror added the topic/pr type/bug labels 2025-11-02 10:48:51 -06:00

GiteaMirror commented

2025-11-02 10:48:52 -06:00

@lunny commented on GitHub (Oct 26, 2024):

Can you reproduce it on https://demo.gitea.com ?

@lunny commented on GitHub (Oct 26, 2024): Can you reproduce it on https://demo.gitea.com ?

GiteaMirror commented

2025-11-02 10:48:53 -06:00

@jpraet commented on GitHub (Oct 26, 2024):

What would you expect to see happen instead?
A person of the team has reviewed the PR. So doesn't it make sense that there is no "review requested" for the team anymore?

Do you expect that all members of the team need to review the PR? That's not how it works currently.

@jpraet commented on GitHub (Oct 26, 2024): What would you expect to see happen instead? A person of the team has reviewed the PR. So doesn't it make sense that there is no "review requested" for the team anymore? Do you expect that all members of the team need to review the PR? That's not how it works currently.

GiteaMirror commented

2025-11-02 10:48:53 -06:00

@jetaime092 commented on GitHub (Oct 28, 2024):

Can you reproduce it on https://demo.gitea.com ?

yes ,i have tested it on this site.

@jetaime092 commented on GitHub (Oct 28, 2024): > Can you reproduce it on https://demo.gitea.com ? yes ,i have tested it on this site.

GiteaMirror commented

2025-11-02 10:48:53 -06:00

@jetaime092 commented on GitHub (Oct 28, 2024):

What would you expect to see happen instead? A person of the team has reviewed the PR. So doesn't it make sense that there is no "review requested" for the team anymore?

Do you expect that all members of the team need to review the PR? That's not how it works currently.

I have set branch protection so that a PR requires two approvals before it can be merged. I want team members to still receive notifications about the merge request while it is pending enough approvals.

@jetaime092 commented on GitHub (Oct 28, 2024): > What would you expect to see happen instead? A person of the team has reviewed the PR. So doesn't it make sense that there is no "review requested" for the team anymore? > > Do you expect that all members of the team need to review the PR? That's not how it works currently. I have set branch protection so that a PR requires two approvals before it can be merged. I want team members to still receive notifications about the merge request while it is pending enough approvals.

GiteaMirror commented

2025-11-02 10:48:53 -06:00

@gkmw commented on GitHub (Feb 10, 2025):

Just to add to the conversation, I would also expect Gitea to keep the request until enough reviewers are in. Would that be possible?

@gkmw commented on GitHub (Feb 10, 2025): Just to add to the conversation, I would also expect Gitea to keep the request until enough reviewers are in. Would that be possible?

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#13633