github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

A lot of global lock test errors #13627

New Issue
Closed
opened 2025-11-02 10:48:42 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 10:48:42 -06:00
Owner
Copy Link

Originally created by @wxiaoguang on GitHub (Oct 23, 2024).

--- FAIL: TestLockAndDo (15.23s)
    --- FAIL: TestLockAndDo/redis (15.00s)
        globallock_test.go:89: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89
            	            				/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700
            	Error:      	Received unexpected error:
            	            	lock already taken, locked nodes: [0]
            	Test:       	TestLockAndDo/redis
        globallock_test.go:89: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89
            	            				/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700
            	Error:      	Received unexpected error:
            	            	lock already taken, locked nodes: [0]
            	Test:       	TestLockAndDo/redis

...
...
...
         globallock_test.go:89: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89
            	            				/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700
            	Error:      	Received unexpected error:
            	            	lock already taken, locked nodes: [0]
            	Test:       	TestLockAndDo/redis
        globallock_test.go:89: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89
            	            				/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700
            	Error:      	Received unexpected error:
            	            	lock already taken, locked nodes: [0]
            	Test:       	TestLockAndDo/redis
        globallock_test.go:95: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:95
            	            				/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:43
            	Error:      	Not equal: 
            	            	expected: 1000
            	            	actual  : 776
            	Test:       	TestLockAndDo/redis
FAIL
coverage: 91.8% of statements
FAIL	code.gitea.io/gitea/modules/globallock	23.286s
Originally created by @wxiaoguang on GitHub (Oct 23, 2024). ``` --- FAIL: TestLockAndDo (15.23s) --- FAIL: TestLockAndDo/redis (15.00s) globallock_test.go:89: Error Trace: /home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89 /opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700 Error: Received unexpected error: lock already taken, locked nodes: [0] Test: TestLockAndDo/redis globallock_test.go:89: Error Trace: /home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89 /opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700 Error: Received unexpected error: lock already taken, locked nodes: [0] Test: TestLockAndDo/redis ... ... ... globallock_test.go:89: Error Trace: /home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89 /opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700 Error: Received unexpected error: lock already taken, locked nodes: [0] Test: TestLockAndDo/redis globallock_test.go:89: Error Trace: /home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89 /opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700 Error: Received unexpected error: lock already taken, locked nodes: [0] Test: TestLockAndDo/redis globallock_test.go:95: Error Trace: /home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:95 /home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:43 Error: Not equal: expected: 1000 actual : 776 Test: TestLockAndDo/redis FAIL coverage: 91.8% of statements FAIL code.gitea.io/gitea/modules/globallock 23.286s ```
GiteaMirror added the type/bug label 2025-11-02 10:48:42 -06:00
GiteaMirror commented 2025-11-02 10:48:43 -06:00
Author
Owner
Copy Link

@wolfogre commented on GitHub (Oct 23, 2024):

How were these errors reproduced? Is it possible that the previous test was aborted and the lock was not released, and the test was restarted before the lock expired?

@wolfogre commented on GitHub (Oct 23, 2024): How were these errors reproduced? Is it possible that the previous test was aborted and the lock was not released, and the test was restarted before the lock expired?
GiteaMirror commented 2025-11-02 10:48:43 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 23, 2024):

I cannot reproduce it on my local machine. macOS go1.23.2 run with TEST_REDIS_URL=redis://127.0.0.1:6379/15 go test -tags=sqlite -run=TestLockAndDo.

@lunny commented on GitHub (Oct 23, 2024): I cannot reproduce it on my local machine. macOS go1.23.2 run with `TEST_REDIS_URL=redis://127.0.0.1:6379/15 go test -tags=sqlite -run=TestLockAndDo`.
GiteaMirror commented 2025-11-02 10:48:43 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 23, 2024):

How were these errors reproduced? Is it possible that the previous test was aborted and the lock was not released, and the test was restarted before the lock expired?

No idea, I just caught it from github actions. https://github.com/go-gitea/gitea/actions/runs/11459790779/job/31885087438

@wxiaoguang commented on GitHub (Oct 23, 2024): > How were these errors reproduced? Is it possible that the previous test was aborted and the lock was not released, and the test was restarted before the lock expired? No idea, I just caught it from github actions. https://github.com/go-gitea/gitea/actions/runs/11459790779/job/31885087438
GiteaMirror commented 2025-11-02 10:48:43 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Dec 11, 2024):

It fails a lot, probability > 5% or 10%

@wxiaoguang commented on GitHub (Dec 11, 2024): It fails a lot, probability > 5% or 10%
GiteaMirror commented 2025-11-02 10:48:43 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 23, 2025):

The root problem is that the global lock (redis) implementation is not right. But I guess I won't spend more time on it. Even if the lock goes wrong, end users won't be hurt too much at the moment.

@wxiaoguang commented on GitHub (Apr 23, 2025): The root problem is that the global lock (redis) implementation is not right. But I guess I won't spend more time on it. Even if the lock goes wrong, end users won't be hurt too much at the moment.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13627
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?