Move new reply to the bottom of PR #13624

New Issue

GiteaMirror · 2025-11-02T10:48:33-06:00

GiteaMirror commented

2025-11-02 10:48:33 -06:00

Originally created by @dev1way on GitHub (Oct 22, 2024).

Feature Description

It is difficult to discuss in large pull requests due to replies and conversations are losing in a large bunch of comments.

When a reviewer replies on the comment, comment should be moved to the bottom of pull request.
This allows author to resolve conversations easy and fast.

Screenshots

No response

Originally created by @dev1way on GitHub (Oct 22, 2024). ### Feature Description It is difficult to discuss in large pull requests due to replies and conversations are losing in a large bunch of comments. When a reviewer replies on the comment, comment should be moved to the bottom of pull request. This allows author to resolve conversations easy and fast. ### Screenshots _No response_

GiteaMirror added the type/proposal label 2025-11-02 10:48:33 -06:00

GiteaMirror commented

2025-11-02 10:48:35 -06:00

@lunny commented on GitHub (Oct 22, 2024):

However, conversations are sorted chronologically.

@lunny commented on GitHub (Oct 22, 2024): However, conversations are sorted chronologically.

GiteaMirror commented

2025-11-02 10:48:35 -06:00

@dev1way commented on GitHub (Oct 27, 2024):

Yes it is :)

Root conversations' messages are sorted chronologically, but their replies are not

@dev1way commented on GitHub (Oct 27, 2024): Yes it is :) Root conversations' messages are sorted chronologically, but their replies are not

GiteaMirror commented

2025-11-02 10:48:35 -06:00

@dev1way commented on GitHub (Jun 9, 2025):

@lunny, sorry

Is there any "lifehack" related to this issue?

@dev1way commented on GitHub (Jun 9, 2025): @lunny, sorry Is there any "lifehack" related to this issue?

GiteaMirror commented

2025-11-02 10:48:36 -06:00

@lunny commented on GitHub (Jun 9, 2025):

Do you mean the review comments should be sorted by the time they were last updated, rather than by the creation time of the first comment in the thread?

@lunny commented on GitHub (Jun 9, 2025): Do you mean the review comments should be sorted by the time they were last updated, rather than by the creation time of the first comment in the thread?

GiteaMirror commented

2025-11-02 10:48:36 -06:00

@dev1way commented on GitHub (Jun 9, 2025):

Yes, I do

In my case I have huge MRs with huge amount of comments :)
It's hard to find which comment was updated

@dev1way commented on GitHub (Jun 9, 2025): Yes, I do In my case I have huge MRs with huge amount of comments :) It's hard to find which comment was updated

GiteaMirror commented

2025-11-02 10:48:36 -06:00

@lunny commented on GitHub (Jun 9, 2025):

Sounds reasonable. The comments needs to be reorder in the memory after read from database. I don't think this can be addressed except having a PR.

@lunny commented on GitHub (Jun 9, 2025): Sounds reasonable. The comments needs to be reorder in the memory after read from database. I don't think this can be addressed except having a PR.

GiteaMirror commented

2025-11-02 10:48:37 -06:00

@dev1way commented on GitHub (Jun 9, 2025):

I don't think this can be addressed except having a PR.

Should the order of comments or just replies be changed?

@dev1way commented on GitHub (Jun 9, 2025): > I don't think this can be addressed except having a PR. Should the order of comments or just replies be changed?

GiteaMirror commented

2025-11-02 10:48:37 -06:00

@lunny commented on GitHub (Jun 9, 2025):

I think it should be a mix. For general comments, the original order should be preserved, even if they are updated. For code reviews, the sorting should be based on the last updated time, but also consider the creation time of associated comments for proper ordering.

@lunny commented on GitHub (Jun 9, 2025): I think it should be a mix. For general comments, the original order should be preserved, even if they are updated. For code reviews, the sorting should be based on the last updated time, but also consider the creation time of associated comments for proper ordering.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#13624