Deleting diff comment lefts buttons toolbar #13596

Closed
opened 2025-11-02 10:47:34 -06:00 by GiteaMirror · 4 comments
Owner

Originally created by @kuraga on GitHub (Oct 14, 2024).

Description

At the Pull request page,
at the Files Changed tab,
deleting a comment isn't visually complete.

The buttons toolbar is left (see the screenshot).

Screenshots

image

Gitea Version

1.23.0+dev-567-g9df5ddaf44

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

129.0.6668.100 (Official build), (64 bit)

Originally created by @kuraga on GitHub (Oct 14, 2024). ### Description At the Pull request page, at the `Files Changed` tab, deleting a comment isn't visually complete. The buttons toolbar is left (see the screenshot). ### Screenshots ![image](https://github.com/user-attachments/assets/28519778-940e-46b5-b4f5-cae591b01f08) ### Gitea Version 1.23.0+dev-567-g9df5ddaf44 ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System _No response_ ### Browser Version 129.0.6668.100 (Official build), (64 bit)
GiteaMirror added the topic/uitype/bug labels 2025-11-02 10:47:35 -06:00
Author
Owner

@cloudchamb3r commented on GitHub (Oct 15, 2024):

It would be better to mention that to reproduce bug, the deletion of comment should be happen in conversation tab.

@cloudchamb3r commented on GitHub (Oct 15, 2024): It would be better to mention that to reproduce bug, the deletion of comment should be happen in conversation tab.
Author
Owner

@kuraga commented on GitHub (Oct 16, 2024):

Thanks!

@kuraga commented on GitHub (Oct 16, 2024): Thanks!
Author
Owner

@lunny commented on GitHub (Oct 16, 2024):

Should this affect 1.22?

@lunny commented on GitHub (Oct 16, 2024): Should this affect 1.22?
Author
Owner

@cloudchamb3r commented on GitHub (Oct 16, 2024):

@lunny
At least in release/v1.22 branch, same error exists.
https://github.com/go-gitea/gitea/blob/release/v1.22/web_src/js/features/repo-issue.js#L187-L198

@cloudchamb3r commented on GitHub (Oct 16, 2024): @lunny At least in release/v1.22 branch, same error exists. https://github.com/go-gitea/gitea/blob/release/v1.22/web_src/js/features/repo-issue.js#L187-L198
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13596