"You need to leave a comment indicating the requested change(s)." when commenting on a PR #13501

New Issue

GiteaMirror · 2025-11-02T10:44:33-06:00

GiteaMirror commented

2025-11-02 10:44:33 -06:00

Originally created by @kemzeb on GitHub (Sep 18, 2024).

Description

When commenting on a PR, the error "You need to leave a comment indicating the requested change(s)." appears. It looks like the comment is still created normally; the problem is with the error appearing. To reproduce, just create a PR comment how you normally would:

Choose a line to comment on
Write something and then press on "Add single comment"
Head to "Review" on the top-right of your screen and then press "Comment"

... and you should see the error. Tested this on the demo site and got the same results. It appears that no error will appear when you add a review comment right before pressing on "Comment".

Gitea Version

1.23.0+dev-491-gf528df944b

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

N/A (using demo instance)

Operating System

N/A (using demo instance)

How are you running Gitea?

Originally tested in a Gitea dev instance, and then confirmed it on the demo site.

Database

None

Originally created by @kemzeb on GitHub (Sep 18, 2024). ### Description When commenting on a PR, the error "You need to leave a comment indicating the requested change(s)." appears. It looks like the comment is still created normally; the problem is with the error appearing. To reproduce, just create a PR comment how you normally would: 1. Choose a line to comment on 2. Write something and then press on "Add single comment" 3. Head to "Review" on the top-right of your screen and then press "Comment" ... and you should see the error. Tested this on the demo site and got the same results. It appears that no error will appear when you add a **review comment** right before pressing on "Comment". ### Gitea Version 1.23.0+dev-491-gf528df944b ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots ![Screenshot 2024-09-17 195936](https://github.com/user-attachments/assets/cc99ee03-4279-4d76-abe3-bea0b0b62479) ### Git Version N/A (using demo instance) ### Operating System N/A (using demo instance) ### How are you running Gitea? Originally tested in a Gitea dev instance, and then confirmed it on the demo site. ### Database None

GiteaMirror added the type/bug label 2025-11-02 10:44:33 -06:00

GiteaMirror closed this issue

2025-11-02 10:44:34 -06:00

GiteaMirror commented

2025-11-02 10:44:35 -06:00

@kemzeb commented on GitHub (Sep 18, 2024):

Ah, my mistake. There isn't an issue after all after further messing around.

@kemzeb commented on GitHub (Sep 18, 2024): Ah, my mistake. There isn't an issue after all after further messing around.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#13501