github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-22 14:34:54 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Incomplete/bogus implementation of mail incoming_handler #13437

New Issue
Closed
opened 2025-11-02 10:42:19 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2025-11-02 10:42:19 -06:00
Owner
Copy Link

Originally created by @KazzmanK on GitHub (Aug 28, 2024).

Description

I've setup incoming mail.
If no token in mail address provided there is a record in log
Incoming email token not found in headers

In some cases log says
Skipping automatic email reply

When token is manually truncated some letters
Error while processing incoming email[0]: unexpected EOF

But when token is intact, no log records and no new messages in issue conversation is created (I`m replying to new message in issue email)

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Windows service

Database

SQLite

Originally created by @KazzmanK on GitHub (Aug 28, 2024). ### Description I've setup incoming mail. If no token in mail address provided there is a record in log `Incoming email token not found in headers` In some cases log says `Skipping automatic email reply` When token is manually truncated some letters `Error while processing incoming email[0]: unexpected EOF` But when token is intact, no log records and no new messages in issue conversation is created (I`m replying to new message in issue email) ### Gitea Version 1.22.1 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Windows service ### Database SQLite
GiteaMirror added the type/bug label 2025-11-02 10:42:19 -06:00
GiteaMirror commented 2025-11-02 10:42:20 -06:00
Author
Owner
Copy Link

@KazzmanK commented on GitHub (Aug 29, 2024):

I was able to get a single notification which I able to reply to. It was a first comment in new issue it was an issue creation notification.
Any other replies to other comments do not create messages in issue.

@KazzmanK commented on GitHub (Aug 29, 2024): I was able to get a single notification which I able to reply to. ~~It was a first comment in new issue~~ it was an issue creation notification. Any other replies to other comments do not create messages in issue.
GiteaMirror commented 2025-11-02 10:42:20 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Aug 31, 2024):

If you say debug and you are running Gitea in development, you can use debug mod of VSCode.

@lunny commented on GitHub (Aug 31, 2024): If you say debug and you are running Gitea in development, you can use debug mod of VSCode.
GiteaMirror commented 2025-11-02 10:42:20 -06:00
Author
Owner
Copy Link

@KazzmanK commented on GitHub (Aug 31, 2024):

I wasn't managed to fully get debugging environment, to make breakpoints work I needed to set "substitutePath" in launch.json. But setting this parameters breaks source browsing on breakpoint.
Nevertheless , take look at
e5e40787dc/services/mailer/incoming/incoming_handler.go (L114-L122)

When I reply to new Issue (line 86), you create CreateIssueComment on line 110.
But when I reply to subsequent comments I'm routed to line 114, where only code comments somehow handled.
So, from user perspective incoming mail is just dumped.
Replying to ordinary comments in Issues is broken.

@KazzmanK commented on GitHub (Aug 31, 2024): I wasn't managed to fully get debugging environment, to make breakpoints work I needed to set "substitutePath" in launch.json. But setting this parameters breaks source browsing on breakpoint. Nevertheless , take look at https://github.com/go-gitea/gitea/blob/e5e40787dcce40f69d3489adca2a80cf685a3fe8/services/mailer/incoming/incoming_handler.go#L114-L122 When I reply to **_new_** Issue (line 86), you create CreateIssueComment on line 110. But when I reply to subsequent comments I'm routed to line 114, where only code comments somehow handled. So, from user perspective incoming mail is just dumped. Replying to ordinary comments in Issues is broken.
GiteaMirror commented 2025-11-02 10:42:20 -06:00
Author
Owner
Copy Link

@linghengqian commented on GitHub (Sep 1, 2024):

  • I noticed that https://docs.gitea.com/administration/email-setup doesn't actually point out any means to directly test whether SMTP is working.
  • If I had to look for an equivalent, I'd point to GitLab CE's instructions, as this is obviously very different from GitLab CE. In Chinese articles like https://www.yuque.com/linghengqian/meve2v/amyuk4s35t5ze394 , if GitLab CE is started via Docker Container, the user has a series of Bash commands similar to the following to send a test email to a real mailbox. This will start the interactive shell of the GitLab CE container and use GitLab CE's internal tool gitlab-rails console for testing. This type of operation can completely bypass the Web UI.
  • The katyreid@outlook.com here is a fake email.
docker compose up -d
docker compose exec gitlab-ce /bin/bash
gitlab-rails console
Notify.test_email('katyreid@outlook.com', 'Message Subject', 'Message Body').deliver_now
  • For operations similar to #28335, when I sent a test email in the Web UI, the information printed by Gitea in the Web UI was relatively short. In contrast, GitLab CE emits a full error stack when executing a command like Notify.test_email('katyreid@outlook.com', 'Message Subject', 'Message Body').deliver_now.
irb(main):001:0> Notify.test_email('katyreid@outlook.com', 'Message Subject', 'Message Body').deliver_now
Delivered mail 66ca90b0e9cff_66d2fa8-46f@ed1061f8ab5f.mail (14.2ms)
/opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-protocol-0.1.3/lib/net/protocol.rb:46:in `connect_nonblock': SSL_connect returned=1 errno=0 peeraddr=172.19.0.2:587 state=error: certificate verify failed (self-signed certificate) (OpenSSL::SSL::SSLError)
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-protocol-0.1.3/lib/net/protocol.rb:46:in `ssl_socket_connect'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-smtp-0.3.3/lib/net/smtp.rb:690:in `tlsconnect'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-smtp-0.3.3/lib/net/smtp.rb:666:in `do_start'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-smtp-0.3.3/lib/net/smtp.rb:611:in `start'
        from /opt/gitlab/embedded/service/gitlab-rails/config/initializers/mail_starttls_patch.rb:53:in `start_smtp_session'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/mail-2.8.1/lib/mail/network/delivery_methods/smtp.rb:100:in `deliver!'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/mail-2.8.1/lib/mail/message.rb:2145:in `do_delivery'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/mail-2.8.1/lib/mail/message.rb:253:in `block in deliver'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/actionmailer-7.0.8.4/lib/action_mailer/base.rb:588:in `block in deliver_mail'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/activesupport-7.0.8.4/lib/active_support/notifications.rb:206:in `block in instrument'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/activesupport-7.0.8.4/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/activesupport-7.0.8.4/lib/active_support/notifications.rb:206:in `instrument'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/actionmailer-7.0.8.4/lib/action_mailer/base.rb:586:in `deliver_mail'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/mail-2.8.1/lib/mail/message.rb:253:in `deliver'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/actionmailer-7.0.8.4/lib/action_mailer/message_delivery.rb:119:in `block in deliver_now'
        from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/actionmailer-7.0.8.4/lib/action_mailer/rescuable.rb:19:in `handle_exceptions'
        ... 14 levels...
irb(main):002:0>
@linghengqian commented on GitHub (Sep 1, 2024): - I noticed that https://docs.gitea.com/administration/email-setup doesn't actually point out any means to directly test whether SMTP is working. - If I had to look for an equivalent, I'd point to GitLab CE's instructions, as this is obviously very different from GitLab CE. In Chinese articles like https://www.yuque.com/linghengqian/meve2v/amyuk4s35t5ze394 , if GitLab CE is started via Docker Container, the user has a series of Bash commands similar to the following to send a test email to a real mailbox. This will start the interactive shell of the GitLab CE container and use GitLab CE's internal tool `gitlab-rails console` for testing. This type of operation can completely bypass the Web UI. - The `katyreid@outlook.com` here is a fake email. ```shell docker compose up -d docker compose exec gitlab-ce /bin/bash gitlab-rails console Notify.test_email('katyreid@outlook.com', 'Message Subject', 'Message Body').deliver_now ``` - For operations similar to #28335, when I sent a test email in the Web UI, the information printed by Gitea in the Web UI was relatively short. In contrast, GitLab CE emits a full error stack when executing a command like `Notify.test_email('katyreid@outlook.com', 'Message Subject', 'Message Body').deliver_now`. ```shell irb(main):001:0> Notify.test_email('katyreid@outlook.com', 'Message Subject', 'Message Body').deliver_now Delivered mail 66ca90b0e9cff_66d2fa8-46f@ed1061f8ab5f.mail (14.2ms) /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-protocol-0.1.3/lib/net/protocol.rb:46:in `connect_nonblock': SSL_connect returned=1 errno=0 peeraddr=172.19.0.2:587 state=error: certificate verify failed (self-signed certificate) (OpenSSL::SSL::SSLError) from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-protocol-0.1.3/lib/net/protocol.rb:46:in `ssl_socket_connect' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-smtp-0.3.3/lib/net/smtp.rb:690:in `tlsconnect' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-smtp-0.3.3/lib/net/smtp.rb:666:in `do_start' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/net-smtp-0.3.3/lib/net/smtp.rb:611:in `start' from /opt/gitlab/embedded/service/gitlab-rails/config/initializers/mail_starttls_patch.rb:53:in `start_smtp_session' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/mail-2.8.1/lib/mail/network/delivery_methods/smtp.rb:100:in `deliver!' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/mail-2.8.1/lib/mail/message.rb:2145:in `do_delivery' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/mail-2.8.1/lib/mail/message.rb:253:in `block in deliver' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/actionmailer-7.0.8.4/lib/action_mailer/base.rb:588:in `block in deliver_mail' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/activesupport-7.0.8.4/lib/active_support/notifications.rb:206:in `block in instrument' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/activesupport-7.0.8.4/lib/active_support/notifications/instrumenter.rb:24:in `instrument' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/activesupport-7.0.8.4/lib/active_support/notifications.rb:206:in `instrument' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/actionmailer-7.0.8.4/lib/action_mailer/base.rb:586:in `deliver_mail' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/mail-2.8.1/lib/mail/message.rb:253:in `deliver' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/actionmailer-7.0.8.4/lib/action_mailer/message_delivery.rb:119:in `block in deliver_now' from /opt/gitlab/embedded/lib/ruby/gems/3.1.0/gems/actionmailer-7.0.8.4/lib/action_mailer/rescuable.rb:19:in `handle_exceptions' ... 14 levels... irb(main):002:0> ```
GiteaMirror commented 2025-11-02 10:42:20 -06:00
Author
Owner
Copy Link

@KazzmanK commented on GitHub (Sep 5, 2024):

@KN4CK3R , can you please take a look, is there a problem. I`ve debugged incoming mail with reply to issue comment, and it was not handled.

@KazzmanK commented on GitHub (Sep 5, 2024): @KN4CK3R , can you please take a look, is there a problem. I`ve debugged incoming mail with reply to issue comment, and it was not handled.
GiteaMirror commented 2025-11-02 10:42:21 -06:00
Author
Owner
Copy Link

@KN4CK3R commented on GitHub (Sep 9, 2024):

Thank you for the ping, I will have a look. We have (deactivated) integration tests which should catch if something was broken recently.

@KN4CK3R commented on GitHub (Sep 9, 2024): Thank you for the ping, I will have a look. We have (deactivated) integration tests which should catch if something was broken recently.
GiteaMirror commented 2025-11-02 10:42:21 -06:00
Author
Owner
Copy Link

@KN4CK3R commented on GitHub (Sep 16, 2024):

Fixed in #32050

@KN4CK3R commented on GitHub (Sep 16, 2024): Fixed in #32050
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13437
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?