Emojis within links (commit messages etc.) aren’t clickable #13405

New Issue

GiteaMirror · 2025-11-02T10:41:23-06:00

GiteaMirror commented

2025-11-02 10:41:23 -06:00

Originally created by @JanRomero on GitHub (Aug 19, 2024).

Description

Hi,

when commit messages contain emojis, their <a> tags are split at the emojis and the emojis are wrapped in s, resulting in this:

<span class="commit-summary " title="" data-tooltip-content="Bug ❌ Feature ✅" aria-label="Bug ❌ Feature ✅">
    <a href="/xxx" class="default-link muted">Bug </a>
    <span class="emoji" aria-label="cross mark">❌</span>
    <a href="/xxx" class="default-link muted"> Feature </a>
    <span class="emoji" aria-label="check mark button">✅</span>
</span>

(The example is from the commit list, but the issue happens everywhere.)

This makes the emojis unclickable and splits the clickable link into two separate links, which looks weird on hover (the message is only partially highlighted/underlined). Crucially it also means that commit messages consisting solely of emojis are not clickable at all.

The desirable output in my opinion would be a single <a> wrapping the entire message including the emoji s:

<span class="commit-summary " title="" data-tooltip-content="Bug ❌ Feature ✅" aria-label="Bug ❌ Feature ✅">
    <a href="/xxx" class="default-link muted">
        Bug 
        <span class="emoji" aria-label="cross mark">❌</span>
        Feature 
        <span class="emoji" aria-label="check mark button">✅</span>
    </a>
</span>

I believe the code responsible is this method emojiProcessor():

36232b69db/modules/markup/html.go (L1078)

Thank you!

Screenshots

Gitea Version

1.22.0+rc1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Any, doesn’t matter

Originally created by @JanRomero on GitHub (Aug 19, 2024). ### Description Hi, when commit messages contain emojis, their `<a>` tags are split at the emojis and the emojis are wrapped in ``s, resulting in this: ```HTML <a href="/xxx" class="default-link muted">Bug </a> ❌ <a href="/xxx" class="default-link muted"> Feature </a> ✅ ``` (The example is from the commit list, but the issue happens everywhere.) This makes the emojis unclickable and splits the clickable link into two separate links, which looks weird on hover (the message is only partially highlighted/underlined). Crucially it also means that commit messages consisting solely of emojis are not clickable at all. The desirable output in my opinion would be a single `<a>` wrapping the entire message including the emoji ``s: ```HTML <a href="/xxx" class="default-link muted"> Bug ❌ Feature ✅ </a> ``` I believe the code responsible is this method `emojiProcessor()`: https://github.com/go-gitea/gitea/blob/36232b69db312e16a43d1134ff98ab5d65bf80da/modules/markup/html.go#L1078 Thank you! ### Screenshots ![grafik](https://github.com/user-attachments/assets/44ddb077-6422-4f93-9790-693973b5cdad) ### Gitea Version 1.22.0+rc1 ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System _No response_ ### Browser Version Any, doesn’t matter

GiteaMirror added the topic/ui type/bug labels 2025-11-02 10:41:23 -06:00

GiteaMirror commented

2025-11-02 10:41:24 -06:00

@silverwind commented on GitHub (Aug 20, 2024):

Sounds good. I agree, emojis should not split links and they can be treated like any other text glyphs, even if they render via image (like for custom emojis), <a> can wrap everything.

@silverwind commented on GitHub (Aug 20, 2024): Sounds good. I agree, emojis should not split links and they can be treated like any other text glyphs, even if they render via image (like for custom emojis), `<a>` can wrap everything.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#13405