Reference issue from pull request #1340

Closed
opened 2025-11-02 03:57:01 -06:00 by GiteaMirror · 13 comments
Owner

Originally created by @svarlamov on GitHub (Dec 10, 2017).

Originally assigned to: @guillep2k on GitHub.

  • Gitea version (or commit ref): 7ec6cdd

Description

When referencing an issue from a pull request description, ie., targeting #125 links properly, but when you're in the issue, there's no message saying that it was referenced in a pull request (such as Gitea does with commit messages or the way that Github does with pull request descriptions)

Originally created by @svarlamov on GitHub (Dec 10, 2017). Originally assigned to: @guillep2k on GitHub. - Gitea version (or commit ref): 7ec6cdd ## Description When referencing an issue from a pull request description, ie., `targeting #125` links properly, but when you're in the issue, there's no message saying that it was referenced in a pull request (such as Gitea does with commit messages or the way that Github does with pull request descriptions)
GiteaMirror added the type/featureissue/confirmed labels 2025-11-02 03:57:01 -06:00
Author
Owner

@svarlamov commented on GitHub (Dec 10, 2017):

Also, referencing an issue, ie., see #125 from an issue, links, but when you're in the referenced issue, there's no message about the reference -- as you would have in Github for instance

@svarlamov commented on GitHub (Dec 10, 2017): Also, referencing an issue, ie., `see #125` from an issue, links, but when you're in the referenced issue, there's no message about the reference -- as you would have in Github for instance
Author
Owner

@lafriks commented on GitHub (Dec 10, 2017):

Can you create sample on try.gitea.io to demonstrate this problem

@lafriks commented on GitHub (Dec 10, 2017): Can you create sample on try.gitea.io to demonstrate this problem
Author
Owner

@svarlamov commented on GitHub (Dec 12, 2017):

@lafriks - sure!

Issue to issue ref:

1: https://try.gitea.io/svarlamov/sample-issues-3134/issues/1
2: https://try.gitea.io/svarlamov/sample-issues-3134/issues/2

2 references 1, but there's nothing in 1 to show that (as there would be for a commit msg)

PR to issue ref:

PR(a): https://try.gitea.io/svarlamov/sample-issues-3134/pulls/3
ISSUE(b): https://try.gitea.io/svarlamov/sample-issues-3134/issues/1

PR(a) references ISSUE(b), however, there's nothing to indicate that in ISSUE(b) -- as there otherwise would be for a commit msg

@svarlamov commented on GitHub (Dec 12, 2017): @lafriks - sure! Issue to issue ref: 1: https://try.gitea.io/svarlamov/sample-issues-3134/issues/1 2: https://try.gitea.io/svarlamov/sample-issues-3134/issues/2 2 references 1, but there's nothing in 1 to show that (as there would be for a commit msg) PR to issue ref: PR(a): https://try.gitea.io/svarlamov/sample-issues-3134/pulls/3 ISSUE(b): https://try.gitea.io/svarlamov/sample-issues-3134/issues/1 PR(a) references ISSUE(b), however, there's nothing to indicate that in ISSUE(b) -- as there otherwise would be for a commit msg
Author
Owner

@lunny commented on GitHub (Dec 12, 2017):

I think @svarlamov means reference comments.

@lunny commented on GitHub (Dec 12, 2017): I think @svarlamov means reference comments.
Author
Owner

@funkyfuture commented on GitHub (Jan 31, 2018):

i think he means an information like the fourth under this comment in a pull request here.

@funkyfuture commented on GitHub (Jan 31, 2018): i think he means an information like the fourth under [this comment](https://github.com/go-gitea/gitea/issues/3430#issuecomment-361303846) in a pull request here.
Author
Owner

@funkyfuture commented on GitHub (Jan 31, 2018):

and like the one below that. :-)

@funkyfuture commented on GitHub (Jan 31, 2018): and like the one below that. :-)
Author
Owner

@stevegt commented on GitHub (Jun 23, 2018):

I've created #4302 to address the case of the issue backlinks. I'm pretty sure PR backlinks (this issue) could use the same table discussed in #4302, if that turns out to be the solution.

@stevegt commented on GitHub (Jun 23, 2018): I've created #4302 to address the case of the issue backlinks. I'm pretty sure PR backlinks (this issue) could use the same table discussed in #4302, if that turns out to be the solution.
Author
Owner

@stale[bot] commented on GitHub (Jan 21, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 21, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
Author
Owner

@AfroThundr3007730 commented on GitHub (Jan 21, 2019):

@lunny Perhaps the stale bot should be configured to ignore issues that are tracked in a milestone, or another tag could be created to exempt an issue from auto-closing.

It's not exactly ideal to keep bumping them manually.

@AfroThundr3007730 commented on GitHub (Jan 21, 2019): @lunny Perhaps the stale bot should be configured to ignore issues that are tracked in a milestone, or another tag could be created to exempt an issue from auto-closing. It's not exactly ideal to keep bumping them manually.
Author
Owner

@lafriks commented on GitHub (Jan 21, 2019):

there is already label reviewed/confirmed that stalebot won't touch :)

@lafriks commented on GitHub (Jan 21, 2019): there is already label `reviewed/confirmed` that stalebot won't touch :)
Author
Owner

@raucao commented on GitHub (Jan 27, 2019):

+1 for linking back to the PR from the issue view.

But also, it'd be nice to be able to close issues from PR descriptions. I.e. if the reference is "closes #123" it would close issue number 123 once the PR is merged (same as from commits). I do this all the time on GitHub and kind of miss it on Gitea now.

@raucao commented on GitHub (Jan 27, 2019): +1 for linking back to the PR from the issue view. But also, it'd be nice to be able to close issues from PR descriptions. I.e. if the reference is "closes #123" it would close issue number 123 once the PR is merged (same as from commits). I do this all the time on GitHub and kind of miss it on Gitea now.
Author
Owner

@guillep2k commented on GitHub (Sep 8, 2019):

This is pending. I'm interested in this feature, I might work on it next. Any caveats I should be aware of?

@guillep2k commented on GitHub (Sep 8, 2019): This is pending. I'm interested in this feature, I might work on it next. Any caveats I should be aware of?
Author
Owner

@worthy7 commented on GitHub (Sep 9, 2019):

@skddc One thing at a time ;-) make a new issue on that one (It's probably somewhere already!) please

@guillep2k Thanks!

@worthy7 commented on GitHub (Sep 9, 2019): @skddc One thing at a time ;-) make a new issue on that one (It's probably somewhere already!) please @guillep2k Thanks!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1340