github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-15 04:17:01 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

"New pull request" button shown when viewing tag/commit #1339

New Issue
Closed
opened 2025-11-02 03:56:59 -06:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-02 03:56:59 -06:00
Owner
Copy Link

Originally created by @ethantkoenig on GitHub (Dec 10, 2017).

  • Gitea version (or commit ref): master
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (ccd21f0837, click on the "New pull request" button for the 404)
    • No
    • Not relevant

Description

When viewing a tag or commit, the "new pull request" button is shown. If you click on the link, you will get a 404, since the head of a PR must be a branch.

I think that ideally the button should not be shown when viewing a tag/commit.

Originally created by @ethantkoenig on GitHub (Dec 10, 2017). - Gitea version (or commit ref): master - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (https://try.gitea.io/ethantkoenig/sandbox/src/commit/ccd21f083756c783bc4725512edb9992183ff941, click on the "New pull request" button for the 404) - [ ] No - [ ] Not relevant ## Description When viewing a tag or commit, the "new pull request" button is shown. If you click on the link, you will get a 404, since the head of a PR must be a branch. I think that ideally the button should not be shown when viewing a tag/commit.
GiteaMirror added the type/enhancement label 2025-11-02 03:56:59 -06:00
GiteaMirror commented 2025-11-02 03:57:00 -06:00
Author
Owner
Copy Link

@Albert221 commented on GitHub (Dec 10, 2017):

I'd like to work on that.

@Albert221 commented on GitHub (Dec 10, 2017): I'd like to work on that.
GiteaMirror commented 2025-11-02 03:57:01 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Dec 10, 2017):

@Albert221 I think there is already PR to fix this

@lafriks commented on GitHub (Dec 10, 2017): @Albert221 I think there is already PR to fix this
GiteaMirror commented 2025-11-02 03:57:01 -06:00
Author
Owner
Copy Link

@Albert221 commented on GitHub (Dec 10, 2017):

@lafriks could you confirm? I don't see any opened PRs addressing that

@Albert221 commented on GitHub (Dec 10, 2017): @lafriks could you confirm? I don't see any opened PRs addressing that
GiteaMirror commented 2025-11-02 03:57:01 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Dec 10, 2017):

@ethantkoenig wrote that in #3133 description that it fixes this issue but in code somehow I don't see this

@lafriks commented on GitHub (Dec 10, 2017): @ethantkoenig wrote that in #3133 description that it fixes this issue but in code somehow I don't see this >
GiteaMirror commented 2025-11-02 03:57:01 -06:00
Author
Owner
Copy Link

@ethantkoenig commented on GitHub (Dec 10, 2017):

Oh, I forgot to push my latest changes to #3133. Yes, #3133 will fix this issue

@ethantkoenig commented on GitHub (Dec 10, 2017): Oh, I forgot to push my latest changes to #3133. Yes, #3133 will fix this issue
GiteaMirror commented 2025-11-02 03:57:01 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Jan 14, 2018):

Fixed by #3133

@lafriks commented on GitHub (Jan 14, 2018): Fixed by #3133
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1339
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?