github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Actionable References Not Triggering on Manually Merges #13348

New Issue
Closed
opened 2025-11-02 10:39:20 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 10:39:20 -06:00
Owner
Copy Link

Originally created by @cyrilkong on GitHub (Jul 31, 2024).

Description

Hi Gitea team,

I’ve encountered a bug with the actionable references feature. When a pull request is manually merged, the automatic closing behavior of referenced issues is not triggered as expected.

For example, I had a pull request with the description “This PR closes #909090”. After manually merging the pull request, issue #909090 was not automatically closed, and no notification was created on the issue as the documentation suggests should happen.

This behavior is inconsistent with the feature’s description, which states that issues should be closed if the merger of the pull request has the necessary permissions. I do have the permissions to close the issue, but the actionable reference did not take effect upon merging.

This bug affects the workflow for issue tracking and resolution, as it requires manual intervention to update the issue status after merging a PR. It could lead to inconsistencies in the issue tracking system and additional workload for the team.

Could you please look into this issue and advise on how it can be resolved? It’s an important feature for maintaining our issue tracking efficiency.

Thank you for your attention to this matter. Keep up the great work.

Gitea Version

1.23.0+dev-345-gecc8f2b047

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Attached on https://forum.gitea.com/t/actionable-references-not-triggering-on-manually-merges/9525

Git Version

No response

Operating System

No response

How are you running Gitea?

All actions could reproduce via demo.gitea.com

Database

None

Originally created by @cyrilkong on GitHub (Jul 31, 2024). ### Description Hi Gitea team, I’ve encountered a bug with the actionable references feature. When a pull request is manually merged, the automatic closing behavior of referenced issues is not triggered as expected. For example, I had a pull request with the description “This PR closes #909090”. After manually merging the pull request, issue #909090 was not automatically closed, and no notification was created on the issue as the documentation suggests should happen. This behavior is inconsistent with the feature’s description, which states that issues should be closed if the merger of the pull request has the necessary permissions. I do have the permissions to close the issue, but the actionable reference did not take effect upon merging. This bug affects the workflow for issue tracking and resolution, as it requires manual intervention to update the issue status after merging a PR. It could lead to inconsistencies in the issue tracking system and additional workload for the team. Could you please look into this issue and advise on how it can be resolved? It’s an important feature for maintaining our issue tracking efficiency. Thank you for your attention to this matter. Keep up the great work. ### Gitea Version 1.23.0+dev-345-gecc8f2b047 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots Attached on https://forum.gitea.com/t/actionable-references-not-triggering-on-manually-merges/9525 ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? All actions could reproduce via demo.gitea.com ### Database None
GiteaMirror added the type/bug label 2025-11-02 10:39:20 -06:00
GiteaMirror commented 2025-11-02 10:39:21 -06:00
Author
Owner
Copy Link

@Zettat123 commented on GitHub (Aug 8, 2024):

Thanks for the bug report. But I cannot reproduce this issue on the demo site. Could you provide some steps to help us reproduce this issue?

@Zettat123 commented on GitHub (Aug 8, 2024): Thanks for the bug report. But I cannot reproduce this issue on the demo site. Could you provide some steps to help us reproduce this issue?
GiteaMirror commented 2025-11-02 10:39:22 -06:00
Author
Owner
Copy Link

@cyrilkong commented on GitHub (Aug 13, 2024):

Thanks for the bug report. But I cannot reproduce this issue on the demo site. Could you provide some steps to help us reproduce this issue?

Sure, here it is

  1. assume you have a repo, with a different branch, so you've got "master" and "branch1"
  2. create a issue named it "bug1", pretend to act as bug report
  3. so you will have a ISSUE_ID on "bug1"
  4. now try to edit your code whatever did just commit and update to "branch1", pretend to act as bugfix for "bug1"
  5. go for pull request, and create a pull request from "branch1" into "master", write down comment in conversation
  6. in the comment, say Closes #ISSUE_ID, it's a command which call actionable references, meanwhile this PR will auto-close the "bug1" if merged by reviewer
  7. reviewer(in this case, so you are) take a "manually merge" for this PR after review and approve
  8. normally, the action "merge" should reaction the call "auto-close" references, #ISSUE_ID of "bug1" should be closed
  9. but it's not
@cyrilkong commented on GitHub (Aug 13, 2024): > Thanks for the bug report. But I cannot reproduce this issue on the demo site. Could you provide some steps to help us reproduce this issue? Sure, here it is 1. assume you have a repo, with a different branch, so you've got "master" and "branch1" 2. create a issue named it "bug1", pretend to act as bug report 3. so you will have a ISSUE_ID on "bug1" 4. now try to edit your code whatever did just commit and update to "branch1", pretend to act as bugfix for "bug1" 5. go for pull request, and create a pull request from "branch1" into "master", write down comment in conversation 6. in the comment, say `Closes #ISSUE_ID`, it's a command which call [actionable references](https://docs.gitea.com/next/usage/automatically-linked-references#actionable-references-in-pull-requests-and-commit-messages), meanwhile this PR will auto-close the "bug1" if merged by reviewer 7. reviewer(in this case, so you are) take a "manually merge" for this PR after review and approve 8. normally, the action "merge" should reaction the call "auto-close" references, #ISSUE_ID of "bug1" should be closed 9. but it's not
GiteaMirror commented 2025-11-02 10:39:22 -06:00
Author
Owner
Copy Link

@cyrilkong commented on GitHub (Aug 13, 2024):

image
actionable reference like this.

image
and manually merged will give you a tag on PR.

@cyrilkong commented on GitHub (Aug 13, 2024): ![image](https://github.com/user-attachments/assets/2c7fdd97-af38-4c84-872a-62fa6d500641) actionable reference like this. ![image](https://github.com/user-attachments/assets/603f046a-18a3-4bb2-b1e8-018cad9d97d6) and manually merged will give you a tag on PR.
GiteaMirror commented 2025-11-02 10:39:22 -06:00
Author
Owner
Copy Link

@cyrilkong commented on GitHub (Aug 15, 2024):

yes I am following~

@cyrilkong commented on GitHub (Aug 15, 2024): yes I am following~
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13348
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?