github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Index out of range exception for the SSH Public Key page after deletion of auth source #13342

New Issue
Closed
opened 2025-11-02 10:39:02 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 10:39:02 -06:00
Owner
Copy Link

Originally created by @zyclonite on GitHub (Jul 29, 2024).

Description

If you have one ldap auth source and have ssh public key synchronisation in use. Keys in the database table get inserted with the login_source reference. When deleting an auth source gitea checks for references in the user table still using it but it does not check the public keys table still referencing it.
So after successfully deleting the auth source, having an old synchronised key will break the page for the particular user with the following exception.

PANIC: runtime error: index out of range [0] with length 0
/usr/local/go/src/runtime/panic.go:770 (0x43f2d3)
/go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:116 (0x1ae84ab)
/usr/local/go/src/runtime/panic.go:770 (0x43f2d3)
/usr/local/go/src/runtime/panic.go:114 (0x43de1b)
/go/src/code.gitea.io/gitea/models/asymkey/ssh_key.go:257 (0x12c7adf)
/go/src/code.gitea.io/gitea/routers/web/user/setting/keys.go:299 (0x2418727)
/go/src/code.gitea.io/gitea/routers/web/user/setting/keys.go:34 (0x241598f)
/usr/local/go/src/reflect/value.go:596 (0x4fc75f)
/usr/local/go/src/reflect/value.go:380 (0x4fbc03)
/go/src/code.gitea.io/gitea/modules/web/handler.go:172 (0x1af1427)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/chain.go:31 (0x1ae8f7f)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1aebcc7)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/middleware/get_head.go:37 (0x234dc0b)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/services/context/context.go:225 (0x1bbfc93)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/gitea.com/go-chi/session@v0.0.0-20240316035857-16768d98ec96/session.go:257 (0x1a99c63)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:73 (0x1ae9ad3)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:327 (0x1aeb31f)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1aebcc7)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:73 (0x1ae9ad3)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:327 (0x1aeb31f)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1aebcc7)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:122 (0x1ae8347)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x2297957)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/routers/common/middleware.go:49 (0x2298abb)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/routers/common/middleware.go:40 (0x22986d3)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/routers/common/middleware.go:103 (0x2297c8b)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867)
/usr/local/go/src/net/http/server.go:2171 (0x97a507)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:90 (0x1ae9a8f)
/go/src/code.gitea.io/gitea/modules/web/route.go:163 (0x1af2b9f)
/usr/local/go/src/net/http/server.go:3142 (0x97d91b)
/usr/local/go/src/net/http/server.go:2044 (0x9790d7)
/usr/local/go/src/runtime/asm_arm64.s:1222 (0x47c983)

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.45.2

Operating System

CoreOS 40.20240701.3.0

How are you running Gitea?

containerized via podman (crun)

Database

MySQL/MariaDB

Originally created by @zyclonite on GitHub (Jul 29, 2024). ### Description If you have one ldap auth source and have ssh public key synchronisation in use. Keys in the database table get inserted with the login_source reference. When deleting an auth source gitea checks for references in the user table still using it but it does not check the public keys table still referencing it. So after successfully deleting the auth source, having an old synchronised key will break the page for the particular user with the following exception. ``` PANIC: runtime error: index out of range [0] with length 0 /usr/local/go/src/runtime/panic.go:770 (0x43f2d3) /go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:116 (0x1ae84ab) /usr/local/go/src/runtime/panic.go:770 (0x43f2d3) /usr/local/go/src/runtime/panic.go:114 (0x43de1b) /go/src/code.gitea.io/gitea/models/asymkey/ssh_key.go:257 (0x12c7adf) /go/src/code.gitea.io/gitea/routers/web/user/setting/keys.go:299 (0x2418727) /go/src/code.gitea.io/gitea/routers/web/user/setting/keys.go:34 (0x241598f) /usr/local/go/src/reflect/value.go:596 (0x4fc75f) /usr/local/go/src/reflect/value.go:380 (0x4fbc03) /go/src/code.gitea.io/gitea/modules/web/handler.go:172 (0x1af1427) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/chain.go:31 (0x1ae8f7f) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1aebcc7) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/middleware/get_head.go:37 (0x234dc0b) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1af1497) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/services/context/context.go:225 (0x1bbfc93) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/gitea.com/go-chi/session@v0.0.0-20240316035857-16768d98ec96/session.go:257 (0x1a99c63) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:73 (0x1ae9ad3) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:327 (0x1aeb31f) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1aebcc7) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:73 (0x1ae9ad3) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:327 (0x1aeb31f) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1aebcc7) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:122 (0x1ae8347) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x2297957) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/routers/common/middleware.go:49 (0x2298abb) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/routers/common/middleware.go:40 (0x22986d3) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/routers/common/middleware.go:103 (0x2297c8b) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1af1867) /usr/local/go/src/net/http/server.go:2171 (0x97a507) /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:90 (0x1ae9a8f) /go/src/code.gitea.io/gitea/modules/web/route.go:163 (0x1af2b9f) /usr/local/go/src/net/http/server.go:3142 (0x97d91b) /usr/local/go/src/net/http/server.go:2044 (0x9790d7) /usr/local/go/src/runtime/asm_arm64.s:1222 (0x47c983) ``` ### Gitea Version 1.22.1 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version 2.45.2 ### Operating System CoreOS 40.20240701.3.0 ### How are you running Gitea? containerized via podman (crun) ### Database MySQL/MariaDB
GiteaMirror added the type/bug label 2025-11-02 10:39:02 -06:00
GiteaMirror commented 2025-11-02 10:39:03 -06:00
Author
Owner
Copy Link

@zyclonite commented on GitHub (Jul 29, 2024):

might be similar to this error but it seems it got closed before deeper analysis https://github.com/go-gitea/gitea/issues/26959

potential solution might be checking for ssh keys upon auth source deletion or making the loop in ssh_key.go:257 not breaking

@zyclonite commented on GitHub (Jul 29, 2024): might be similar to this error but it seems it got closed before deeper analysis https://github.com/go-gitea/gitea/issues/26959 potential solution might be checking for ssh keys upon auth source deletion or making the loop in `ssh_key.go:257` not breaking
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13342
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?