Review comment lost after hiding outdated comments in Pull Request #13335

New Issue

GiteaMirror · 2025-11-02T10:38:52-06:00

GiteaMirror commented

2025-11-02 10:38:52 -06:00

Originally created by @bartvdbraak on GitHub (Jul 26, 2024).

Description

Review a pull request, e.g. https://demo.gitea.com/bartvdbraak/blender/pulls/1/files
Click the **Review ** button and write a comment
Click the ••• (Diff Options) button and in its drop-down click Hide outdated comments
Page reloads without warning and your review comment is gone

Screenshots

Screencast_20240726_182916.webm

Gitea Version

Version: 1.23.0+dev-339-gb4ccef3dee

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Linux

Browser Version

Firefox 127.0 (64-bit)

Originally created by @bartvdbraak on GitHub (Jul 26, 2024). ### Description 1. Review a pull request, e.g. https://demo.gitea.com/bartvdbraak/blender/pulls/1/files 2. Click the **Review ** button and write a comment 3. Click the **•••** (Diff Options) button and in its drop-down click **Hide outdated comments** 4. Page reloads without warning and your review comment is gone ### Screenshots [Screencast_20240726_182916.webm](https://github.com/user-attachments/assets/3f971156-5a65-4026-aae5-d802059978cc) ### Gitea Version Version: 1.23.0+dev-339-gb4ccef3dee ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System Linux ### Browser Version Firefox 127.0 (64-bit)

GiteaMirror added the topic/pr type/bug topic/ui labels 2025-11-02 10:38:52 -06:00

GiteaMirror commented

2025-11-02 10:38:53 -06:00

@yp05327 commented on GitHub (Aug 15, 2024):

emmm, this is not really related to hiding outdated comments.
Gitea does not save the status of inputs, so any operation causes refreshing page will cause this issue.

@yp05327 commented on GitHub (Aug 15, 2024): emmm, this is not really related to `hiding outdated comments`. Gitea does not save the status of inputs, so any operation causes refreshing page will cause this issue.

GiteaMirror commented

2025-11-02 10:38:53 -06:00

@bartvdbraak commented on GitHub (Aug 15, 2024):

Should I reformulate the issue to highlight the issue that Gitea doesn't save input or doesn't prompt before reload when inputs have been entered?

@bartvdbraak commented on GitHub (Aug 15, 2024): Should I reformulate the issue to highlight the issue that Gitea doesn't save input or doesn't prompt before reload when inputs have been entered?

GiteaMirror commented

2025-11-02 10:38:53 -06:00

@lunny commented on GitHub (Aug 17, 2024):

emmm, this is not really related to hiding outdated comments. Gitea does not save the status of inputs, so any operation causes refreshing page will cause this issue.

This is not right. Some inputs will be saved on the web browser side.

@lunny commented on GitHub (Aug 17, 2024): > emmm, this is not really related to `hiding outdated comments`. Gitea does not save the status of inputs, so any operation causes refreshing page will cause this issue. This is not right. Some inputs will be saved on the web browser side.

GiteaMirror commented

2025-11-02 10:38:53 -06:00

@yp05327 commented on GitHub (Aug 18, 2024):

emmm, this is not really related to hiding outdated comments. Gitea does not save the status of inputs, so any operation causes refreshing page will cause this issue.

This is not right. Some inputs will be saved on the web browser side.

All right. At least, in this place, Gitea will not save it.

@yp05327 commented on GitHub (Aug 18, 2024): > > emmm, this is not really related to `hiding outdated comments`. Gitea does not save the status of inputs, so any operation causes refreshing page will cause this issue. > > This is not right. Some inputs will be saved on the web browser side. All right. At least, in this place, Gitea will not save it.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#13335