github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Merge User#GetDisplayName into User#DisplayName #13331

New Issue
Open
opened 2025-11-02 10:38:47 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 10:38:47 -06:00
Owner
Copy Link

Originally created by @delvh on GitHub (Jul 25, 2024).

Feature Description

As seen for example in #31687, we currently have two different methods to display a user name, and both doing similar things.
I don't see a reason why we should keep both.
I think keeping DisplayName and merging the body of GetDisplayName would make the most sense.

Or is there any reason why we need both methods, where we once ignore the [ui].DEFAULT_SHOW_FULL_NAME setting?

Screenshots

No response

Originally created by @delvh on GitHub (Jul 25, 2024). ### Feature Description As seen for example in #31687, we currently have two different methods to display a user name, and both doing similar things. I don't see a reason why we should keep both. I think keeping `DisplayName` and merging the body of `GetDisplayName` would make the most sense. Or is there any reason why we need both methods, where we once ignore the `[ui].DEFAULT_SHOW_FULL_NAME` setting? ### Screenshots _No response_
GiteaMirror added the type/proposal label 2025-11-02 10:38:47 -06:00
GiteaMirror commented 2025-11-02 10:38:48 -06:00
Author
Owner
Copy Link

@wolfogre commented on GitHub (Jul 30, 2024):

I agree. I believe it's just historical baggage.

@wolfogre commented on GitHub (Jul 30, 2024): I agree. I believe it's just historical baggage.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?