GSAP incompatible with MIT license, that is included in gitea binaries #13308

Closed
opened 2025-11-02 10:38:06 -06:00 by GiteaMirror · 7 comments
Owner

Originally created by @mahlzahn on GitHub (Jul 19, 2024).

Description

GSAP is included as dependency to vue-bar-graph and has a non-free license.

See https://github.com/lafriks/vue-bar-graph/issues/14 and https://codeberg.org/forgejo/discussions/issues/193.

Gitea Version

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Database

None

Originally created by @mahlzahn on GitHub (Jul 19, 2024). ### Description [GSAP](https://github.com/go-gitea/gitea/blob/main/package-lock.json#L7531) is included as dependency to vue-bar-graph and has a non-free license. See https://github.com/lafriks/vue-bar-graph/issues/14 and https://codeberg.org/forgejo/discussions/issues/193. ### Gitea Version * ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? * ### Database None
GiteaMirror added the type/bug label 2025-11-02 10:38:07 -06:00
Author
Owner

@techknowlogick commented on GitHub (Jul 19, 2024):

Thanks again for reporting this, and mentioning it in chat. Looks like the library is only use for one function call: 6b64270871/src/components/VueBarGraph.vue (L294-L297) a temporary workaround could be to remove the animation, and then look at a longer term fix.

@techknowlogick commented on GitHub (Jul 19, 2024): Thanks again for reporting this, and mentioning it in chat. Looks like the library is only use for one function call: https://github.com/lafriks/vue-bar-graph/blob/6b64270871f43ae8500dbecbcbb5e378ef984574/src/components/VueBarGraph.vue#L294-L297 a temporary workaround could be to remove the animation, and then look at a longer term fix.
Author
Owner

@techknowlogick commented on GitHub (Jul 19, 2024):

@lafriks if I were to send a PR to your repo with that update, would you be able to cut a new release of it?

@techknowlogick commented on GitHub (Jul 19, 2024): @lafriks if I were to send a PR to your repo with that update, would you be able to cut a new release of it?
Author
Owner

@lafriks commented on GitHub (Jul 19, 2024):

@lafriks if I were to send a PR to your repo with that update, would you be able to cut a new release of it?

@techknowlogick sure

@lafriks commented on GitHub (Jul 19, 2024): > @lafriks if I were to send a PR to your repo with that update, would you be able to cut a new release of it? @techknowlogick sure
Author
Owner

@techknowlogick commented on GitHub (Jul 19, 2024):

I have a PR now open https://github.com/lafriks/vue-bar-graph/pull/15 which removes gsap entirely.

@techknowlogick commented on GitHub (Jul 19, 2024): I have a PR now open https://github.com/lafriks/vue-bar-graph/pull/15 which removes gsap entirely.
Author
Owner

@delvh commented on GitHub (Jul 20, 2024):

Not closed yet, it is only merged into the dependency, not Gitea yet

@delvh commented on GitHub (Jul 20, 2024): Not closed yet, it is only merged into the dependency, not Gitea yet
Author
Owner

@lafriks commented on GitHub (Jul 21, 2024):

vue-bar-graph v2.1.0 has been published

@lafriks commented on GitHub (Jul 21, 2024): vue-bar-graph v2.1.0 has been published
Author
Owner

@lunny commented on GitHub (Sep 6, 2024):

Closed by #31705 and released in 1.22.2

@lunny commented on GitHub (Sep 6, 2024): Closed by #31705 and released in 1.22.2
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13308