github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Giteabot makes unnecessary escape for Korean translation #13268

New Issue
Open
opened 2025-11-02 10:36:44 -06:00 by GiteaMirror · 12 comments
GiteaMirror commented 2025-11-02 10:36:44 -06:00
Owner
Copy Link

Originally created by @cloudchamb3r on GitHub (Jul 10, 2024).

Description

Please refer to de265f3771

Gitea CI Bot Does Unnecessary Escapes for Korean Translation

Screenshots

Screenshot 2024-07-10 at 1 53 54 PM

Gitea Version

1.20~

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

OSX

Browser Version

chrome 126.0.6478.127

Originally created by @cloudchamb3r on GitHub (Jul 10, 2024). ### Description Please refer to https://github.com/go-gitea/gitea/commit/de265f377113766124e9846e120e2864bf01c60c Gitea CI Bot Does Unnecessary Escapes for Korean Translation ### Screenshots ![Screenshot 2024-07-10 at 1 53 54 PM](https://github.com/go-gitea/gitea/assets/98369677/f1639876-d0f1-431b-9985-524b0feba335) ### Gitea Version 1.20~ ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System OSX ### Browser Version chrome 126.0.6478.127
GiteaMirror added the topic/uitype/bug labels 2025-11-02 10:36:44 -06:00
GiteaMirror commented 2025-11-02 10:36:45 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Jul 10, 2024):

It's the translation problem, please help to correct it in https://translate.Gitea.com

@lunny commented on GitHub (Jul 10, 2024): It's the translation problem, please help to correct it in https://translate.Gitea.com
GiteaMirror commented 2025-11-02 10:36:45 -06:00
Author
Owner
Copy Link

@yp05327 commented on GitHub (Jul 30, 2024):

image
https://crowdin.com/editor/gitea/68/enus-ko?view=comfortable&filter=basic&value=0#q=issues.opened_by

image

@lunny
It is a bit strange. It seems that it is correct in Crowdin.

@yp05327 commented on GitHub (Jul 30, 2024): ![image](https://github.com/user-attachments/assets/c8de76e5-fb2a-43a1-8784-d984f6f6d543) https://crowdin.com/editor/gitea/68/enus-ko?view=comfortable&filter=basic&value=0#q=issues.opened_by ![image](https://github.com/user-attachments/assets/d49b7f31-c43c-4997-b9cc-a921fdedda39) @lunny It is a bit strange. It seems that it is correct in Crowdin.
GiteaMirror commented 2025-11-02 10:36:46 -06:00
Author
Owner
Copy Link

@yp05327 commented on GitHub (Aug 27, 2024):

There are also some other strange changes. All come from de265f3771

@yp05327 commented on GitHub (Aug 27, 2024): There are also some other strange changes. All come from https://github.com/go-gitea/gitea/commit/de265f377113766124e9846e120e2864bf01c60c
GiteaMirror commented 2025-11-02 10:36:46 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Aug 27, 2024):

There are also some other strange changes. All come from de265f3

See my comments for more information

image

image

@wxiaoguang commented on GitHub (Aug 27, 2024): > There are also some other strange changes. All come from [de265f3](https://github.com/go-gitea/gitea/commit/de265f377113766124e9846e120e2864bf01c60c) See my comments for more information ![image](https://github.com/user-attachments/assets/e0aade6e-94f4-4c33-83ee-140e1ae85dab) ![image](https://github.com/user-attachments/assets/133c356f-fdab-4ec6-8655-6f6b5ffada28)
GiteaMirror commented 2025-11-02 10:36:46 -06:00
Author
Owner
Copy Link

@yp05327 commented on GitHub (Aug 27, 2024):

I see where these double quotes come from and how it works.
So after the original locale files pulled from Crowdin, we will finally do some modified by the script before push.
(according to the workflow file)

Then I executed the script in my local, then I got this:
image
So if I understand correctly, if everything is correct, this should not happen, right?

@yp05327 commented on GitHub (Aug 27, 2024): I see where these double quotes come from and how it works. So after the original locale files pulled from Crowdin, we will finally do some modified by the script before push. (according to the workflow file) Then I executed the script in my local, then I got this: ![image](https://github.com/user-attachments/assets/f481a028-0ee9-4f5b-b9ea-89907576cae0) So if I understand correctly, if everything is correct, this should not happen, right?
GiteaMirror commented 2025-11-02 10:36:46 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Aug 27, 2024):

So if I understand correctly, if everything is correct, this should not happen, right?

"If everything is correct, this should not happen, right?": yes, the quotes should have been "cleaned up".

(I didn't look into it so I have no idea, just share some backgrounds)

@wxiaoguang commented on GitHub (Aug 27, 2024): > So if I understand correctly, if everything is correct, this should not happen, right? "If everything is correct, this should not happen, right?": yes, the quotes should have been "cleaned up". (I didn't look into it so I have no idea, just share some backgrounds)
GiteaMirror commented 2025-11-02 10:36:47 -06:00
Author
Owner
Copy Link

@yp05327 commented on GitHub (Aug 27, 2024):

I think I know what happened.
I notice the comment in L3:

this script runs in alpine image which only has sh shell

Then I find the original PR is #23254.
According to it, we were use Drone before, so this script is designed for Apline before.
Then I checked the OS where I executed the script, it is dev container which is Debain.
And we are using Github Actions, it uses Ubuntu.
Then I run the script in WSL which is Ubuntu, NOTHING happened.

So this script should be changed, or it should not run in Ubuntu, which will cause this issue.

@yp05327 commented on GitHub (Aug 27, 2024): I think I know what happened. I notice the comment in L3: > this script runs in alpine image which only has `sh` shell Then I find the original PR is #23254. According to it, we were use Drone before, so this script is designed for Apline before. Then I checked the OS where I executed the script, it is dev container which is `Debain`. And we are using Github Actions, it uses `Ubuntu`. Then I run the script in WSL which is Ubuntu, NOTHING happened. So this script should be changed, or it should not run in Ubuntu, which will cause this issue.
GiteaMirror commented 2025-11-02 10:36:47 -06:00
Author
Owner
Copy Link

@yp05327 commented on GitHub (Aug 27, 2024):

The version of sed:

In WSL:

sed (GNU sed) 4.8
Packaged by Debian
Copyright (C) 2020 Free Software Foundation, Inc.

In Dev Container:
bullseye

sed (GNU sed) 4.7
Packaged by Debian
Copyright (C) 2018 Free Software Foundation, Inc.

bookworm

sed (GNU sed) 4.9
Packaged by Debian
Copyright (C) 2022 Free Software Foundation, Inc.

@yp05327 commented on GitHub (Aug 27, 2024): The version of `sed`: In WSL: > sed (GNU sed) 4.8 > Packaged by Debian > Copyright (C) 2020 Free Software Foundation, Inc. In Dev Container: bullseye > sed (GNU sed) 4.7 > Packaged by Debian > Copyright (C) 2018 Free Software Foundation, Inc. bookworm > sed (GNU sed) 4.9 > Packaged by Debian > Copyright (C) 2022 Free Software Foundation, Inc.
GiteaMirror commented 2025-11-02 10:36:47 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Aug 27, 2024):

And we are using Github Actions, it uses Ubuntu.
Then I run the script in WSL which is Ubuntu, NOTHING happened.

Ubuntu's "sh" defaults to "dash", which has many differences

@wxiaoguang commented on GitHub (Aug 27, 2024): > And we are using Github Actions, it uses `Ubuntu`. > Then I run the script in WSL which is Ubuntu, NOTHING happened. Ubuntu's "sh" defaults to "dash", which has many differences
GiteaMirror commented 2025-11-02 10:36:47 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Aug 28, 2024):

Maybe we should rewrite these logic with Go code to avoid inconsistent between shell script commands.

@lunny commented on GitHub (Aug 28, 2024): Maybe we should rewrite these logic with Go code to avoid inconsistent between shell script commands.
GiteaMirror commented 2025-11-02 10:36:48 -06:00
Author
Owner
Copy Link

@denyskon commented on GitHub (Aug 28, 2024):

The only reason we need this script is the ini format we're using for translations. As I think that we want to switch to another format anyway (#27700), it wouldn't make sense to build a new tool for it.

@denyskon commented on GitHub (Aug 28, 2024): The only reason we need this script is the ini format we're using for translations. As I think that we want to switch to another format anyway (#27700), it wouldn't make sense to build a new tool for it.
GiteaMirror commented 2025-11-02 10:36:48 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Aug 29, 2024):

The only reason we need this script is the ini format we're using for translations. As I think that we want to switch to another format anyway (#27700), it wouldn't make sense to build a new tool for it.

Ah, yes. But we need to fix the bug before a new format comes out.

@lunny commented on GitHub (Aug 29, 2024): > The only reason we need this script is the ini format we're using for translations. As I think that we want to switch to another format anyway (#27700), it wouldn't make sense to build a new tool for it. Ah, yes. But we need to fix the bug before a new format comes out.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/ui type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13268
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?