Typo inside `Camo#Allways` #13249

Closed
opened 2025-11-02 10:36:13 -06:00 by GiteaMirror · 4 comments
Owner
Originally created by @litetex on GitHub (Jul 5, 2024). ### Description The value of ``Camo#Allways`` seems to have a typo. It should be ``Camo#Always`` with one ``l``. Can be found here: https://github.com/search?q=repo%3Ago-gitea%2Fgitea%20ALLWAYS&type=code * https://github.com/go-gitea/gitea/blob/12cb1d2998f2a307713ce979f8d585711e92061c/modules/setting/camo.go#L12 * https://github.com/go-gitea/gitea/blob/12cb1d2998f2a307713ce979f8d585711e92061c/docs/content/administration/config-cheat-sheet.en-us.md?plain=1#L592 * https://github.com/go-gitea/gitea/blob/12cb1d2998f2a307713ce979f8d585711e92061c/modules/markup/camo.go#L41 * https://github.com/go-gitea/gitea/blob/12cb1d2998f2a307713ce979f8d585711e92061c/custom/conf/app.example.ini#L526
GiteaMirror added the type/bug label 2025-11-02 10:36:13 -06:00
Author
Owner

@charles7668 commented on GitHub (Jul 6, 2024):

I don't think this is a typo. In this configuration context, "ALLWays" might mean "all_ways".

@charles7668 commented on GitHub (Jul 6, 2024): I don't think this is a typo. In this configuration context, "ALLWays" might mean "all_ways".
Author
Owner

@lunny commented on GitHub (Aug 14, 2024):

Close as @charles7668 's feedback.

@lunny commented on GitHub (Aug 14, 2024): Close as @charles7668 's feedback.
Author
Owner

@wxiaoguang commented on GitHub (Aug 14, 2024):

But it is indeed a typo. all_ways should be ALL_WAYS according to the naming style (underline between words).

@wxiaoguang commented on GitHub (Aug 14, 2024): But it is indeed a typo. `all_ways` should be `ALL_WAYS` according to the naming style (underline between words).
Author
Owner

@SuperSandro2000 commented on GitHub (Sep 20, 2024):

Since gitea has no strict config validation, it is really easy to miss configure this.

@SuperSandro2000 commented on GitHub (Sep 20, 2024): Since gitea has no strict config validation, it is really easy to miss configure this.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13249