Remove the Delete Branch confirmation modal from merged pull requests #13212

Open
opened 2025-11-02 10:35:09 -06:00 by GiteaMirror · 3 comments
Owner

Originally created by @silverwind on GitHub (Jun 26, 2024).

Feature Description

I find this modal annoying and it does not match GitHub behaviour where a merged PR branch is deleted in a single click. I think it's always safe to delete such branches, right?

Screenshots

image
Originally created by @silverwind on GitHub (Jun 26, 2024). ### Feature Description I find this modal annoying and it does not match GitHub behaviour where a merged PR branch is deleted in a single click. I think it's always safe to delete such branches, right? ### Screenshots <img width="907" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/73ec7a0a-5eb3-48e3-b59c-b04ac10db355">
GiteaMirror added the topic/ui-interactiontype/proposalproposal/accepted labels 2025-11-02 10:35:09 -06:00
Author
Owner

@delvh commented on GitHub (Jun 26, 2024):

I think it's always safe to delete such branches, right?

If this branch is fully contained within the main branch, yes.
However, git can't know this when you squash merge or rebase merge.

@delvh commented on GitHub (Jun 26, 2024): > I think it's always safe to delete such branches, right? If this branch is fully contained within the main branch, yes. However, git can't know this when you squash merge or rebase merge.
Author
Owner

@delvh commented on GitHub (Jun 26, 2024):

But yeah, branches that have no commit ahead of them should be deleteable without a modal

@delvh commented on GitHub (Jun 26, 2024): But yeah, branches that have no commit ahead of them should be deleteable without a modal
Author
Owner

@lunny commented on GitHub (Aug 14, 2024):

Maybe after #6375 resolved.

@lunny commented on GitHub (Aug 14, 2024): Maybe after #6375 resolved.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13212