Issue comments are not updated after editing (if attachments are disabled) #13204

New Issue

GiteaMirror · 2025-11-02T10:34:49-06:00

GiteaMirror commented

2025-11-02 10:34:49 -06:00

Originally created by @ukct on GitHub (Jun 25, 2024).

Description

Attempting to edit a comment and then save it results in a javascript error withn repo-issue-edit.js, if attachments are disabled.

To reproduce:

disable support for attachments
(https://docs.gitea.com/administration/config-cheat-sheet#issue-and-pull-request-attachments-attachment - set enabled to false)

From the UI:

create new issue
add a comment
edit that comment
saving the edit will throw a javascript error in the saveAndRefresh method in repo-issue-edit.js, when attempting to iterate through dropzoneInst

This appears to be a new issue introduced in 1.22.

Gitea Version

1.22.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Helm gitea chart

Database

PostgreSQL

Originally created by @ukct on GitHub (Jun 25, 2024). ### Description Attempting to edit a comment and then save it results in a javascript error withn repo-issue-edit.js, if attachments are disabled. To reproduce: * disable support for attachments (https://docs.gitea.com/administration/config-cheat-sheet#issue-and-pull-request-attachments-attachment - set enabled to false) From the UI: * create new issue * add a comment * edit that comment * saving the edit will throw a javascript error in the saveAndRefresh method in repo-issue-edit.js, when attempting to iterate through dropzoneInst This appears to be a new issue introduced in 1.22. ### Gitea Version 1.22.0 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Helm gitea chart ### Database PostgreSQL

GiteaMirror added the type/bug label 2025-11-02 10:34:49 -06:00

GiteaMirror closed this issue

2025-11-02 10:34:49 -06:00

GiteaMirror commented

2025-11-02 10:34:50 -06:00

@wxiaoguang commented on GitHub (Jun 25, 2024):

Regression of Remove jQuery .map() and enable eslint rules for it (#29272)

The problem will be fixed by: Refactor dropzone #31482

For 1.22 it needs a simple&separate fix: Fix dropzone JS error when attachment is disabled #31486

@wxiaoguang commented on GitHub (Jun 25, 2024): Regression of Remove jQuery .map() and enable eslint rules for it (#29272) ---- The problem will be fixed by: Refactor dropzone #31482 For 1.22 it needs a simple&separate fix: Fix dropzone JS error when attachment is disabled #31486

GiteaMirror commented

2025-11-02 10:34:50 -06:00

@wxiaoguang commented on GitHub (Jun 29, 2024):

Fixed by #31486 and it is in 1.22-nightly

@wxiaoguang commented on GitHub (Jun 29, 2024): Fixed by #31486 and it is in 1.22-nightly

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#13204