The link to bypass .git-blame-ignore-revs in the blame view links to the wrong file #13180

Closed
opened 2025-11-02 10:33:49 -06:00 by GiteaMirror · 2 comments
Owner

Originally created by @noodlebox on GitHub (Jun 19, 2024).

Description

When revisions are hidden from the blame view, the URL for the link to bypass this feature appends ?bypass-blame-ignore=true to the path of .git-blame-ignore-revs ($revsFileLink again) instead of to that of the current file.

1c15452687/templates/repo/blame.tmpl (L5)
7b8e418da1/options/locale/locale_en-US.ini (L1087)

On the demo site: https://demo.gitea.com/noodlebox/test/blame/branch/main/README.md

Screenshots

image

Gitea Version

N/A

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

N/A

Browser Version

Any

Originally created by @noodlebox on GitHub (Jun 19, 2024). ### Description When revisions are hidden from the blame view, the URL for the link to bypass this feature appends `?bypass-blame-ignore=true` to the path of `.git-blame-ignore-revs` (`$revsFileLink` again) instead of to that of the current file. https://github.com/go-gitea/gitea/blob/1c1545268743d7d4536a5ff2a137af7c255f45c8/templates/repo/blame.tmpl#L5 https://github.com/go-gitea/gitea/blob/7b8e418da1e082786b844562a05864ec1177ce97/options/locale/locale_en-US.ini#L1087 On the demo site: https://demo.gitea.com/noodlebox/test/blame/branch/main/README.md ### Screenshots ![image](https://github.com/go-gitea/gitea/assets/308464/b8ed2f1c-6a1c-4b01-82f7-bac7affaf879) ### Gitea Version N/A ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System N/A ### Browser Version Any
GiteaMirror added the type/bugtopic/ui labels 2025-11-02 10:33:49 -06:00
Author
Owner

@wxiaoguang commented on GitHub (Jun 20, 2024):

I have an idea to fix it in 1.23 but it needs some new framework-level mechanism to handle URLs. 🤔

@wxiaoguang commented on GitHub (Jun 20, 2024): I have an idea to fix it in 1.23 but it needs some new framework-level mechanism to handle URLs. 🤔
Author
Owner

@wxiaoguang commented on GitHub (Jun 20, 2024):

Oops, it is a longstanding bug (maybe nobody ever used that link before), we can have a quick fix for it:

-> Fix the link for .git-blame-ignore-revs bypass #31432

@wxiaoguang commented on GitHub (Jun 20, 2024): Oops, it is a longstanding bug (maybe nobody ever used that link before), we can have a quick fix for it: -> Fix the link for .git-blame-ignore-revs bypass #31432
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13180