github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

"Show changes since your last review" button should still show even if a review was requested from me again #13177

New Issue
Closed
opened 2025-11-02 10:33:45 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 10:33:45 -06:00
Owner
Copy Link

Originally created by @Gr3q on GitHub (Jun 19, 2024).

Description

A PR "Files Changed" tab's "Filter by commit" button's "Show changes since your last review" sub button should still show even if a review was requested from me again after my review. Note that the previous review was not dismissed.

My guess is that the logic only looks at the top of the review stack of a person, and when a request is on top it just skips the part where it works out the difference.

Gitea Version

1.21.11

Can you reproduce the bug on the Gitea demo site?

No, because I need 2 account for that, but I'll do that when I have time.

Log Gist

No response

Screenshots

Before a new review was requested of me

20240619_18h04m14s_grim
20240619_18h04m04s_grim

After a new review was requested of me

20240619_18h07m48s_grim
20240619_18h07m55s_grim

Git Version

No response

Operating System

Ubuntu 22.04

How are you running Gitea?

self-hosted docker image

Database

None

Originally created by @Gr3q on GitHub (Jun 19, 2024). ### Description A PR "Files Changed" tab's "Filter by commit" button's "Show changes since your last review" sub button should still show even if a review was requested from me again after my review. Note that the previous review was not dismissed. My guess is that the logic only looks at the top of the review stack of a person, and when a request is on top it just skips the part where it works out the difference. ### Gitea Version 1.21.11 ### Can you reproduce the bug on the Gitea demo site? No, because I need 2 account for that, but I'll do that when I have time. ### Log Gist _No response_ ### Screenshots #### Before a new review was requested of me ![20240619_18h04m14s_grim](https://github.com/go-gitea/gitea/assets/22377521/bcd8d39f-1d43-40e5-ab2e-5d28e71e7d1c) ![20240619_18h04m04s_grim](https://github.com/go-gitea/gitea/assets/22377521/7191d00b-99c6-437d-b77d-275d02ca5f92) #### After a new review was requested of me ![20240619_18h07m48s_grim](https://github.com/go-gitea/gitea/assets/22377521/dc63b379-1e30-47d0-be83-dee67cd4048e) ![20240619_18h07m55s_grim](https://github.com/go-gitea/gitea/assets/22377521/6fc8635c-01aa-4afe-8c0a-dc9b7e1f816d) ### Git Version _No response_ ### Operating System Ubuntu 22.04 ### How are you running Gitea? self-hosted docker image ### Database None
GiteaMirror added the type/bug label 2025-11-02 10:33:45 -06:00
GiteaMirror commented 2025-11-02 10:33:46 -06:00
Author
Owner
Copy Link

@Zettat123 commented on GitHub (Sep 26, 2024):

Your guess is correct. A review request is a special type of review.
3269b04d61/models/issues/review.go (L101-L102)

When we create a review request, we do not need to specify the commit ID.
3269b04d61/models/issues/review.go (L692-L698)

Therefore, when the latest review is a review request, the commit ID will be empty, which will cause the "Show changes since your last review" button to not show.

To fix this issue, I think we should improve the logic of querying the latest review. In this case, we should try to get the latest review whose commit ID is not empty.

@Zettat123 commented on GitHub (Sep 26, 2024): Your guess is correct. A review request is a special type of review. https://github.com/go-gitea/gitea/blob/3269b04d61ffe6a7ce462cd05ee150e4491124e8/models/issues/review.go#L101-L102 When we create a review request, we do not need to specify the commit ID. https://github.com/go-gitea/gitea/blob/3269b04d61ffe6a7ce462cd05ee150e4491124e8/models/issues/review.go#L692-L698 Therefore, when the latest review is a review request, the commit ID will be empty, which will cause the "Show changes since your last review" button to not show. To fix this issue, I think we should improve the logic of querying the latest review. In this case, we should try to get the latest review whose commit ID is not empty.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#13177
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?