Untangle offline mode #13040

New Issue

GiteaMirror · 2025-11-02T10:28:30-06:00

GiteaMirror commented

2025-11-02 10:28:30 -06:00

Originally created by @SuperSandro2000 on GitHub (May 27, 2024).

Description

Right now the situation around the offline mode and federated avatars is a bit of a mess especially after #28548. I've tried to understand the code around it and not noticed, that the offline mode isn't changing anything regarding to CDN but is just used as an override to Disable Gravatar and Enable Federated Avatars. I think it would be a lot less confusing if the offline mode setting would be just removed and the avatar features are controlled directly. Also since GRAVATAR_SOURCE exists, DISABLE_GRAVATAR can also be removed.

Gitea Version

1.22

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

With NixOS ofcourse

Database

PostgreSQL

Originally created by @SuperSandro2000 on GitHub (May 27, 2024). ### Description Right now the situation around the offline mode and federated avatars is a bit of a mess especially after #28548. I've tried to understand the code around it and not noticed, that the offline mode isn't changing anything regarding to CDN but is just used as an override to Disable Gravatar and Enable Federated Avatars. I think it would be a lot less confusing if the offline mode setting would be just removed and the avatar features are controlled directly. Also since GRAVATAR_SOURCE exists, DISABLE_GRAVATAR can also be removed. ### Gitea Version 1.22 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? With NixOS ofcourse ### Database PostgreSQL

GiteaMirror added the type/bug label 2025-11-02 10:28:30 -06:00

GiteaMirror commented

2025-11-02 10:28:31 -06:00

@wxiaoguang commented on GitHub (May 27, 2024):

Hmm yes, some options on the installation page and in the config file are totally a mess .... I totally agree with you 🤣

They need to be refactored with a new design.

@wxiaoguang commented on GitHub (May 27, 2024): Hmm yes, some options on the installation page and in the config file are totally a mess .... I totally agree with you 🤣 They need to be refactored with a new design.

GiteaMirror commented

2025-11-02 10:28:31 -06:00

@Sharaf5 commented on GitHub (May 27, 2024):

that option was mainly to disable the cdn and just serve locally
I think it's still functional as I really notice no cdn actually

Note : I can't tell whether the code itself need refactoring or not

@Sharaf5 commented on GitHub (May 27, 2024): that option was mainly to disable the cdn and just serve locally I think it's still functional as I really notice no cdn actually ![Screenshot_20240527_223704](https://github.com/go-gitea/gitea/assets/36330265/1b2a371d-ba92-4698-9d3c-51e4c597e0ac) > Note : I can't tell whether the code itself need refactoring or not

GiteaMirror commented

2025-11-02 10:28:31 -06:00

@SuperSandro2000 commented on GitHub (May 29, 2024):

that option was mainly to disable the cdn and just serve locally

I don't think that functionality exists anymore. I have offline mode turned off and all assets except for LibreAvatar and some extensions are served from Gitea itself.

@SuperSandro2000 commented on GitHub (May 29, 2024): > that option was mainly to disable the cdn and just serve locally I don't think that functionality exists anymore. I have offline mode turned off and all assets except for LibreAvatar and some extensions are served from Gitea itself.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#13040