Show modal will cause body width becomeing smaller #12947

Closed
opened 2025-11-02 10:25:59 -06:00 by GiteaMirror · 7 comments
Owner

Originally created by @yp05327 on GitHub (May 2, 2024).

Description

image

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

Originally created by @yp05327 on GitHub (May 2, 2024). ### Description ![image](https://github.com/go-gitea/gitea/assets/18380374/336a3b38-f0f2-42cc-8884-7f7310d6e8a3) ### Gitea Version latest ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? build ### Database None
GiteaMirror added the type/bugtopic/ui labels 2025-11-02 10:25:59 -06:00
Author
Owner

@yp05327 commented on GitHub (May 2, 2024):

image
margin-right will become bigger

@yp05327 commented on GitHub (May 2, 2024): ![image](https://github.com/go-gitea/gitea/assets/18380374/5d0a1c83-58d9-4121-a857-631c85371c1e) margin-right will become bigger
Author
Owner

@yp05327 commented on GitHub (May 2, 2024):

https://forum.freecodecamp.org/t/issues-with-bootstrap-5-2-modal/570924

this will be added after open a modal
image

@yp05327 commented on GitHub (May 2, 2024): https://forum.freecodecamp.org/t/issues-with-bootstrap-5-2-modal/570924 this will be added after open a modal ![image](https://github.com/go-gitea/gitea/assets/18380374/fb084974-5a51-4e05-b65e-b01f1233706c)
Author
Owner

@wxiaoguang commented on GitHub (May 2, 2024):

No, not "upstream".

The tw-overflow-hidden was introduced by Remove fomantic dimmer module #30723 ,

@wxiaoguang commented on GitHub (May 2, 2024): No, not "upstream". The `tw-overflow-hidden` was introduced by Remove fomantic dimmer module #30723 ,
Author
Owner

@yp05327 commented on GitHub (May 2, 2024):

but it seems that margin-right is from bootstrap 🤔

@yp05327 commented on GitHub (May 2, 2024): but it seems that margin-right is from bootstrap 🤔
Author
Owner

@silverwind commented on GitHub (May 2, 2024):

The tw-overflow-hidden on body could maybe replaced with pointer-events-none on the dimmer to inhibit scrolling the body while modal is open. But I'm pretty sure fomantic used the former too.

Edit: Ah no, that would prevent closing the modal with dimmer click.

@silverwind commented on GitHub (May 2, 2024): The `tw-overflow-hidden` on body could maybe replaced with `pointer-events-none` on the dimmer to inhibit scrolling the body while modal is open. But I'm pretty sure fomantic used the former too. Edit: Ah no, that would prevent closing the modal with dimmer click.
Author
Owner

@silverwind commented on GitHub (May 2, 2024):

Margin is coming from fomantic modal module:

59d9b40987/src/definitions/modules/modal.js (L611-L617)

@silverwind commented on GitHub (May 2, 2024): Margin is coming from fomantic modal module: https://github.com/fomantic/Fomantic-UI/blob/59d9b409879ad9413ea0a3efa4ab2e51017ad9b9/src/definitions/modules/modal.js#L611-L617
Author
Owner

@silverwind commented on GitHub (May 2, 2024):

https://github.com/go-gitea/gitea/pull/30831 will fix it.

@silverwind commented on GitHub (May 2, 2024): https://github.com/go-gitea/gitea/pull/30831 will fix it.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12947