github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Staying on the issue view page for a long time and then input something on comment form and submitting returned error #12794

New Issue
Open
opened 2025-11-02 10:21:14 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 10:21:14 -06:00
Owner
Copy Link

Originally created by @lunny on GitHub (Apr 8, 2024).

image

I guess because the session or the csrf is expired so that when click the submission button, it will return a redirect response. But the Ajax functions haven't catch that and an unrelated error displayed.

I think the best choice is leave this page and follow the redirect?

Originally created by @lunny on GitHub (Apr 8, 2024). <img width="1254" alt="image" src="https://github.com/go-gitea/gitea/assets/81045/11c83d42-3077-4f47-8c5c-ce8a646b74a7"> I guess because the session or the csrf is expired so that when click the submission button, it will return a redirect response. But the Ajax functions haven't catch that and an unrelated error displayed. I think the best choice is leave this page and follow the redirect?
GiteaMirror added the type/bug label 2025-11-02 10:21:14 -06:00
GiteaMirror commented 2025-11-02 10:21:15 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Apr 8, 2024):

Maybe we need to refresh the CSFR token via JS in both window.config and all active <form>s shortly before expiry. I guess a simple setTimeout on page load shall do.

@silverwind commented on GitHub (Apr 8, 2024): Maybe we need to refresh the CSFR token via JS in both `window.config` and all active `<form>`s shortly before expiry. I guess a simple `setTimeout` on page load shall do.
GiteaMirror commented 2025-11-02 10:21:15 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Apr 8, 2024):

If we are expiring crsf token, we shouldn't. E.g. only expire them at the end of the session.

@silverwind commented on GitHub (Apr 8, 2024): If we are expiring crsf token, we [shouldn't](https://security.stackexchange.com/a/56520). E.g. only expire them at the end of the session.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12794
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?