github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Can't remove WIP from PR title #12708

New Issue
Closed
opened 2025-11-02 10:18:40 -06:00 by GiteaMirror · 12 comments
GiteaMirror commented 2025-11-02 10:18:40 -06:00
Owner
Copy Link

Originally created by @sebastian-sauer on GitHub (Mar 22, 2024).

Description

When creating a PR in WIP state it is not possible (1.21.9) to remove the WIP: prefix from title.

Steps to reproduce:

  • Create a repo / or use an existing one without CODEOWNERs files
  • Create a PR with WIP: Prefix in title
  • Open the PR and try to remove the WIP Prefix

https://try.gitea.io/sebastian-sauer/test-wip-bug/pulls/1

Log output:

2024/03/22 09:57:56 ...rs/web/repo/issue.go:2163:UpdateIssueTitle() [E] ChangeTitle: exit status 128 - fatal: ambiguous argument '': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
 - fatal: ambiguous argument '': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Gitea Version

1.21.9

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Binary from download site

Database

None

Originally created by @sebastian-sauer on GitHub (Mar 22, 2024). ### Description When creating a PR in WIP state it is not possible (1.21.9) to remove the WIP: prefix from title. Steps to reproduce: - Create a repo / or use an existing one without CODEOWNERs files - Create a PR with WIP: Prefix in title - Open the PR and try to remove the WIP Prefix https://try.gitea.io/sebastian-sauer/test-wip-bug/pulls/1 Log output: ``` 2024/03/22 09:57:56 ...rs/web/repo/issue.go:2163:UpdateIssueTitle() [E] ChangeTitle: exit status 128 - fatal: ambiguous argument '': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' - fatal: ambiguous argument '': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' ``` ### Gitea Version 1.21.9 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Binary from download site ### Database None
GiteaMirror added the issue/criticaltype/bugissue/workaround labels 2025-11-02 10:18:40 -06:00
GiteaMirror commented 2025-11-02 10:18:41 -06:00
Author
Owner
Copy Link

@sebastian-sauer commented on GitHub (Mar 22, 2024):

Unfortunately this breaks all WIP PRs as there is no chance to remove the WIP and merge it

@sebastian-sauer commented on GitHub (Mar 22, 2024): Unfortunately this breaks all WIP PRs as there is no chance to remove the WIP and merge it
GiteaMirror commented 2025-11-02 10:18:41 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 22, 2024):

Yup, it is broken (for unknown reason). I will take a look.

Update: lunny said he is working on it.

@wxiaoguang commented on GitHub (Mar 22, 2024): Yup, it is broken (for unknown reason). I will take a look. ---- Update: lunny said he is working on it.
GiteaMirror commented 2025-11-02 10:18:42 -06:00
Author
Owner
Copy Link

@KarenArzumanyan commented on GitHub (Mar 22, 2024):

This stopped our development process. We have serious pull requests with WIP, which we now cannot remove and merge.
Please release the fix as quickly as possible.

How can we remove WIP in version 1.21.9 now while we wait for a fix?
Maybe there is a flag in the database?

@KarenArzumanyan commented on GitHub (Mar 22, 2024): This stopped our development process. We have serious pull requests with WIP, which we now cannot remove and merge. Please release the fix as quickly as possible. How can we remove WIP in version 1.21.9 now while we wait for a fix? Maybe there is a flag in the database?
GiteaMirror commented 2025-11-02 10:18:42 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 22, 2024):

#29999 will fix this.

@lunny commented on GitHub (Mar 22, 2024): #29999 will fix this.
GiteaMirror commented 2025-11-02 10:18:42 -06:00
Author
Owner
Copy Link

@KarenArzumanyan commented on GitHub (Mar 22, 2024):

#29999 will fix this.

Yes. Thank you. I have seen that.
But I need a release build to update.
Until it is released, I need to somehow solve the problem in the installed 1.21.9.
PS: Ubuntu 20.04.6 LTS + MySQL 8.0.36

@KarenArzumanyan commented on GitHub (Mar 22, 2024): > #29999 will fix this. Yes. Thank you. I have seen that. But I need a release build to update. Until it is released, I need to somehow solve the problem in the installed 1.21.9. PS: Ubuntu 20.04.6 LTS + MySQL 8.0.36
GiteaMirror commented 2025-11-02 10:18:42 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Mar 22, 2024):

#29999 will fix this.

Yes. Thank you. I have seen that. But I need a release build to update. Until it is released, I need to somehow solve the problem in the installed 1.21.9. PS: Ubuntu 20.04.6 LTS + MySQL 8.0.36

You can use 1.21 nightly after that PR is merged and backported.

@silverwind commented on GitHub (Mar 22, 2024): > > #29999 will fix this. > > Yes. Thank you. I have seen that. But I need a release build to update. Until it is released, I need to somehow solve the problem in the installed 1.21.9. PS: Ubuntu 20.04.6 LTS + MySQL 8.0.36 You can use 1.21 nightly after that PR is merged and backported.
GiteaMirror commented 2025-11-02 10:18:43 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 22, 2024):

If you could build your own binary, here is a workaround patch (for both 1.22 and 1.21)

If there is any difficulty, I could also help to build a binary with it (please provide your environment/OS/database requirement, for example: linux amd64 + mysql)

(expand here to see the quick patch, only 2 lines)

diff --git a/services/issue/issue.go b/services/issue/issue.go
index 81fa980b6b..0afae0c7ff 100644
--- a/services/issue/issue.go
+++ b/services/issue/issue.go
@@ -81,7 +81,7 @@ func ChangeTitle(ctx context.Context, issue *issues_model.Issue, doer *user_mode
                        var err error
                        reviewNotifers, err = PullRequestCodeOwnersReview(ctx, issue, issue.PullRequest)
                        if err != nil {
-                               return err
+                               _ = err
                        }
                }
                return nil
diff --git a/services/pull/pull.go b/services/pull/pull.go
index 756e542c4d..b3ae63abb1 100644
--- a/services/pull/pull.go
+++ b/services/pull/pull.go
@@ -130,7 +130,7 @@ func NewPullRequest(ctx context.Context, repo *repo_model.Repository, issue *iss
                if !pr.IsWorkInProgress(ctx) {
                        reviewNotifers, err = issue_service.PullRequestCodeOwnersReview(ctx, issue, pr)
                        if err != nil {
-                               return err
+                               _ = err
                        }
                }
                return nil
@wxiaoguang commented on GitHub (Mar 22, 2024): If you could build your own binary, here is a workaround patch (for both 1.22 and 1.21) If there is any difficulty, I could also help to build a binary with it (please provide your environment/OS/database requirement, for example: linux amd64 + mysql) (expand here to see the quick patch, only 2 lines) <details> ```diff diff --git a/services/issue/issue.go b/services/issue/issue.go index 81fa980b6b..0afae0c7ff 100644 --- a/services/issue/issue.go +++ b/services/issue/issue.go @@ -81,7 +81,7 @@ func ChangeTitle(ctx context.Context, issue *issues_model.Issue, doer *user_mode var err error reviewNotifers, err = PullRequestCodeOwnersReview(ctx, issue, issue.PullRequest) if err != nil { - return err + _ = err } } return nil diff --git a/services/pull/pull.go b/services/pull/pull.go index 756e542c4d..b3ae63abb1 100644 --- a/services/pull/pull.go +++ b/services/pull/pull.go @@ -130,7 +130,7 @@ func NewPullRequest(ctx context.Context, repo *repo_model.Repository, issue *iss if !pr.IsWorkInProgress(ctx) { reviewNotifers, err = issue_service.PullRequestCodeOwnersReview(ctx, issue, pr) if err != nil { - return err + _ = err } } return nil ``` </details>
GiteaMirror commented 2025-11-02 10:18:43 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 22, 2024):

How can we remove WIP in version 1.21.9 now while we wait for a fix?
Maybe there is a flag in the database?

The trick is issue table's name column. Just remove the WIP: from the "name" (aka title), then the PR becomes a normal PR.

And thanks to Gr3q, there is an API workaround: https://github.com/go-gitea/gitea/pull/29999#issuecomment-2015172719

@wxiaoguang commented on GitHub (Mar 22, 2024): > How can we remove WIP in version 1.21.9 now while we wait for a fix? > Maybe there is a flag in the database? The trick is `issue` table's `name` column. Just remove the `WIP: ` from the "name" (aka title), then the PR becomes a normal PR. ---- And thanks to Gr3q, there is an API workaround: https://github.com/go-gitea/gitea/pull/29999#issuecomment-2015172719
GiteaMirror commented 2025-11-02 10:18:43 -06:00
Author
Owner
Copy Link

@KarenArzumanyan commented on GitHub (Mar 22, 2024):

The trick is issue table's name column. Just remove the WIP: from the "name" (aka title), then the PR becomes a normal PR.

Thank you! This is what I needed.

@KarenArzumanyan commented on GitHub (Mar 22, 2024): > The trick is `issue` table's `name` column. Just remove the `WIP: ` from the "name" (aka title), then the PR becomes a normal PR. Thank you! This is what I needed.
GiteaMirror commented 2025-11-02 10:18:44 -06:00
Author
Owner
Copy Link

@jpraet commented on GitHub (Mar 23, 2024):

And thanks to Gr3q, there is an API workaround: #29999 (comment)

That probably indicates that the codeowners logic is not triggered when changing WIP status via the API?
Which also seems like a bug.

@jpraet commented on GitHub (Mar 23, 2024): > And thanks to Gr3q, there is an API workaround: [#29999 (comment)](https://github.com/go-gitea/gitea/pull/29999#issuecomment-2015172719) That probably indicates that the codeowners logic is not triggered when changing WIP status via the API? Which also seems like a bug.
GiteaMirror commented 2025-11-02 10:18:44 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 25, 2024):

For this bug:

  • It could be fixed by updating to pre-1.21.10:
@wxiaoguang commented on GitHub (Mar 25, 2024): For this bug: * It could be fixed by updating to pre-1.21.10: * Docker image: use gitea/gitea:1.21-nightly and gitea/gitea:1.21-nightly-rootless * Binary: download from https://dl.gitea.com/gitea/1.21/
GiteaMirror commented 2025-11-02 10:18:44 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Mar 25, 2024):

And thanks to Gr3q, there is an API workaround: #29999 (comment)

That probably indicates that the codeowners logic is not triggered when changing WIP status via the API? Which also seems like a bug.

It could be another bug, maybe it needs a new issue.

@wxiaoguang commented on GitHub (Mar 25, 2024): > > And thanks to Gr3q, there is an API workaround: [#29999 (comment)](https://github.com/go-gitea/gitea/pull/29999#issuecomment-2015172719) > > That probably indicates that the codeowners logic is not triggered when changing WIP status via the API? Which also seems like a bug. It could be another bug, maybe it needs a new issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/critical issue/workaround type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12708
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?