Login UI layout issue, the top marin of the login div missed. #12700

New Issue

GiteaMirror · 2025-11-02T10:18:26-06:00

GiteaMirror commented

2025-11-02 10:18:26 -06:00

Originally created by @lunny on GitHub (Mar 22, 2024).

Originally created by @lunny on GitHub (Mar 22, 2024). <img width="1905" alt="image" src="https://github.com/go-gitea/gitea/assets/81045/a029f219-529d-4687-865b-b4d29f2fd1bc">

GiteaMirror added the topic/ui type/bug labels 2025-11-02 10:18:26 -06:00

GiteaMirror closed this issue

2025-11-02 10:18:26 -06:00

GiteaMirror commented

2025-11-02 10:18:27 -06:00

@wxiaoguang commented on GitHub (Mar 22, 2024):

Regression of #29922? @silverwind

The margin of page-content was removed:

.page-content {
  margin-top: 15px;
}

@wxiaoguang commented on GitHub (Mar 22, 2024): Regression of #29922? @silverwind The margin of page-content was removed: ``` .page-content { margin-top: 15px; } ```

GiteaMirror commented

2025-11-02 10:18:27 -06:00

@silverwind commented on GitHub (Mar 22, 2024):

Ah I did not see that because my login ui is different with the tab bar:

@silverwind commented on GitHub (Mar 22, 2024): Ah I did not see that because my login ui is different with the tab bar: <img width="1341" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/b47689f8-73e5-4ee4-a633-2857df81fb3a">

GiteaMirror commented

2025-11-02 10:18:27 -06:00

@silverwind commented on GitHub (Mar 22, 2024):

What exactly is necessary to reproduce the tabbar-less login ui?

@silverwind commented on GitHub (Mar 22, 2024): What exactly is necessary to reproduce the tabbar-less login ui?

GiteaMirror commented

2025-11-02 10:18:27 -06:00

@wxiaoguang commented on GitHub (Mar 22, 2024):

I think .page-content really needs this margin-top

We should use margin for outer spaces as much as possible. They could overlap gracefully.

@wxiaoguang commented on GitHub (Mar 22, 2024): I think `.page-content` really needs this margin-top We should use margin for outer spaces as much as possible. They could overlap gracefully.

GiteaMirror commented

2025-11-02 10:18:27 -06:00

@silverwind commented on GitHub (Mar 22, 2024):

No, I think the content should itself decide whether it wants margin or not. Many tabbars want 0 margin. It's not for the .page-content to decide.

@silverwind commented on GitHub (Mar 22, 2024): No, I think the content should itself decide whether it wants margin or not. Many tabbars want 0 margin. It's not for the `.page-content` to decide.

GiteaMirror commented

2025-11-02 10:18:28 -06:00

@silverwind commented on GitHub (Mar 22, 2024):

And @lunny don't call it broken. A minor layout issue is far from "broken" :)

@silverwind commented on GitHub (Mar 22, 2024): And @lunny don't call it broken. A minor layout issue is far from "broken" :)

GiteaMirror commented

2025-11-02 10:18:28 -06:00

@silverwind commented on GitHub (Mar 22, 2024):

The problem is the negative margins from fomantic on .ui.grid.

@silverwind commented on GitHub (Mar 22, 2024): The problem is the negative margins from fomantic on `.ui.grid`.

GiteaMirror commented

2025-11-02 10:18:28 -06:00

@lunny commented on GitHub (Mar 22, 2024):

And @lunny don't call it broken. A minor layout issue is far from "broken" :)

Please help me to change it to a proper word.

@lunny commented on GitHub (Mar 22, 2024): > And @lunny don't call it broken. A minor layout issue is far from "broken" :) Please help me to change it to a proper word.

GiteaMirror commented

2025-11-02 10:18:28 -06:00

@silverwind commented on GitHub (Mar 22, 2024):

I would call it "misaligned", or "incorrect render".

@silverwind commented on GitHub (Mar 22, 2024): I would call it "misaligned", or "incorrect render".

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#12700