github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

The user profile follow button always shows "Follow", never "Unfollow" #12653

New Issue
Closed
opened 2025-11-02 10:17:14 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 10:17:14 -06:00
Owner
Copy Link

Originally created by @yardenshoham on GitHub (Mar 15, 2024).

Description

To determine the string, the template looks at $.IsFollowing. See:
6692894637/templates/shared/user/profile_big_avatar.tmpl (L120)

Since https://github.com/go-gitea/gitea/pull/29248, the IsFollowing parameter is never set as the line that set it was deleted. The relevant diff

Gitea Version

Current main

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

demo

Git Version

No response

Operating System

No response

How are you running Gitea?

It doesn't matter

Database

SQLite

Originally created by @yardenshoham on GitHub (Mar 15, 2024). ### Description To determine the string, the template looks at `$.IsFollowing`. See: https://github.com/go-gitea/gitea/blob/66928946372c85cd41d404f63e3c1da1bdeca3ca/templates/shared/user/profile_big_avatar.tmpl#L120 Since https://github.com/go-gitea/gitea/pull/29248, the `IsFollowing` parameter is never set as the line that set it was deleted. [The relevant diff](https://github.com/go-gitea/gitea/pull/29248/files#diff-2b0b591787f16325539485e648a09ab6d3177f47dc129cfe84a35ffe141dfd19L39) ### Gitea Version Current main ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots ![demo](https://github.com/go-gitea/gitea/assets/20454870/909df6e1-5aad-4726-acec-cd3ef558f566) ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? It doesn't matter ### Database SQLite
GiteaMirror added the issue/regressionskip-changelogtype/bug labels 2025-11-02 10:17:14 -06:00
GiteaMirror commented 2025-11-02 10:17:15 -06:00
Author
Owner
Copy Link

@yardenshoham commented on GitHub (Mar 15, 2024):

CC @zokkis

@yardenshoham commented on GitHub (Mar 15, 2024): CC @zokkis
GiteaMirror commented 2025-11-02 10:17:15 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Mar 15, 2024):

Definitely need to fix this before 1.22.

@silverwind commented on GitHub (Mar 15, 2024): Definitely need to fix this before 1.22.
GiteaMirror commented 2025-11-02 10:17:15 -06:00
Author
Owner
Copy Link

@lng2020 commented on GitHub (Mar 17, 2024):

It also breaks the user description on the profile page.
That PR is mainly focused on organization and accidentally deleted some code in the function PrepareContextForProfileBigAvatar that the user profile page also used.
So I guess just added those codes back in the function PrepareContextForProfileBigAvatar?

@lng2020 commented on GitHub (Mar 17, 2024): It also breaks the user description on the profile page. That PR is mainly focused on organization and accidentally deleted some code in the function `PrepareContextForProfileBigAvatar` that the user profile page also used. So I guess just added those codes back in the function `PrepareContextForProfileBigAvatar`?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/regression skip-changelog type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?