repo page still shows incorrect clone url under different domain names #12554

Closed
opened 2025-11-02 10:13:53 -06:00 by GiteaMirror · 8 comments
Owner

Originally created by @darkclip on GitHub (Feb 28, 2024).

Description

I reported this issue weeks ago, see #29084 , it was quickly patched and marked as fixed.
But after the merge of that patch, the bug is still there.

Gitea Version

1.21.7

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

wrong

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None

Originally created by @darkclip on GitHub (Feb 28, 2024). ### Description I reported this issue weeks ago, see #29084 , it was quickly patched and marked as fixed. But after the merge of that patch, the bug is still there. ### Gitea Version 1.21.7 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots ![wrong](https://github.com/go-gitea/gitea/assets/2414081/adaa16b5-38df-4d17-96a3-4f324d75648c) ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? docker ### Database None
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 10:13:53 -06:00
Author
Owner

@ravensorb commented on GitHub (Feb 28, 2024):

same is try for packages

@ravensorb commented on GitHub (Feb 28, 2024): same is try for packages
Author
Owner

@lunny commented on GitHub (Feb 28, 2024):

I cannot reproduce it in my local both main and v1.21. How did you reproduce it on try site?

@lunny commented on GitHub (Feb 28, 2024): I cannot reproduce it in my local both main and v1.21. How did you reproduce it on try site?
Author
Owner

@lunny commented on GitHub (Feb 28, 2024):

same is try for packages

Packages should be another issue.

@lunny commented on GitHub (Feb 28, 2024): > same is try for packages Packages should be another issue.
Author
Owner

@darkclip commented on GitHub (Feb 28, 2024):

I cannot reproduce it in my local both main and v1.21. How did you reproduce it on try site?

Just as I stated in the original issue report #29084, set ROOR_URL = https://git.aaa.com:8443/, then visit through https://git.bbb.com/.

@darkclip commented on GitHub (Feb 28, 2024): > I cannot reproduce it in my local both main and v1.21. How did you reproduce it on try site? Just as I stated in the original issue report #29084, set `ROOR_URL = https://git.aaa.com:8443/`, then visit through `https://git.bbb.com/`.
Author
Owner

@darkclip commented on GitHub (Feb 28, 2024):

I suspect it's because templates/repo/clone_script.tmp is not being set with url.port = window.location.port;.
But I'm not sure.

@darkclip commented on GitHub (Feb 28, 2024): I suspect it's because `templates/repo/clone_script.tmp` is not being set with `url.port = window.location.port;.` But I'm not sure.
Author
Owner

@wxiaoguang commented on GitHub (Feb 28, 2024):

Unfortunately , #29085 didn't fix the "clone_script.tmpl" .....

@silverwind would you like to take a look?

@wxiaoguang commented on GitHub (Feb 28, 2024): Unfortunately , #29085 didn't fix the "clone_script.tmpl" ..... @silverwind would you like to take a look?
Author
Owner

@silverwind commented on GitHub (Feb 28, 2024):

Ah, I wasn't aware that clone_script was still a thing. I thought we had replaced it entirely with the <gitea-origin-url>, but apparently not and it's still in use for <input>. Yes it needs the same fix.

@silverwind commented on GitHub (Feb 28, 2024): Ah, I wasn't aware that `clone_script` was still a thing. I thought we had replaced it entirely with the `<gitea-origin-url>`, but apparently not and it's still in use for `<input>`. Yes it needs the same fix.
Author
Owner

@silverwind commented on GitHub (Feb 28, 2024):

https://github.com/go-gitea/gitea/pull/29470

@silverwind commented on GitHub (Feb 28, 2024): https://github.com/go-gitea/gitea/pull/29470
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12554