Force push in pull request does not rename the commit in the conversation page #12440

New Issue

GiteaMirror · 2025-11-02T10:09:54-06:00

GiteaMirror commented

2025-11-02 10:09:54 -06:00

Originally created by @Trompettesib on GitHub (Feb 5, 2024).

Description

Force push on a branch with a pull request attached to it does not rename the commit in the conversation page
See this repo: https://try.gitea.io/Trompettesib/push-force-test

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

On my server, Gitea runs with docker

Database

None

Originally created by @Trompettesib on GitHub (Feb 5, 2024). ### Description Force push on a branch with a pull request attached to it does not rename the commit in the conversation page See this repo: https://try.gitea.io/Trompettesib/push-force-test ### Gitea Version 1.21.2 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots ![image](https://github.com/go-gitea/gitea/assets/60519602/7e25df7d-1ad7-408c-86eb-54a6543ddc4c) ![image](https://github.com/go-gitea/gitea/assets/60519602/8c3ee430-9e9d-48cd-823b-43346006eec8) ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? On my server, Gitea runs with docker ### Database None

GiteaMirror added the type/bug label 2025-11-02 10:09:54 -06:00

GiteaMirror commented

2025-11-02 10:09:54 -06:00

@wolfogre commented on GitHub (Feb 28, 2024):

Sorry I don't understand. Do you mean rename this?

If so, I don't think it's a bug, the conversation tells that the user added 1 commit 3 minutes ago, and the commit is 8637384690.

If we change it to 9e8bfdc96d, that will not be the truth, since 9e8bfdc96d was pushed after that.

If I misunderstand your questions, please feel free to point it out.

Others tell me that it's different from what GitHub does; however, I think the Gitea way also makes sense. Whether it should be a bug, it's not issue/critical.

@wolfogre commented on GitHub (Feb 28, 2024): Sorry I don't understand. Do you mean rename this? <img width="1025" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/037d2d93-f78c-4f5f-8f79-c92cce2c95f5"> If so, I don't think it's a bug, the conversation tells that the user added 1 commit 3 minutes ago, and the commit is `8637384690`. <img width="1029" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/018de5fb-cb3d-4f06-aa25-532aeb1d1a5c"> If we change it to `9e8bfdc96d`, that will not be the truth, since `9e8bfdc96d` was pushed after that. <img width="1030" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/e4fe7501-a8cb-4457-9467-4af73035fb5f"> If I misunderstand your questions, please feel free to point it out. --- Others tell me that it's different from what GitHub does; however, I think the Gitea way also makes sense. Whether it should be a bug, it's not `issue/critical`.

GiteaMirror commented

2025-11-02 10:09:54 -06:00

@Sainan commented on GitHub (Feb 6, 2025):

I think the commits log on pull requests really shouldn't show commits that are (no longer) part of the pull request, as this makes this overview page a bit unreliable without cross-referencing with the 'commits' tab.

@Sainan commented on GitHub (Feb 6, 2025): I think the commits log on pull requests really shouldn't show commits that are (no longer) part of the pull request, as this makes this overview page a bit unreliable without cross-referencing with the 'commits' tab.

GiteaMirror commented

2025-11-02 10:09:54 -06:00

@lunny commented on GitHub (Feb 8, 2025):

Duplicate of #25827

@lunny commented on GitHub (Feb 8, 2025): Duplicate of #25827

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#12440