github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Container packages ignore REQUIRE_SIGNIN_VIEW #12361

New Issue
Closed
opened 2025-11-02 10:07:02 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 10:07:02 -06:00
Owner
Copy Link

Originally created by @Shuenhoy on GitHub (Jan 21, 2024).

Description

Our site has enabled REQUIRE_SIGNIN_VIEW, however, we can still docker pull a public image.
This problem had been reported in #20863 and #20873 seemed to have fixed this for other types of package, but not for container.

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

PostgreSQL

Originally created by @Shuenhoy on GitHub (Jan 21, 2024). ### Description Our site has enabled `REQUIRE_SIGNIN_VIEW`, however, we can still `docker pull` a public image. This problem had been reported in #20863 and #20873 seemed to have fixed this for other types of package, but not for container. ### Gitea Version 1.21.2 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? docker ### Database PostgreSQL
GiteaMirror added the topic/packagestype/bug labels 2025-11-02 10:07:03 -06:00
GiteaMirror commented 2025-11-02 10:07:04 -06:00
Author
Owner
Copy Link

@KN4CK3R commented on GitHub (Jan 21, 2024):

It does not ignore that flag:
1df06e3f39/modules/context/package.go (L95-L98)

Did you perform a docker logout?

@KN4CK3R commented on GitHub (Jan 21, 2024): It does not ignore that flag: https://github.com/go-gitea/gitea/blob/1df06e3f399307c14b60a2b88e1b26cedc1ae2f9/modules/context/package.go#L95-L98 Did you perform a docker logout?
GiteaMirror commented 2025-11-02 10:07:04 -06:00
Author
Owner
Copy Link

@Shuenhoy commented on GitHub (Jan 21, 2024):

Hi @KN4CK3R, please check this snapshot:

image

Or am I missing something and the login information can be stored somewhere else?

@Shuenhoy commented on GitHub (Jan 21, 2024): Hi @KN4CK3R, please check this snapshot: ![image](https://github.com/go-gitea/gitea/assets/2196156/03b70212-8d36-418d-ba0a-2d77998ef7a4) Or am I missing something and the login information can be stored somewhere else?
GiteaMirror commented 2025-11-02 10:07:04 -06:00
Author
Owner
Copy Link

@KN4CK3R commented on GitHub (Jan 21, 2024):

No, my bad... The container registry uses the internal ghost user for anonymous requests and the ghost user is not nil. Therefore the test does not return no access rights... I will send a fix soon.

@KN4CK3R commented on GitHub (Jan 21, 2024): No, my bad... The container registry uses the internal ghost user for anonymous requests and the ghost user is not `nil`. Therefore the test does not return no access rights... I will send a fix soon.
GiteaMirror commented 2025-11-02 10:07:04 -06:00
Author
Owner
Copy Link

@KN4CK3R commented on GitHub (Jan 21, 2024):

Fixed in #28877. Thank you for the report.

@KN4CK3R commented on GitHub (Jan 21, 2024): Fixed in #28877. Thank you for the report.
GiteaMirror commented 2025-11-02 10:07:04 -06:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Feb 29, 2024):

Automatically locked because of our CONTRIBUTING guidelines

@github-actions[bot] commented on GitHub (Feb 29, 2024): Automatically locked because of our [CONTRIBUTING guidelines](https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#issue-locking)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/packages type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12361
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?