All checks show as successful although skipped #12325

New Issue

GiteaMirror · 2025-11-02T10:05:43-06:00

GiteaMirror commented

2025-11-02 10:05:43 -06:00

Originally created by @hakito on GitHub (Jan 11, 2024).

Description

In a PR all checks show as successful although some of them had been skipped because of an unsuccessful job.

I think it should only show as successful if all jobs were successful.

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker

Database

None

Originally created by @hakito on GitHub (Jan 11, 2024). ### Description In a PR all checks show as successful although some of them had been skipped because of an unsuccessful job. I think it should only show as successful if all jobs were successful. ### Gitea Version 1.21.2 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots ![image](https://github.com/go-gitea/gitea/assets/320853/4e263ede-bbf8-4949-a4d1-4d844e9ef92b) ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Docker ### Database None

GiteaMirror added the type/bug label 2025-11-02 10:05:43 -06:00

GiteaMirror closed this issue

2025-11-02 10:05:43 -06:00

GiteaMirror commented

2025-11-02 10:05:44 -06:00

@lunny commented on GitHub (Jan 15, 2024):

Skipped is not error, so it's successful. This is because commit status has no state of skipped but Gitea Actions have.

@lunny commented on GitHub (Jan 15, 2024): Skipped is not error, so it's successful. This is because commit status has no state of skipped but Gitea Actions have.

GiteaMirror commented

2025-11-02 10:05:44 -06:00

@hakito commented on GitHub (Jan 15, 2024):

Ok - but if they have been skipped because of an unsuccessful previous job - they should have the error status (like when they a job is aborted).

Guess I have a preparation job and a test job.

The preparation job fails
The test job is marked as skipped
I manually re-run the preparation job and it runs successfully.

Now the PR is green although test was never executed.

@hakito commented on GitHub (Jan 15, 2024): Ok - but if they have been skipped because of an unsuccessful previous job - they should have the error status (like when they a job is aborted). Guess I have a `preparation` job and a `test` job. * The `preparation` job fails * The `test` job is marked as skipped * I manually re-run the `preparation` job and it runs successfully. Now the PR is green although `test` was never executed.

GiteaMirror commented

2025-11-02 10:05:44 -06:00

@Zettat123 commented on GitHub (Mar 20, 2024):

Tested a workflow on GitHub. In GitHub, when we re-run a single job, the job's dependents are also re-run.

@Zettat123 commented on GitHub (Mar 20, 2024): Tested a workflow on GitHub. In GitHub, when we re-run a single job, the job's dependents are also re-run. <img width="600px" src="https://github.com/go-gitea/gitea/assets/15528715/568b4e17-2d26-443e-82fb-9456af4d7afd" />

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#12325