github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

pull review state bug #12239

New Issue
Closed
opened 2025-11-02 10:03:02 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 10:03:02 -06:00
Owner
Copy Link

Originally created by @6543 on GitHub (Dec 19, 2023).

Originally assigned to: @6543 on GitHub.

gitea: v1.21, v1.20, ... and older

reproduce: ( task | actor)

  1. pull to protected branch to USER_A | USER_B
  2. request review of USER_A | USER_B
  3. Review (ack/rej) | USER_A
  4. Push to pull change | USER_B
  5. Dismiss review | USER_A

-> review request can not be deleted
-> if "dismis stale reviews" is set, step 5. is not needed and gitea break it itself

Originally created by @6543 on GitHub (Dec 19, 2023). Originally assigned to: @6543 on GitHub. gitea: **v1.21**, **v1.20**, ... and older **reproduce:** ( task | actor) 1. pull to protected branch to USER_A | USER_B 2. request review of USER_A | USER_B 3. Review (ack/rej) | USER_A 4. Push to pull change | USER_B 5. Dismiss review | USER_A -> review request can not be deleted -> if "dismis stale reviews" is set, step 5. is not needed and gitea break it itself
GiteaMirror added the type/bug label 2025-11-02 10:03:02 -06:00
GiteaMirror commented 2025-11-02 10:03:02 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Dec 19, 2023):

6a725b6f9c/models/issues/review.go (L463)
6a725b6f9c/models/issues/review.go (L482)

can we just use the xorm builder !!!!!!!

@6543 commented on GitHub (Dec 19, 2023): https://github.com/go-gitea/gitea/blob/6a725b6f9cde28862869befb9d2b101d9e342427/models/issues/review.go#L463 https://github.com/go-gitea/gitea/blob/6a725b6f9cde28862869befb9d2b101d9e342427/models/issues/review.go#L482 can we just use the xorm builder !!!!!!!
GiteaMirror commented 2025-11-02 10:03:03 -06:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Mar 1, 2024):

Automatically locked because of our CONTRIBUTING guidelines

@github-actions[bot] commented on GitHub (Mar 1, 2024): Automatically locked because of our [CONTRIBUTING guidelines](https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#issue-locking)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?