github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Webhook Request to Woodpecker CI with wrong mail address in pusher #12233

New Issue
Open
opened 2025-11-02 10:02:48 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2025-11-02 10:02:48 -06:00
Owner
Copy Link

Originally created by @philipkozeny on GitHub (Dec 19, 2023).

Description

I am running Gitea and Woodpecker CI. For some releases now there might be a bug in the mail address of the commit author / pusher, that gets sent to Woodpecker via the web hook.

Here is an example of the Content Request:

{
  "ref": "refs/heads/main",
  "before": "a930081ca449a21d4416bdeb345bc4d3181b916e",
  "after": "3d6d4085e41d1a044a67c15ddb99a7ea4746ded7",
  "compare_url": "xxxx/compare/a930081ca449a21d4416bdeb345bc4d3181b916e...3d6d4085e41d1a044a67c15ddb99a7ea4746ded7",
  "commits": [
    {
      "id": "3d6d4085e41d1a044a67c15ddb99a7ea4746ded7",
      "message": "Update .woodpecker.yml\n",
      "url": "xxxx/commit/3d6d4085e41d1a044a67c15ddb99a7ea4746ded7",
      "author": {
        "name": "Philip Kozeny",
        "email": "philip.kozeny@mydomain.com",
        "username": "philip.kozeny"
      },
      "committer": {
        "name": "Philip Kozeny",
        "email": "philip.kozeny@mydomain.com",
        "username": "philip.kozeny"
      },
      "verification": null,
      "timestamp": "2023-12-19T10:32:26Z",
      "added": [],
      "removed": [],
      "modified": [
        ".woodpecker.yml"
      ]
    }
  ],
  "total_commits": 1,
  "head_commit": {
    "id": "3d6d4085e41d1a044a67c15ddb99a7ea4746ded7",
    "message": "Update .woodpecker.yml\n",
    "url": "xxx/commit/3d6d4085e41d1a044a67c15ddb99a7ea4746ded7",
    "author": {
      "name": "Philip Kozeny",
      "email": "philip.kozeny@mydomain.com",
      "username": "philip.kozeny"
    },
    "committer": {
      "name": "Philip Kozeny",
      "email": "philip.kozeny@mydomain.com",
      "username": "philip.kozeny"
    },
    "verification": null,
    "timestamp": "2023-12-19T10:32:26Z",
    "added": [],
    "removed": [],
    "modified": [
      ".woodpecker.yml"
    ]
  },
...
  "pusher": {
    "id": 1,
    "login": "philip.kozeny",
    "login_name": "",
    "full_name": "Philip Kozeny",
    "email": "philip.kozeny@anotherdomain.com",
    ...
  },
  "sender": {
    "id": 1,
    "login": "philip.kozeny",
    "login_name": "",
    "full_name": "Philip Kozeny",
    "email": "philip.kozeny@anotherdomain.com",
    ...
    "username": "philip.kozeny"
  }
}

As you can see in "pusher" the email is suddenly refilled with another domain. Here is also the issue I have created on Woodpeckers side: https://github.com/woodpecker-ci/woodpecker/issues/2971

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Self hosted binary with systemd on an arch linux machine

Database

SQLite

Originally created by @philipkozeny on GitHub (Dec 19, 2023). ### Description I am running Gitea and Woodpecker CI. For some releases now there might be a bug in the mail address of the commit author / pusher, that gets sent to Woodpecker via the web hook. Here is an example of the Content Request: ``` { "ref": "refs/heads/main", "before": "a930081ca449a21d4416bdeb345bc4d3181b916e", "after": "3d6d4085e41d1a044a67c15ddb99a7ea4746ded7", "compare_url": "xxxx/compare/a930081ca449a21d4416bdeb345bc4d3181b916e...3d6d4085e41d1a044a67c15ddb99a7ea4746ded7", "commits": [ { "id": "3d6d4085e41d1a044a67c15ddb99a7ea4746ded7", "message": "Update .woodpecker.yml\n", "url": "xxxx/commit/3d6d4085e41d1a044a67c15ddb99a7ea4746ded7", "author": { "name": "Philip Kozeny", "email": "philip.kozeny@mydomain.com", "username": "philip.kozeny" }, "committer": { "name": "Philip Kozeny", "email": "philip.kozeny@mydomain.com", "username": "philip.kozeny" }, "verification": null, "timestamp": "2023-12-19T10:32:26Z", "added": [], "removed": [], "modified": [ ".woodpecker.yml" ] } ], "total_commits": 1, "head_commit": { "id": "3d6d4085e41d1a044a67c15ddb99a7ea4746ded7", "message": "Update .woodpecker.yml\n", "url": "xxx/commit/3d6d4085e41d1a044a67c15ddb99a7ea4746ded7", "author": { "name": "Philip Kozeny", "email": "philip.kozeny@mydomain.com", "username": "philip.kozeny" }, "committer": { "name": "Philip Kozeny", "email": "philip.kozeny@mydomain.com", "username": "philip.kozeny" }, "verification": null, "timestamp": "2023-12-19T10:32:26Z", "added": [], "removed": [], "modified": [ ".woodpecker.yml" ] }, ... "pusher": { "id": 1, "login": "philip.kozeny", "login_name": "", "full_name": "Philip Kozeny", "email": "philip.kozeny@anotherdomain.com", ... }, "sender": { "id": 1, "login": "philip.kozeny", "login_name": "", "full_name": "Philip Kozeny", "email": "philip.kozeny@anotherdomain.com", ... "username": "philip.kozeny" } } ``` As you can see in "pusher" the email is suddenly refilled with another domain. Here is also the issue I have created on Woodpeckers side: https://github.com/woodpecker-ci/woodpecker/issues/2971 ### Gitea Version 1.21.2 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Self hosted binary with systemd on an arch linux machine ### Database SQLite
GiteaMirror added the type/bug label 2025-11-02 10:02:48 -06:00
GiteaMirror commented 2025-11-02 10:02:49 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Dec 19, 2023):

IIRC:

  • commiter email: the email in your git commit
  • pusher email: the user email of the Gitea user
@wxiaoguang commented on GitHub (Dec 19, 2023): IIRC: * commiter email: the email in your git commit * pusher email: the user email of the Gitea user
GiteaMirror commented 2025-11-02 10:02:49 -06:00
Author
Owner
Copy Link

@philipkozeny commented on GitHub (Dec 19, 2023):

IIRC:

  • commiter email: the email in your git commit
  • pusher email: the user email of the Gitea user

The @anotherdomain.com emails appears nowhere though, when I go to my profile -> account -> manage email addresses I only see mydomain.com

@philipkozeny commented on GitHub (Dec 19, 2023): > IIRC: > > * commiter email: the email in your git commit > * pusher email: the user email of the Gitea user The @anotherdomain.com emails appears nowhere though, when I go to my profile -> account -> manage email addresses I only see mydomain.com
GiteaMirror commented 2025-11-02 10:02:49 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Dec 19, 2023):

What is "anotherdomain". Maybe you have set to "hide email", or some code hides the email intentionally? then you see a fake email address?

For example, this one? Fix API leaking Usermail if not logged in #25097

@wxiaoguang commented on GitHub (Dec 19, 2023): What is "anotherdomain". Maybe you have set to "hide email", or some code hides the email intentionally? then you see a fake email address? For example, this one? Fix API leaking Usermail if not logged in #25097
GiteaMirror commented 2025-11-02 10:02:49 -06:00
Author
Owner
Copy Link

@philipkozeny commented on GitHub (Dec 19, 2023):

What is "anotherdomain". Maybe you have set to "hide email", or some code hides the email intentionally? then you see a fake email address?

For example, this one? Fix API leaking Usermail if not logged in #25097

let's say mydomain.com -> gmail.com and anotherdomain.com would be "mail.gmail.com"

When I run a request for my user via the API /api/v1/user I get the correct mail address. Also via /api/user/emails I get the one correct mail address. The anotherdomain.com is setup in the app.ini in [service] as NO_REPLY_ADDRESS. Hide Email address is deactivated in the settings though. Do I miss something else?

[service]
...
DEFAULT_KEEP_EMAIL_PRIVATE = false
NO_REPLY_ADDRESS = anotherdomain.com

My user has keep_email_private set to 0 in the users table.

As soon as I remove NO_REPLY_ADDRESS from the settings, my mail gets changed to philip.kozeny@noreply.mygiteadomain.com

@philipkozeny commented on GitHub (Dec 19, 2023): > What is "anotherdomain". Maybe you have set to "hide email", or some code hides the email intentionally? then you see a fake email address? > > For example, this one? Fix API leaking Usermail if not logged in #25097 let's say mydomain.com -> gmail.com and anotherdomain.com would be "mail.gmail.com" When I run a request for my user via the API `/api/v1/user` I get the correct mail address. Also via `/api/user/emails` I get the one correct mail address. The `anotherdomain.com` is setup in the `app.ini` in `[service]` as `NO_REPLY_ADDRESS`. `Hide Email address` is deactivated in the settings though. Do I miss something else? ``` [service] ... DEFAULT_KEEP_EMAIL_PRIVATE = false NO_REPLY_ADDRESS = anotherdomain.com ``` My user has `keep_email_private` set to `0` in the users table. As soon as I remove `NO_REPLY_ADDRESS` from the settings, my mail gets changed to `philip.kozeny@noreply.mygiteadomain.com`
GiteaMirror commented 2025-11-02 10:02:50 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Dec 19, 2023):

So the pusher email you saw is a fake email. According to "Show real mail in Webhooks #27943", that behavior seems to be still related to "Fix API leaking Usermail if not logged in #25097". So it might be a regression.

@wxiaoguang commented on GitHub (Dec 19, 2023): So the pusher email you saw is a fake email. According to "Show real mail in Webhooks #27943", that behavior seems to be still related to "Fix API leaking Usermail if not logged in #25097". So it might be a regression.
GiteaMirror commented 2025-11-02 10:02:50 -06:00
Author
Owner
Copy Link

@philipkozeny commented on GitHub (Dec 19, 2023):

So the pusher email you saw is a fake email. According to "Show real mail in Webhooks #27943", that behavior seems to be still related to "Fix API leaking Usermail if not logged in #25097". So it might be a regression.

Thanks for the info! My workaround for now is to set NO_REPLY_ADDRESS to a valid domain.

@philipkozeny commented on GitHub (Dec 19, 2023): > So the pusher email you saw is a fake email. According to "Show real mail in Webhooks #27943", that behavior seems to be still related to "Fix API leaking Usermail if not logged in #25097". So it might be a regression. Thanks for the info! My workaround for now is to set `NO_REPLY_ADDRESS` to a valid domain.
GiteaMirror commented 2025-11-02 10:02:50 -06:00
Author
Owner
Copy Link

@dnno commented on GitHub (Nov 21, 2024):

I have the same problem, I think. In the past my gitea user had "hide email address" activated. I disabled that, though. The pusher email still contains the special email address. Since my gitea user is different from the username in my mail address, the workaround you are using doesn't cut it for me, I end up with a invalid email address.

@dnno commented on GitHub (Nov 21, 2024): I have the same problem, I think. In the past my gitea user had "hide email address" activated. I disabled that, though. The `pusher email` still contains the special email address. Since my gitea user is different from the username in my mail address, the workaround you are using doesn't cut it for me, I end up with a invalid email address.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12233
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?