Email notification for new pull request is undistinguishable from that for a new issue #122

Closed
opened 2025-11-02 03:09:55 -06:00 by GiteaMirror · 7 comments
Owner

Originally created by @strk on GitHub (Dec 13, 2016).

See https://github.com/gogits/gogs/issues/3305

Originally created by @strk on GitHub (Dec 13, 2016). See https://github.com/gogits/gogs/issues/3305
GiteaMirror added the type/enhancement label 2025-11-02 03:09:55 -06:00
Author
Owner

@lunny commented on GitHub (Feb 9, 2017):

I think this have been resolved via 6f9a95f83. Please feel free to reopen it.

@lunny commented on GitHub (Feb 9, 2017): I think this have been resolved via 6f9a95f83. Please feel free to reopen it.
Author
Owner

@strk commented on GitHub (Feb 9, 2017):

I don't see anything related to mail notification body in that commit. Can we test this on try.gitea.io ? (ie: enable mail notification there, with email confirmation)

@strk commented on GitHub (Feb 9, 2017): I don't see anything related to mail notification body in that commit. Can we test this on try.gitea.io ? (ie: enable mail notification there, with email confirmation)
Author
Owner

@lunny commented on GitHub (Feb 9, 2017):

I have tested locally.
see 6f9a95f830 (diff-d5eea3b2c0d4c92d62e12b34eb8da2c0R158)
and
6f9a95f830 (diff-91afb18937651f768645eff6cf5779a8R157)

@lunny commented on GitHub (Feb 9, 2017): I have tested locally. see https://github.com/go-gitea/gitea/commit/6f9a95f83020e215ebe3942bd541da34791dd043#diff-d5eea3b2c0d4c92d62e12b34eb8da2c0R158 and https://github.com/go-gitea/gitea/commit/6f9a95f83020e215ebe3942bd541da34791dd043#diff-91afb18937651f768645eff6cf5779a8R157
Author
Owner

@strk commented on GitHub (Feb 9, 2017):

But mail subject remains the same ?

@strk commented on GitHub (Feb 9, 2017): But mail subject remains the same ?
Author
Owner

@lunny commented on GitHub (Feb 9, 2017):

Yes. Your issue only said the link is not correct.

@lunny commented on GitHub (Feb 9, 2017): Yes. Your issue only said the link is not correct.
Author
Owner

@strk commented on GitHub (Feb 9, 2017):

The original report saied: "It *even has the wrong link", so was just an extreme :)
You can see an example github PR notification here: https://github.com/gogits/gogs/issues/3305#issuecomment-234873593

Anyway, no problem closing this now, will reopen next time I face the issue (after I upgrade to Gitea, which I didn't do yet)

@strk commented on GitHub (Feb 9, 2017): The original report saied: "It *even has the wrong link", so was just an extreme :) You can see an example github PR notification here: https://github.com/gogits/gogs/issues/3305#issuecomment-234873593 Anyway, no problem closing this now, will reopen next time I face the issue (after I upgrade to Gitea, which I didn't do yet)
Author
Owner

@tboerger commented on GitHub (Feb 9, 2017):

I don't see anything related to mail notification body in that commit. Can we test this on try.gitea.io ? (ie: enable mail notification there, with email confirmation)

Enabled now.

@tboerger commented on GitHub (Feb 9, 2017): > I don't see anything related to mail notification body in that commit. Can we test this on try.gitea.io ? (ie: enable mail notification there, with email confirmation) Enabled now.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#122