Forked repository is compared wrong #1217

Closed
opened 2025-11-02 03:52:44 -06:00 by GiteaMirror · 8 comments
Owner

Originally created by @webjoel on GitHub (Nov 6, 2017).

  • Gitea version (or commit ref): cdc4600
  • Git version: 2.7.4
  • Operating system: Linux 64 Ubuntu
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Comparison of changes / New Pull request is not comparing the forked repository, but rather the origin repository. (Image 1 and image 2).

When I change the URL manually the "compare" works as expected. (Image 3).

Screenshots

Image 1:
captura de tela de 2017-11-06 15-23-03

Image 2:
captura de tela de 2017-11-06 14-49-42

Image 3:
captura de tela de 2017-11-06 14-49-34

Originally created by @webjoel on GitHub (Nov 6, 2017). - Gitea version (or commit ref): cdc4600 - Git version: 2.7.4 - Operating system: Linux 64 Ubuntu - Database (use `[x]`): - [x] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: ## Description Comparison of changes / New Pull request is not comparing the forked repository, but rather the origin repository. (Image 1 and image 2). When I change the URL manually the "compare" works as expected. (Image 3). ## Screenshots Image 1: ![captura de tela de 2017-11-06 15-23-03](https://user-images.githubusercontent.com/1946348/32454910-c3e30590-c307-11e7-8c43-5794498c7989.png) Image 2: ![captura de tela de 2017-11-06 14-49-42](https://user-images.githubusercontent.com/1946348/32454926-cc3f93a2-c307-11e7-8b90-5ed29a984f6b.png) Image 3: ![captura de tela de 2017-11-06 14-49-34](https://user-images.githubusercontent.com/1946348/32454937-d39465ec-c307-11e7-9411-d31a1f8df090.png)
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 03:52:44 -06:00
Author
Owner

@lafriks commented on GitHub (Nov 6, 2017):

@lunny could this be related to your latest changes?

@lafriks commented on GitHub (Nov 6, 2017): @lunny could this be related to your latest changes?
Author
Owner

@lunny commented on GitHub (Nov 7, 2017):

@lafriks I will check it.

@lunny commented on GitHub (Nov 7, 2017): @lafriks I will check it.
Author
Owner

@zxjon22 commented on GitHub (Dec 7, 2017):

I've just come across this myself. I was in a fork and clicked the New Pull Request button and the pull request was created against the original repository, not the fork.

HTML for the New Pull Request button when in the fork looks like this

<a class="ui green button " href="/[original]/Repo/compare/master...jon:master">New Pull Request</a>

... when it should be

<a class="ui green button " href="/[fork]/Repo/compare/master...jon:master">New Pull Request</a>
@zxjon22 commented on GitHub (Dec 7, 2017): I've just come across this myself. I was in a fork and clicked the `New Pull Request` button and the pull request was created against the original repository, not the fork. HTML for the `New Pull Request` button when in the fork looks like this ```html <a class="ui green button " href="/[original]/Repo/compare/master...jon:master">New Pull Request</a> ``` ... when it should be ```html <a class="ui green button " href="/[fork]/Repo/compare/master...jon:master">New Pull Request</a> ```
Author
Owner

@lunny commented on GitHub (Dec 9, 2018):

Could not reproduce it on master, I will close this and feel free to reopen it.

@lunny commented on GitHub (Dec 9, 2018): Could not reproduce it on master, I will close this and feel free to reopen it.
Author
Owner

@webjoel commented on GitHub (Jan 4, 2019):

This can be tested in:

https://try.gitea.io/webjoel/teste2_1

Pressing in button "compare changes" (image 1). Result is comparassion of other repository (origin fork).

Please repon this issue.

@webjoel commented on GitHub (Jan 4, 2019): This can be tested in: https://try.gitea.io/webjoel/teste2_1 Pressing in button "compare changes" (image 1). Result is comparassion of other repository (origin fork). Please repon this issue.
Author
Owner

@stale[bot] commented on GitHub (Mar 5, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Mar 5, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
Author
Owner

@lunny commented on GitHub (Jan 25, 2020):

Is this still a problem?

@lunny commented on GitHub (Jan 25, 2020): Is this still a problem?
Author
Owner

@zeripath commented on GitHub (Mar 12, 2021):

I think this bug has been solved by me quite a while ago. Therefore I'm closing it.

@zeripath commented on GitHub (Mar 12, 2021): I think this bug has been solved by me quite a while ago. Therefore I'm closing it.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1217