nil dereference in webhooks #12030

New Issue

GiteaMirror · 2025-11-02T09:55:13-06:00

GiteaMirror commented

2025-11-02 09:55:13 -06:00

Originally created by @KN4CK3R on GitHub (Nov 16, 2023).

          Unfortunately this PR broke Gitea for us as the call to `p.Repository` inside `func (m *MatrixPayload) Package(p *api.PackagePayload) (api.Payloader, error)` (`services/webhook/matrix.go:239`) results in a nil pointer dereference. Looks like `p.Repository` is not set when triggered from `UploadManifest`. Stack trace (Gitea 1.21):

/source/services/webhook/matrix.go:215 (0x23cf774)
/source/services/webhook/payloader.go:58 (0x23dae5d)
/source/services/webhook/matrix.go:239 (0x23cfac4)
/source/services/webhook/webhook.go:198 (0x23dfc6b)
/source/services/webhook/webhook.go:261 (0x23e0435)
/source/services/webhook/notifier.go:882 (0x23da6d0)
/source/services/webhook/notifier.go:863 (0x23da495)
/source/services/notify/notify.go:353 (0x2306326)
/source/routers/api/packages/container/manifest.go:309 (0x23062da)
/source/routers/api/packages/container/manifest.go:184 (0x2305364)
/source/routers/api/packages/container/manifest.go:191 (0x230483c)
/source/routers/api/packages/container/manifest.go:75 (0x2304724)
/source/routers/api/packages/container/container.go:546 (0x2301bec)

Originally posted by @niklaskorz in https://github.com/go-gitea/gitea/issues/27839#issuecomment-1814149873

Originally created by @KN4CK3R on GitHub (Nov 16, 2023). Unfortunately this PR broke Gitea for us as the call to `p.Repository` inside `func (m *MatrixPayload) Package(p *api.PackagePayload) (api.Payloader, error)` (`services/webhook/matrix.go:239`) results in a nil pointer dereference. Looks like `p.Repository` is not set when triggered from `UploadManifest`. Stack trace (Gitea 1.21): ``` /source/services/webhook/matrix.go:215 (0x23cf774) /source/services/webhook/payloader.go:58 (0x23dae5d) /source/services/webhook/matrix.go:239 (0x23cfac4) /source/services/webhook/webhook.go:198 (0x23dfc6b) /source/services/webhook/webhook.go:261 (0x23e0435) /source/services/webhook/notifier.go:882 (0x23da6d0) /source/services/webhook/notifier.go:863 (0x23da495) /source/services/notify/notify.go:353 (0x2306326) /source/routers/api/packages/container/manifest.go:309 (0x23062da) /source/routers/api/packages/container/manifest.go:184 (0x2305364) /source/routers/api/packages/container/manifest.go:191 (0x230483c) /source/routers/api/packages/container/manifest.go:75 (0x2304724) /source/routers/api/packages/container/container.go:546 (0x2301bec) ``` _Originally posted by @niklaskorz in https://github.com/go-gitea/gitea/issues/27839#issuecomment-1814149873_

GiteaMirror added the type/bug label 2025-11-02 09:55:13 -06:00

GiteaMirror closed this issue

2025-11-02 09:55:13 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#12030

nil dereference in webhooks #12030

`nil` dereference in webhooks #12030