github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-22 13:55:07 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Caching issue is back #12011

New Issue
Closed
opened 2025-11-02 09:54:31 -06:00 by GiteaMirror · 11 comments
GiteaMirror commented 2025-11-02 09:54:31 -06:00
Owner
Copy Link

Originally created by @somera on GitHub (Nov 14, 2023).

Description

I see this
2023/11/14 18:23:54 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 639.796µs
when I go to my profile and start page.

I'm using memcached.

Looks like #22281

Gitea Version

1.21.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.42.0

Operating System

Ubuntu 20.04.x

How are you running Gitea?

gitea-1.21.0-linux-amd64

Database

PostgreSQL

Originally created by @somera on GitHub (Nov 14, 2023). ### Description I see this `2023/11/14 18:23:54 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 639.796µs` when I go to my profile and start page. I'm using memcached. Looks like #22281 ### Gitea Version 1.21.1 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version 2.42.0 ### Operating System Ubuntu 20.04.x ### How are you running Gitea? gitea-1.21.0-linux-amd64 ### Database PostgreSQL
GiteaMirror added the type/bug label 2025-11-02 09:54:31 -06:00
GiteaMirror commented 2025-11-02 09:54:32 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Nov 15, 2023):

How many times the query occupied?

@lunny commented on GitHub (Nov 15, 2023): How many times the query occupied?
GiteaMirror commented 2025-11-02 09:54:32 -06:00
Author
Owner
Copy Link

@somera commented on GitHub (Nov 15, 2023):

3289 times on the start page.

My start page needs

image

After the upgrade to 1.21.0. Like in #22299

@somera commented on GitHub (Nov 15, 2023): 3289 times on the start page. My start page needs ![image](https://github.com/go-gitea/gitea/assets/8334250/0062c2e4-566b-4e18-93fd-ddfab1f32118) After the upgrade to 1.21.0. Like in #22299
GiteaMirror commented 2025-11-02 09:54:33 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 15, 2023):

Do you have the full log?

I think I know the problem now. Will propose a fix.

@wxiaoguang commented on GitHub (Nov 15, 2023): Do you have the full log? ---- I think I know the problem now. Will propose a fix.
GiteaMirror commented 2025-11-02 09:54:33 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 15, 2023):

-> Fix system config cache expiration timing #28072

@wxiaoguang commented on GitHub (Nov 15, 2023): -> Fix system config cache expiration timing #28072
GiteaMirror commented 2025-11-02 09:54:33 -06:00
Author
Owner
Copy Link

@somera commented on GitHub (Nov 15, 2023):

Do you have the full log?

Do you still need that?

@somera commented on GitHub (Nov 15, 2023): > Do you have the full log? Do you still need that?
GiteaMirror commented 2025-11-02 09:54:33 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 15, 2023):

Do you have the full log?

Do you still need that?

Not needed now, thank you very much!

@wxiaoguang commented on GitHub (Nov 15, 2023): > > Do you have the full log? > > Do you still need that? Not needed now, thank you very much!
GiteaMirror commented 2025-11-02 09:54:34 -06:00
Author
Owner
Copy Link

@somera commented on GitHub (Nov 15, 2023):

@wxiaoguang why is the query (in my case 3228 times)

2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 984.36µs
2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 561.283µs
2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 635.435µs
2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 634.959µs

needed on the http://domain/git/org/orgname/dashboard page for every orga? For the orga list?

@somera commented on GitHub (Nov 15, 2023): @wxiaoguang why is the query (in my case 3228 times) ``` 2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 984.36µs 2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 561.283µs 2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 635.435µs 2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 634.959µs ``` needed on the http://domain/git/org/orgname/dashboard page for every orga? For the orga list?
GiteaMirror commented 2025-11-02 09:54:34 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 16, 2023):

Because the "cache time" is not updated correctly, it is a bug. That's why https://github.com/go-gitea/gitea/pull/28072 fixes it.

@wxiaoguang commented on GitHub (Nov 16, 2023): Because the "cache time" is not updated correctly, it is a bug. That's why https://github.com/go-gitea/gitea/pull/28072 fixes it.
GiteaMirror commented 2025-11-02 09:54:35 -06:00
Author
Owner
Copy Link

@somera commented on GitHub (Nov 16, 2023):

@wxiaoguang I know that this is fixed. But I try to understand why so much queries are needed on the Dashboard page for an orga. But it make no sense to show the orga list on the dashboard page.

@somera commented on GitHub (Nov 16, 2023): @wxiaoguang I know that this is fixed. But I try to understand why so much queries are needed on the Dashboard page for an orga. But it make no sense to show the orga list on the dashboard page.
GiteaMirror commented 2025-11-02 09:54:35 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Nov 16, 2023):

But I try to understand why so much queries are needed on the Dashboard page for an orga

The avatar module needs to read system settings to decide how to render an avatar. 1.21 contains an enhancement for the setting system, it brings the bug: the system setting revision was read again and again.

@wxiaoguang commented on GitHub (Nov 16, 2023): > But I try to understand why so much queries are needed on the Dashboard page for an orga The avatar module needs to read system settings to decide how to render an avatar. 1.21 contains an enhancement for the setting system, it brings the bug: the system setting revision was read again and again.
GiteaMirror commented 2025-11-02 09:54:35 -06:00
Author
Owner
Copy Link

@somera commented on GitHub (Nov 27, 2023):

Now the start page need

image

Looks good.

@somera commented on GitHub (Nov 27, 2023): Now the start page need ![image](https://github.com/go-gitea/gitea/assets/8334250/577ffec2-ed41-4ea0-8f49-c54aec5e557f) Looks good.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#12011
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?