Permissions to accept/merge Pull request #1189

@webjoel commented on GitHub (Oct 27, 2017):

@lafriks is working on something similar and can be merged into this issue:

"I'm working to add approval system (something like GitHub - request changes/approve) only it will be possible to define how many approvals are needed to be able to merge PR
And it will also be possible to define teams/users who can approve."

@webjoel commented on GitHub (Oct 27, 2017): @lafriks is working on something similar and can be merged into this issue: "I'm working to add approval system (something like GitHub - request changes/approve) only it will be possible to define how many approvals are needed to be able to merge PR And it will also be possible to define teams/users who can approve."

GiteaMirror commented

@renothing commented on GitHub (Nov 1, 2017):

that's mean there should be a RBAC system first. it's not small feature

@renothing commented on GitHub (Nov 1, 2017): that's mean there should be a RBAC system first. it's not small feature

GiteaMirror commented

@bkcsoft commented on GitHub (Nov 3, 2017):

@webjoel @lafriks Will said approval system just be "approve"/"disapprove"?

@bkcsoft commented on GitHub (Nov 3, 2017): @webjoel @lafriks Will said approval system just be "approve"/"disapprove"?

GiteaMirror commented

@lafriks commented on GitHub (Nov 3, 2017):

@bkcsoft I'm working on approve/request changes system (something like we use LG-TM for now). Want to also integrate it with @lunny comments on code

@lafriks commented on GitHub (Nov 3, 2017): @bkcsoft I'm working on approve/request changes system (something like we use LG-TM for now). Want to also integrate it with @lunny comments on code

GiteaMirror commented

@jogibear9988 commented on GitHub (Mar 29, 2018):

@lafriks do you still work on this? is there any test branch available?

@jogibear9988 commented on GitHub (Mar 29, 2018): @lafriks do you still work on this? is there any test branch available?

GiteaMirror commented

@lunny commented on GitHub (Mar 29, 2018):

@jogibear9988 approve system is not ready but via https://github.com/go-gitea/gitea/pull/3689 you can indicate who can merge the pull request.

@lunny commented on GitHub (Mar 29, 2018): @jogibear9988 approve system is not ready but via https://github.com/go-gitea/gitea/pull/3689 you can indicate who can merge the pull request.

GiteaMirror commented

@lafriks commented on GitHub (Mar 30, 2018):

@jogibear9988 I'm but I'm waiting on @lunny to finish comments on PR code to be finished

@lafriks commented on GitHub (Mar 30, 2018): @jogibear9988 I'm but I'm waiting on @lunny to finish comments on PR code to be finished

GiteaMirror commented

@PietYorke commented on GitHub (Jun 20, 2018):

Is there any chance to get this released in the near future? Protecting a branch from "unauthorized" PRs is a must have for us.

@PietYorke commented on GitHub (Jun 20, 2018): Is there any chance to get this released in the near future? Protecting a branch from "unauthorized" PRs is a must have for us.

GiteaMirror commented

@lunny commented on GitHub (Jun 20, 2018):

@PietYorke I think maybe #3689 could help you?

@lunny commented on GitHub (Jun 20, 2018): @PietYorke I think maybe #3689 could help you?

GiteaMirror commented

@lafriks commented on GitHub (Jun 20, 2018):

I think this is actually resolved by #3689 isn't it?

@lafriks commented on GitHub (Jun 20, 2018): I think this is actually resolved by #3689 isn't it?

GiteaMirror commented

@PietYorke commented on GitHub (Jun 21, 2018):

Yes, right. Thank you. We are using the gitea docker image, so it's on :latest. Would be nice to have it on a release version though.

@PietYorke commented on GitHub (Jun 21, 2018): Yes, right. Thank you. We are using the gitea docker image, so it's on :latest. Would be nice to have it on a release version though.

GiteaMirror commented

@lafriks commented on GitHub (Jun 21, 2018):

@webjoel can this be closed as fixed?

@lafriks commented on GitHub (Jun 21, 2018): @webjoel can this be closed as fixed?

GiteaMirror commented