github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

2FA Can Be Removed Without a Security Check #11882

New Issue
Open
opened 2025-11-02 09:50:47 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 09:50:47 -06:00
Owner
Copy Link

Originally created by @ZaxLofful on GitHub (Oct 19, 2023).

Description

A User is able to remove 2FA without an additional security check.

Standard practice here dictates that, if the user has 2FA already enabled; they should not be able to disable it without a 2FA check.

This would mean someone could have 2FA disabled, just by leaving their browser open for a few seconds.

This is for an admin account, in the event of a loss; recovery keys will need to be used.

Gitea Version

1.20

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Podman

Database

PostgreSQL

Originally created by @ZaxLofful on GitHub (Oct 19, 2023). ### Description A User is able to remove 2FA without an additional security check. Standard practice here dictates that, if the user has 2FA already enabled; they should not be able to disable it without a 2FA check. This would mean someone could have 2FA disabled, just by leaving their browser open for a few seconds. This is for an admin account, in the event of a loss; recovery keys will need to be used. ### Gitea Version 1.20 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? Podman ### Database PostgreSQL
GiteaMirror added the topic/securitytype/bug labels 2025-11-02 09:50:47 -06:00
GiteaMirror commented 2025-11-02 09:50:47 -06:00
Author
Owner
Copy Link

@codenoid commented on GitHub (Oct 23, 2023):

should it cofirm by entering the account password?

@codenoid commented on GitHub (Oct 23, 2023): should it cofirm by entering the account password?
GiteaMirror commented 2025-11-02 09:50:48 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 24, 2023):

I think when you login, you have been prompt 2FA? So the problem should be if 2FA enabled/disabled, all login sessions should be invalidated except current one.

@lunny commented on GitHub (Oct 24, 2023): I think when you login, you have been prompt 2FA? So the problem should be if 2FA enabled/disabled, all login sessions should be invalidated except current one.
GiteaMirror commented 2025-11-02 09:50:48 -06:00
Author
Owner
Copy Link

@ZaxLofful commented on GitHub (Nov 4, 2023):

Account password or a recovery code...

@ZaxLofful commented on GitHub (Nov 4, 2023): Account password or a recovery code...
GiteaMirror commented 2025-11-02 09:50:48 -06:00
Author
Owner
Copy Link

@shoce commented on GitHub (Sep 15, 2025):

i totally agree, disabling 2fa MUST require 2fa code or recovery code, not account password.

@shoce commented on GitHub (Sep 15, 2025): i totally agree, disabling 2fa MUST require 2fa code or recovery code, not account password.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/security type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11882
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?