github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-22 14:34:54 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Agit workflow instructions do not work #11833

New Issue
Closed
opened 2025-11-02 09:49:11 -06:00 by GiteaMirror · 12 comments
GiteaMirror commented 2025-11-02 09:49:11 -06:00
Owner
Copy Link

Originally created by @strk on GitHub (Oct 11, 2023).

Description

I've followed instructions in https://docs.gitea.com/usage/agit-setup but could not make a pull request automatically created.
Logs of Gitea also don't mention anything.

$ git push origin HEAD:refs/for/master -o title="Test title" -o topic="Test topic" -o description="Test description"
To git.osgeo.org:postgis/postgis.git
 * [new reference]       HEAD -> refs/for/master

Gitea Version

1.20.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

The test I've run on try.gitea.io failed but in a different way:

[strk@c19:/tmp/test2(agit)] git push origin HEAD:refs/for/master
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Writing objects: 100% (3/3), 257 bytes | 257.00 KiB/s, done.
Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
remote: 
remote: Gitea: Unexpected ref: refs/for/master
To try.gitea.io:strk/test2.git
 ! [remote rejected] HEAD -> refs/for/master (pre-receive hook declined)
error: failed to push some refs to 'try.gitea.io:strk/test2.git'

Database

None

Originally created by @strk on GitHub (Oct 11, 2023). ### Description I've followed instructions in https://docs.gitea.com/usage/agit-setup but could not make a pull request automatically created. Logs of Gitea also don't mention anything. ``` $ git push origin HEAD:refs/for/master -o title="Test title" -o topic="Test topic" -o description="Test description" To git.osgeo.org:postgis/postgis.git * [new reference] HEAD -> refs/for/master ``` ### Gitea Version 1.20.5 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? The test I've run on try.gitea.io failed but in a different way: ``` [strk@c19:/tmp/test2(agit)] git push origin HEAD:refs/for/master Enumerating objects: 5, done. Counting objects: 100% (5/5), done. Writing objects: 100% (3/3), 257 bytes | 257.00 KiB/s, done. Total 3 (delta 0), reused 0 (delta 0), pack-reused 0 remote: remote: Gitea: Unexpected ref: refs/for/master To try.gitea.io:strk/test2.git ! [remote rejected] HEAD -> refs/for/master (pre-receive hook declined) error: failed to push some refs to 'try.gitea.io:strk/test2.git' ``` ### Database None
GiteaMirror added the type/docsissue/needs-feedback labels 2025-11-02 09:49:11 -06:00
GiteaMirror commented 2025-11-02 09:49:12 -06:00
Author
Owner
Copy Link

@lng2020 commented on GitHub (Oct 14, 2023):

Currently, the default branch name is main. The docs should be updated.

@lng2020 commented on GitHub (Oct 14, 2023): Currently, the default branch name is main. The docs should be updated.
GiteaMirror commented 2025-11-02 09:49:13 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 15, 2023):

@strk Could you confirm git push origin HEAD:refs/for/main will fix your problem? The last word should be the base repository target branch name.

@lunny commented on GitHub (Oct 15, 2023): @strk Could you confirm git push origin HEAD:refs/for/main will fix your problem? The last word should be the base repository target branch name.
GiteaMirror commented 2025-11-02 09:49:13 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Oct 16, 2023):

In our case the base repository target branch is still "master", but I confirm try.osgeo.org does work if I push to the target repository. I've yet to test doing this on try.osgeo.org and ideed it works (as long as -o topic is given).

Is it supposed to also work when pushing to fork instead of target repository ?

@strk commented on GitHub (Oct 16, 2023): In our case the base repository target branch is still "master", but I confirm try.osgeo.org does work if I push to the target repository. I've yet to test doing this on try.osgeo.org and ideed it works (as long as `-o topic` is given). Is it supposed to also work when pushing to fork instead of target repository ?
GiteaMirror commented 2025-11-02 09:49:13 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 16, 2023):

In our case the base repository target branch is still "master", but I confirm try.osgeo.org does work if I push to the target repository. I've yet to test doing this on try.osgeo.org and ideed it works (as long as -o topic is given).

Is it supposed to also work when pushing to fork instead of target repository ?

Pushing to fork will create a PR of the fork repository. In Agit workflow, there is no fork concept.

@lunny commented on GitHub (Oct 16, 2023): > In our case the base repository target branch is still "master", but I confirm try.osgeo.org does work if I push to the target repository. I've yet to test doing this on try.osgeo.org and ideed it works (as long as `-o topic` is given). > > Is it supposed to also work when pushing to fork instead of target repository ? Pushing to fork will create a PR of the fork repository. In Agit workflow, there is no fork concept.
GiteaMirror commented 2025-11-02 09:49:13 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Oct 16, 2023):

So, I've tried back to git.osgeo.org/gitea and neither pushing refs/for/master (the real name of target) nor refs/for/main triggered the creation of a pull request. Rather those refs were created in the origin repository:

[strk@c19:/usr/local/src/postgis/postgis(drop-obsoleted-strings)] git push origin HEAD:refs/for/main -o topic="test topic"
Enumerating objects: 11, done.
Counting objects: 100% (11/11), done.
Delta compression using up to 8 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 575 bytes | 575.00 KiB/s, done.
Total 6 (delta 4), reused 0 (delta 0), pack-reused 0
remote: . Processing 1 references
remote: Processed 1 references in total
To git.osgeo.org:postgis/postgis.git
 * [new reference]       HEAD -> refs/for/main
[strk@c19:/usr/local/src/postgis/postgis(drop-obsoleted-strings)] git push origin HEAD:refs/for/master -o topic="test topic"
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: . Processing 1 references
remote: Processed 1 references in total
To git.osgeo.org:postgis/postgis.git
 * [new reference]       HEAD -> refs/for/master
@strk commented on GitHub (Oct 16, 2023): So, I've tried back to git.osgeo.org/gitea and neither pushing refs/for/master (the real name of target) nor refs/for/main triggered the creation of a pull request. Rather those refs were created in the origin repository: ``` [strk@c19:/usr/local/src/postgis/postgis(drop-obsoleted-strings)] git push origin HEAD:refs/for/main -o topic="test topic" Enumerating objects: 11, done. Counting objects: 100% (11/11), done. Delta compression using up to 8 threads Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 575 bytes | 575.00 KiB/s, done. Total 6 (delta 4), reused 0 (delta 0), pack-reused 0 remote: . Processing 1 references remote: Processed 1 references in total To git.osgeo.org:postgis/postgis.git * [new reference] HEAD -> refs/for/main [strk@c19:/usr/local/src/postgis/postgis(drop-obsoleted-strings)] git push origin HEAD:refs/for/master -o topic="test topic" Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 remote: . Processing 1 references remote: Processed 1 references in total To git.osgeo.org:postgis/postgis.git * [new reference] HEAD -> refs/for/master ```
GiteaMirror commented 2025-11-02 09:49:13 -06:00
Author
Owner
Copy Link

@lng2020 commented on GitHub (Oct 16, 2023):

but I confirm try.osgeo.org does work if I push to the target repository.

Do you mean try.gitea.io?

So it works in try.gitea.io but doesn't work in your host, which is git.osgeo.org?

@lng2020 commented on GitHub (Oct 16, 2023): > but I confirm try.osgeo.org does work if I push to the target repository. Do you mean try.gitea.io? So it works in try.gitea.io but doesn't work in your host, which is git.osgeo.org?
GiteaMirror commented 2025-11-02 09:49:14 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Oct 16, 2023):

@lng2020 exactly, at least not for this repository: https://git.osgeo.org/gitea/postgis/postgis -- feel free to try !

@strk commented on GitHub (Oct 16, 2023): @lng2020 exactly, at least not for this repository: https://git.osgeo.org/gitea/postgis/postgis -- feel free to try !
GiteaMirror commented 2025-11-02 09:49:14 -06:00
Author
Owner
Copy Link

@lng2020 commented on GitHub (Oct 16, 2023):

@lng2020 exactly, at least not for this repository: https://git.osgeo.org/gitea/postgis/postgis -- feel free to try !

will look into it later

@lng2020 commented on GitHub (Oct 16, 2023): > @lng2020 exactly, at least not for this repository: https://git.osgeo.org/gitea/postgis/postgis -- feel free to try ! will look into it later
GiteaMirror commented 2025-11-02 09:49:14 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Oct 16, 2023):

One concern I have is that this support seems to imply anyone can create branches to the target repository effectively making the size associated to that repository bigger, how to limit that ? https://try.gitea.io/strk/test2/pulls/7#issuecomment-169018

@strk commented on GitHub (Oct 16, 2023): One concern I have is that this support seems to imply anyone can create branches to the target repository effectively making the size associated to that repository bigger, how to limit that ? https://try.gitea.io/strk/test2/pulls/7#issuecomment-169018
GiteaMirror commented 2025-11-02 09:49:14 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Oct 16, 2023):

Currently, the default branch name is main. The docs should be updated.

I've filed https://github.com/go-gitea/gitea/pull/27652 doing ALSO this

@strk commented on GitHub (Oct 16, 2023): > Currently, the default branch name is main. The docs should be updated. I've filed https://github.com/go-gitea/gitea/pull/27652 doing ALSO this
GiteaMirror commented 2025-11-02 09:49:15 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Oct 16, 2023):

Consulting the source code I saw that "proc-receive" git hook is used for Agit, and that hook is only supported by git starting at version 2.29 -- on git.osgeo.org we're currently runnign an older version of git, which might explain the problem.

@strk commented on GitHub (Oct 16, 2023): Consulting the source code I saw that "proc-receive" git hook is used for Agit, and that hook is only supported by git starting at version 2.29 -- on git.osgeo.org we're currently runnign an older version of git, which might explain the problem.
GiteaMirror commented 2025-11-02 09:49:15 -06:00
Author
Owner
Copy Link

@strk commented on GitHub (Oct 16, 2023):

I've added a note about 2.29 requirement in the docs too, in https://github.com/go-gitea/gitea/pull/27652

@strk commented on GitHub (Oct 16, 2023): I've added a note about 2.29 requirement in the docs too, in https://github.com/go-gitea/gitea/pull/27652
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/needs-feedback type/docs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?