github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-22 14:34:54 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

"PR closed" event uses "check-circle" icon rather than "git-pull-request-closed" icon for closed and unmerged PRs #11804

New Issue
Closed
opened 2025-11-02 09:48:17 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 09:48:17 -06:00
Owner
Copy Link

Originally created by @Andre601 on GitHub (Oct 7, 2023).

Description

When you close a PR without merging it, does the overview of the web-ui (The one displaying most recent activities related to you and your repositories) use the check-circle icon.

This is a rather bad choice as the icon in question implies this to be good (As in merged). Instead should the git-pull-request-closed icon be used, as it is by far the best fit.

Also, merging a PR does use the right icon (git-merge).

Screenshots

Dashboard from try.gitea.io. From bottom to top there is:

  • PR 1 being opened
  • PR 1 being closed without merge
  • PR 2 being opened
  • PR 2 being closed with merge
  • Resulting commit of the merge

grafik

Gitea Version

1.22.0+dev-125-ge3229c8e9

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows

Browser Version

Firefox 118.0.1 (64-Bit)

Originally created by @Andre601 on GitHub (Oct 7, 2023). ### Description When you close a PR without merging it, does the overview of the web-ui (The one displaying most recent activities related to you and your repositories) use the [`check-circle` icon](https://primer.style/design/foundations/icons/check-circle-24). This is a rather bad choice as the icon in question implies this to be good (As in merged). Instead should the [`git-pull-request-closed` icon](https://primer.style/design/foundations/icons/git-pull-request-closed-24) be used, as it is by far the best fit. Also, merging a PR does use the right icon ([`git-merge`](https://primer.style/design/foundations/icons/git-merge-24)). ### Screenshots Dashboard from try.gitea.io. From bottom to top there is: - PR 1 being opened - PR 1 being closed without merge - PR 2 being opened - PR 2 being closed with merge - Resulting commit of the merge ![grafik](https://github.com/go-gitea/gitea/assets/11576465/f2a19ded-6d80-4915-8ce9-f4edf2fba236) ### Gitea Version 1.22.0+dev-125-ge3229c8e9 ### Can you reproduce the bug on the Gitea demo site? Yes ### Operating System Windows ### Browser Version Firefox 118.0.1 (64-Bit)
GiteaMirror added the type/bugtopic/ui labels 2025-11-02 09:48:17 -06:00
GiteaMirror commented 2025-11-02 09:48:19 -06:00
Author
Owner
Copy Link

@Andre601 commented on GitHub (Oct 7, 2023):

I also just now noticed this, but it seems like that the PR title on a merge message uses a slightly darker colour than the other notifs in the dashboard (See how "Add lorem.md (merge)" is darker for the "merged pull request" message than for "created pull request")

@Andre601 commented on GitHub (Oct 7, 2023): I also just now noticed this, but it seems like that the PR title on a merge message uses a slightly darker colour than the other notifs in the dashboard (See how "Add lorem.md (merge)" is darker for the "merged pull request" message than for "created pull request")
GiteaMirror commented 2025-11-02 09:48:19 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Oct 7, 2023):

Closed PR should be octicon-git-pull-request-closed

I also just now noticed this, but it seems like that the PR title on a merge message uses a slightly darker colour than the other notifs in the dashboard (See how "Add lorem.md (merge)" is darker for the "merged pull request" message than for "created pull request")

Likely was missed in https://github.com/go-gitea/gitea/pull/27356

@silverwind commented on GitHub (Oct 7, 2023): Closed PR should be `octicon-git-pull-request-closed` > I also just now noticed this, but it seems like that the PR title on a merge message uses a slightly darker colour than the other notifs in the dashboard (See how "Add lorem.md (merge)" is darker for the "merged pull request" message than for "created pull request") Likely was missed in https://github.com/go-gitea/gitea/pull/27356
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/ui type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11804
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?