Duplicated struct tag name in internal struct migrations.rawRepository #11767

Closed
opened 2025-11-02 09:47:10 -06:00 by GiteaMirror · 1 comment
Owner

Originally created by @chavacava on GitHub (Oct 2, 2023).

Description

In
dfa4e5857f/services/migrations/codebase.go (L191-L209)
the xml struct tag name ticketing-milestone is repeated.
It seems the first field (XMLName) should have a different tag name.

Gitea Version

88f8351

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I do not run gitea,

Database

None

Originally created by @chavacava on GitHub (Oct 2, 2023). ### Description In https://github.com/go-gitea/gitea/blob/dfa4e5857fe9d8f113cf50d4c7fda094f0f30b74/services/migrations/codebase.go#L191-L209 the `xml` struct tag name `ticketing-milestone` is repeated. It seems the first field (`XMLName`) should have a different tag name. ### Gitea Version 88f8351 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? I do not run gitea, ### Database None
GiteaMirror added the type/bug label 2025-11-02 09:47:10 -06:00
Author
Owner

@Zettat123 commented on GitHub (Oct 7, 2023):

The xml response is like

<ticketing-milestone type="array">
    <ticketing-milestone>
        <id type="integer">1</id>
        <identifier>xxxx</identifier>
        <name>name1</name>
        <start-at type="date">2023-10-01</start-at>
        <description>desc1</description>
        <estimated-time type="integer">0</estimated-time>
        <status>active</status>
    </ticketing-milestone>
    <ticketing-milestone>
        <id type="integer">2</id>
        <identifier>xxxx</identifier>
        <name>name2</name>
        <start-at type="date">2023-10-03</start-at>
        <description>desc2</description>
        <estimated-time type="integer">0</estimated-time>
        <status>active</status>
    </ticketing-milestone>
</ticketing-milestone>

so I think the two ticketing-milestone tags are correct.

@Zettat123 commented on GitHub (Oct 7, 2023): The xml response is like ``` <ticketing-milestone type="array"> <ticketing-milestone> <id type="integer">1</id> <identifier>xxxx</identifier> <name>name1</name> <start-at type="date">2023-10-01</start-at> <description>desc1</description> <estimated-time type="integer">0</estimated-time> <status>active</status> </ticketing-milestone> <ticketing-milestone> <id type="integer">2</id> <identifier>xxxx</identifier> <name>name2</name> <start-at type="date">2023-10-03</start-at> <description>desc2</description> <estimated-time type="integer">0</estimated-time> <status>active</status> </ticketing-milestone> </ticketing-milestone> ``` so I think the two `ticketing-milestone` tags are correct.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11767