Pull Request Approval Count Bug #11720

New Issue

GiteaMirror · 2025-11-02T09:45:44-06:00

GiteaMirror commented

2025-11-02 09:45:44 -06:00

Originally created by @seepine on GitHub (Sep 25, 2023).

Description

The approval count for merge requests is sometimes miscalculated. This can happen whether or not an approval allowlist is set, but unfortunately I am unable to reproduce it accurately.

Gitea Version

1.20.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

MySQL/MariaDB

Originally created by @seepine on GitHub (Sep 25, 2023). ### Description <img width="552" alt="image" src="https://github.com/go-gitea/gitea/assets/93666053/34ecd5cb-6fc2-4dd5-9234-b42b54a62550"> <img width="564" alt="image" src="https://github.com/go-gitea/gitea/assets/93666053/85d9200c-d01a-43de-9a9b-a881e18e63f5"> The approval count for merge requests is sometimes miscalculated. This can happen whether or not an approval allowlist is set, but unfortunately I am unable to reproduce it accurately. ### Gitea Version 1.20.3 ### Can you reproduce the bug on the Gitea demo site? No ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? docker ### Database MySQL/MariaDB

GiteaMirror added the issue/needs-feedback type/bug labels 2025-11-02 09:45:44 -06:00

GiteaMirror closed this issue

2025-11-02 09:45:45 -06:00

GiteaMirror commented

2025-11-02 09:45:46 -06:00

@lunny commented on GitHub (Sep 25, 2023):

Is the person an official one or not?

@lunny commented on GitHub (Sep 25, 2023): Is the person an official one or not?

GiteaMirror commented

2025-11-02 09:45:46 -06:00

@seepine commented on GitHub (Sep 25, 2023):

Is the person an official one or not?

For the example in the screenshot, the approver is in the Owners group.

@seepine commented on GitHub (Sep 25, 2023): > Is the person an official one or not? For the example in the screenshot, the approver is in the Owners group.

GiteaMirror commented

2025-11-02 09:45:46 -06:00

@lng2020 commented on GitHub (Sep 27, 2023):

Is this your self-host Gitea instance? Could you help me check the official field in the review of this user without showing any sensitive data?

SELECT review.id, review.`type`, official
FROM review
INNER JOIN `user` on reviewer_id = `user`.id 
WHERE `user`.name = 'yourusername';

@lng2020 commented on GitHub (Sep 27, 2023): Is this your self-host Gitea instance? Could you help me check the official field in the review of this user without showing any sensitive data? ```sql SELECT review.id, review.`type`, official FROM review INNER JOIN `user` on reviewer_id = `user`.id WHERE `user`.name = 'yourusername'; ```

GiteaMirror commented

2025-11-02 09:45:46 -06:00

@yp05327 commented on GitHub (Sep 27, 2023):

I can only reproduce this issue when the approver approved the PR before join the Owners group.

@yp05327 commented on GitHub (Sep 27, 2023): I can only reproduce this issue when the approver approved the PR before join the Owners group. ![image](https://github.com/go-gitea/gitea/assets/18380374/f0ed0399-307e-4abe-a107-e6ac9e9d3f6e) ![image](https://github.com/go-gitea/gitea/assets/18380374/35dea9eb-6ab5-4138-8d9e-5902d11384a6) ![image](https://github.com/go-gitea/gitea/assets/18380374/a96332a2-317d-41f7-a487-92071036b348)

GiteaMirror commented

2025-11-02 09:45:46 -06:00

@GiteaBot commented on GitHub (Apr 20, 2024):

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@GiteaBot commented on GitHub (Apr 20, 2024): We close issues that need feedback from the author if there were no new comments for a month. :tea:

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#11720