github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Approval count should show on failure status too #11705

New Issue
Open
opened 2025-11-02 09:45:21 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 09:45:21 -06:00
Owner
Copy Link

Originally created by @silverwind on GitHub (Sep 23, 2023).

Description

Noticed this on https://gitea.com/gitea/act/pulls:

image

Both PRs have 1 approval, but only the first one shows "1 approval" in the list. Presumably because the second one failed the checks.

Gitea Version

1.21

Can you reproduce the bug on the Gitea demo site?

Not tested but I assume it would.

Originally created by @silverwind on GitHub (Sep 23, 2023). ### Description Noticed this on https://gitea.com/gitea/act/pulls: <img width="680" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/3893e365-6ca8-4345-bf02-17383ebe9eb0"> Both PRs have 1 approval, but only the first one shows "1 approval" in the list. Presumably because the second one failed the checks. ### Gitea Version 1.21 ### Can you reproduce the bug on the Gitea demo site? Not tested but I assume it would.
GiteaMirror added the type/bug label 2025-11-02 09:45:21 -06:00
GiteaMirror commented 2025-11-02 09:45:22 -06:00
Author
Owner
Copy Link

@lng2020 commented on GitHub (Sep 26, 2023):

It is not relevant to action, but it's indeed a bug about official field in review table. See(https://gitea.com/gitea/go-sdk/pulls/631)
ksnip_20230926-121636

@lng2020 commented on GitHub (Sep 26, 2023): It is not relevant to action, but it's indeed a bug about `official` field in `review` table. See(https://gitea.com/gitea/go-sdk/pulls/631) ![ksnip_20230926-121636](https://github.com/go-gitea/gitea/assets/70063547/690d229b-df2a-4f7c-a15e-a21040e079e1)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11705
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?