github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Adjust database connection attempts #11656

New Issue
Closed
opened 2025-11-02 09:43:37 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2025-11-02 09:43:37 -06:00
Owner
Copy Link

Originally created by @tacerus on GitHub (Sep 14, 2023).

Feature Description

Hi,

currently, if the database backend is unreachable for a longer period of time (for example during maintenance on the database server), Gitea will crash after ten connection attempts:

Sep 14 09:40:57 gitea01 gitea[1165]: 2023/09/14 09:40:57 routers/common/db.go:35:InitDBEngine() [I] Backing off for 3 seconds
Sep 14 09:41:00 gitea01 gitea[1165]: 2023/09/14 09:41:00 routers/common/db.go:28:InitDBEngine() [I] ORM engine initialization attempt #9/10...
Sep 14 09:41:00 gitea01 gitea[1165]: 2023/09/14 09:41:00 cmd/web.go:175:serveInstalled() [I] PING DATABASE mysql
Sep 14 09:41:03 gitea01 gitea[1165]: 2023/09/14 09:41:03 routers/common/db.go:34:InitDBEngine() [E] ORM engine initialization attempt #9/10 failed. Error: dial tcp [2a07:>
Sep 14 09:41:03 gitea01 gitea[1165]: 2023/09/14 09:41:03 routers/common/db.go:35:InitDBEngine() [I] Backing off for 3 seconds
Sep 14 09:41:06 gitea01 gitea[1165]: 2023/09/14 09:41:06 routers/common/db.go:28:InitDBEngine() [I] ORM engine initialization attempt #10/10...
Sep 14 09:41:06 gitea01 gitea[1165]: 2023/09/14 09:41:06 cmd/web.go:175:serveInstalled() [I] PING DATABASE mysql
Sep 14 09:41:06 gitea01 gitea[1165]: 2023/09/14 09:41:06 routers/init.go:69:mustInitCtx() [F] code.gitea.io/gitea/routers/common.InitDBEngine(ctx) failed: dial tcp [2a07:>
Sep 14 09:41:06 gitea01 systemd[1]: gitea.service: Main process exited, code=exited, status=1/FAILURE
Sep 14 09:41:06 gitea01 systemd[1]: gitea.service: Failed with result 'exit-code'.

It would be great if the delay between the attempts and the amount of attempts could be adjusted, to have Gitea come online again automatically after the backend is back.
A workaround is to have systemd restart the service on failure, but that is prone to cause issues if the failure is caused by something other than the database being offline.

Screenshots

No response

Originally created by @tacerus on GitHub (Sep 14, 2023). ### Feature Description Hi, currently, if the database backend is unreachable for a longer period of time (for example during maintenance on the database server), Gitea will crash after ten connection attempts: ``` Sep 14 09:40:57 gitea01 gitea[1165]: 2023/09/14 09:40:57 routers/common/db.go:35:InitDBEngine() [I] Backing off for 3 seconds Sep 14 09:41:00 gitea01 gitea[1165]: 2023/09/14 09:41:00 routers/common/db.go:28:InitDBEngine() [I] ORM engine initialization attempt #9/10... Sep 14 09:41:00 gitea01 gitea[1165]: 2023/09/14 09:41:00 cmd/web.go:175:serveInstalled() [I] PING DATABASE mysql Sep 14 09:41:03 gitea01 gitea[1165]: 2023/09/14 09:41:03 routers/common/db.go:34:InitDBEngine() [E] ORM engine initialization attempt #9/10 failed. Error: dial tcp [2a07:> Sep 14 09:41:03 gitea01 gitea[1165]: 2023/09/14 09:41:03 routers/common/db.go:35:InitDBEngine() [I] Backing off for 3 seconds Sep 14 09:41:06 gitea01 gitea[1165]: 2023/09/14 09:41:06 routers/common/db.go:28:InitDBEngine() [I] ORM engine initialization attempt #10/10... Sep 14 09:41:06 gitea01 gitea[1165]: 2023/09/14 09:41:06 cmd/web.go:175:serveInstalled() [I] PING DATABASE mysql Sep 14 09:41:06 gitea01 gitea[1165]: 2023/09/14 09:41:06 routers/init.go:69:mustInitCtx() [F] code.gitea.io/gitea/routers/common.InitDBEngine(ctx) failed: dial tcp [2a07:> Sep 14 09:41:06 gitea01 systemd[1]: gitea.service: Main process exited, code=exited, status=1/FAILURE Sep 14 09:41:06 gitea01 systemd[1]: gitea.service: Failed with result 'exit-code'. ``` It would be great if the delay between the attempts and the amount of attempts could be adjusted, to have Gitea come online again automatically after the backend is back. A workaround is to have systemd restart the service on failure, but that is prone to cause issues if the failure is caused by something other than the database being offline. ### Screenshots _No response_
GiteaMirror added the issue/needs-feedback label 2025-11-02 09:43:37 -06:00
GiteaMirror commented 2025-11-02 09:43:38 -06:00
Author
Owner
Copy Link

@CaiCandong commented on GitHub (Sep 14, 2023):

I think so. We may need a Back-off algorithm to determine the retry interval.
How about this ？https://github.com/jpillora/backoff

@CaiCandong commented on GitHub (Sep 14, 2023): I think so. We may need a Back-off algorithm to determine the retry interval. How about this ？https://github.com/jpillora/backoff
GiteaMirror commented 2025-11-02 09:43:38 -06:00
Author
Owner
Copy Link

@tacerus commented on GitHub (Sep 14, 2023):

Hi @CaiCandong, the project you linked seems to be about HTTP, not TCP or MySQL?

@tacerus commented on GitHub (Sep 14, 2023): Hi @CaiCandong, the project you linked seems to be about HTTP, not TCP or MySQL?
GiteaMirror commented 2025-11-02 09:43:39 -06:00
Author
Owner
Copy Link

@CaiCandong commented on GitHub (Sep 14, 2023):

Hi @CaiCandong, the project you linked seems to be about HTTP, not TCP or MySQL?

Sorry, I just searched back off the keyword; I didn't look hard enough.

@CaiCandong commented on GitHub (Sep 14, 2023): > Hi @CaiCandong, the project you linked seems to be about HTTP, not TCP or MySQL? Sorry, I just searched `back off` the keyword; I didn't look hard enough.
GiteaMirror commented 2025-11-02 09:43:39 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Sep 14, 2023):

Backoff is quite simple

https://github.com/go-gitea/gitea/blob/main/modules/queue/backoff.go

@wxiaoguang commented on GitHub (Sep 14, 2023): Backoff is quite simple https://github.com/go-gitea/gitea/blob/main/modules/queue/backoff.go
GiteaMirror commented 2025-11-02 09:43:39 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Sep 17, 2023):

And it is already adjustable.

47b878858a/custom/conf/app.example.ini (L398-L399)

@wxiaoguang commented on GitHub (Sep 17, 2023): And it is already adjustable. https://github.com/go-gitea/gitea/blob/47b878858ada27fc4c74eeadcc1e467d2da90e04/custom/conf/app.example.ini#L398-L399
GiteaMirror commented 2025-11-02 09:43:39 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Sep 21, 2023):

Close as completed because it is adjustable.

@wxiaoguang commented on GitHub (Sep 21, 2023): Close as completed because it is adjustable.
GiteaMirror commented 2025-11-02 09:43:40 -06:00
Author
Owner
Copy Link

@tacerus commented on GitHub (Sep 24, 2023):

Thank you, I missed this!

@tacerus commented on GitHub (Sep 24, 2023): Thank you, I missed this!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/needs-feedback
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?