github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

LDAP admin updata bug #11643

New Issue
Closed
opened 2025-11-02 09:43:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 09:43:18 -06:00
Owner
Copy Link

Originally created by @CaiCandong on GitHub (Sep 13, 2023).

Description

When you have set administrator privileges for a user through LDAP settings, and after some time, you cancel the administrator privileges for that user in LDAP. You will find that the administrator privileges cannot be canceled.

The problem comes from the LDAP settings, if the Gitea instance does not specify a username query rule, for user_model.IsUserExist(db.DefaultContext, 0, sr.Username), sr.Username is an empty string "", isExist always be false, so can't update the user.

image

a55ff0dd99/services/auth/source/ldap/source_authenticate.go (L27-L36)

Gitea Version

a55ff0dd99

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

source code

Database

None

Originally created by @CaiCandong on GitHub (Sep 13, 2023). ### Description When you have set administrator privileges for a user through LDAP settings, and after some time, you cancel the administrator privileges for that user in LDAP. You will find that the administrator privileges cannot be canceled. The problem comes from the LDAP settings, if the Gitea instance does not specify a username query rule, for `user_model.IsUserExist(db.DefaultContext, 0, sr.Username)`, `sr.Username` is an empty string `""`, `isExist` always be `false`, so can't update the user. ![image](https://github.com/go-gitea/gitea/assets/50507092/403f5a7e-4346-4ccf-ba75-417f66f26d38) https://github.com/go-gitea/gitea/blob/a55ff0dd99439eb96151e64be38e0f14f6e723b7/services/auth/source/ldap/source_authenticate.go#L27-L36 ### Gitea Version a55ff0dd99439eb96151e64be38e0f14f6e723b7 ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? source code ### Database None
GiteaMirror added the topic/authenticationtype/bug labels 2025-11-02 09:43:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/authentication type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11643
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?