Review bar and "sticky" file header layout regression #11538

Closed
opened 2025-11-02 09:40:34 -06:00 by GiteaMirror · 2 comments
Owner

Originally created by @wxiaoguang on GitHub (Aug 25, 2023).

Due to #26711 (and other old PRs) , now the "sticky" file header doesn't work well with uncertain review bar height.

Before, the sticky top was hard-coded to 2 magic numbers, but the "review bar" has been changed many times and it uses "flex" layout, the height is not predictable.

Originally created by @wxiaoguang on GitHub (Aug 25, 2023). Due to #26711 (and other old PRs) , now the "sticky" file header doesn't work well with uncertain review bar height. Before, the sticky top was hard-coded to 2 magic numbers, but the "review bar" has been changed many times and it uses "flex" layout, the height is not predictable.
GiteaMirror added the topic/uitype/bug labels 2025-11-02 09:40:34 -06:00
Author
Owner

@silverwind commented on GitHub (Aug 25, 2023):

Height needs to be predictable for sticky to work, unless there is another solution but I'm not aware of.

@silverwind commented on GitHub (Aug 25, 2023): Height needs to be predictable for sticky to work, unless there is another solution but I'm not aware of.
Author
Owner

@wxiaoguang commented on GitHub (Aug 26, 2023):

I am not working on it either, just open an issue for record.

@wxiaoguang commented on GitHub (Aug 26, 2023): I am not working on it either, just open an issue for record.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11538