Strange green point in dashboard repo list #11464

Closed
opened 2025-11-02 09:38:36 -06:00 by GiteaMirror · 14 comments
Owner

Originally created by @yp05327 on GitHub (Aug 16, 2023).

Description

I think this comes from #26520
image
(Using Chrome on Windows)
@silverwind

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

Originally created by @yp05327 on GitHub (Aug 16, 2023). ### Description I think this comes from #26520 ![image](https://github.com/go-gitea/gitea/assets/18380374/af6ac787-5c59-4cd3-bca9-01cac030b3d2) (Using Chrome on Windows) @silverwind ### Gitea Version latest ### Can you reproduce the bug on the Gitea demo site? Yes ### Log Gist _No response_ ### Screenshots _No response_ ### Git Version _No response_ ### Operating System _No response_ ### How are you running Gitea? build ### Database None
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 09:38:36 -06:00
Author
Owner

@yp05327 commented on GitHub (Aug 16, 2023):

image

@yp05327 commented on GitHub (Aug 16, 2023): ![image](https://github.com/go-gitea/gitea/assets/18380374/008eb593-6693-4bc0-a029-3f54048d39d5)
Author
Owner

@silverwind commented on GitHub (Aug 16, 2023):

It's a scrollbar. Seems to be some Chrome-only issue because it works. Adding overflow-y: clip does seem to help for the scrollbar but does not fix the "g" cutoff, hmm. Maybe we should revert to overflow: hidden and set a proper line-height where necessary.

@silverwind commented on GitHub (Aug 16, 2023): It's a scrollbar. Seems to be some Chrome-only issue because it works. Adding `overflow-y: clip` does seem to help for the scrollbar but does not fix the "g" cutoff, hmm. Maybe we should revert to `overflow: hidden` and set a proper line-height where necessary.
Author
Owner

@wxiaoguang commented on GitHub (Aug 17, 2023):

JS Fiddle: https://jsfiddle.net/6Ltbd581/16/

(ps: the line-height: 1 comes from Fomantic UI's menu item)

Chrome:

image

@wxiaoguang commented on GitHub (Aug 17, 2023): JS Fiddle: https://jsfiddle.net/6Ltbd581/16/ (ps: the `line-height: 1` comes from Fomantic UI's menu item) Chrome: <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/3f305cf6-72a8-461a-a8dc-d1de02ae737c) </details>
Author
Owner

@silverwind commented on GitHub (Aug 17, 2023):

line-height: 1 is the root of the problem, I think at minimum 1.2 is recommended (roughly equivalnt to normal), but I would go for 1.4 to be safe as the right value depends on font in use and we get different fonts on different OSs.

@silverwind commented on GitHub (Aug 17, 2023): `line-height: 1` is the root of the problem, I think at minimum `1.2` is recommended (roughly equivalnt to `normal`), but I would go for `1.4` to be safe as the right value depends on font in use and we get different fonts on different OSs.
Author
Owner

@wxiaoguang commented on GitHub (Aug 17, 2023):

The "more"root problem seems that Chrome doesn't consider "descent" into the line-height .... so characters like "g" / "y" causes layout problems .....

image

@wxiaoguang commented on GitHub (Aug 17, 2023): The "more"root problem seems that Chrome doesn't consider "descent" into the line-height .... so characters like "g" / "y" causes layout problems ..... <details> ![image](https://github.com/go-gitea/gitea/assets/2114189/1b1cee58-4665-4d8d-a4fd-bcaa7f34b991) </details>
Author
Owner

@wxiaoguang commented on GitHub (Aug 17, 2023):

-> Fix various line-height styles #26553

@wxiaoguang commented on GitHub (Aug 17, 2023): -> Fix various line-height styles #26553
Author
Owner

@yp05327 commented on GitHub (Aug 18, 2023):

@wxiaoguang @silverwind
It seems that this is not completely fixed, I can still see these green things.

in try.gitea.io
image

in local
image
local version:
image

@yp05327 commented on GitHub (Aug 18, 2023): @wxiaoguang @silverwind It seems that this is not completely fixed, I can still see these green things. in try.gitea.io ![image](https://github.com/go-gitea/gitea/assets/18380374/2b67ea09-4787-4366-b1a8-870b0d2a1389) in local ![image](https://github.com/go-gitea/gitea/assets/18380374/4ee73c20-4cf5-41a8-80c0-9821b52d333e) local version: ![image](https://github.com/go-gitea/gitea/assets/18380374/f01a0c44-32dd-420a-879c-96af09ed9f83)
Author
Owner

@yp05327 commented on GitHub (Aug 18, 2023):

Ah, I see. this green thing is a scrollbar. 😄

(removed overflow-x)
image

@yp05327 commented on GitHub (Aug 18, 2023): Ah, I see. this green thing is a scrollbar. 😄 (removed overflow-x) ![image](https://github.com/go-gitea/gitea/assets/18380374/ca957030-9103-4015-b532-03f1876cc565)
Author
Owner

@yp05327 commented on GitHub (Aug 18, 2023):

image
image

when --line-height-default is 1.20, it will disappear

the lowest value is 1.18
image
image

@yp05327 commented on GitHub (Aug 18, 2023): ![image](https://github.com/go-gitea/gitea/assets/18380374/dd53091c-6a63-4b6c-9367-ddfbaf0c9980) ![image](https://github.com/go-gitea/gitea/assets/18380374/aa9b859e-7999-408e-b6e2-149ad810b8ce) when --line-height-default is 1.20, it will disappear the lowest value is 1.18 ![image](https://github.com/go-gitea/gitea/assets/18380374/cfffc3c3-d33c-4cec-9655-4099b32bacbb) ![image](https://github.com/go-gitea/gitea/assets/18380374/e7b2b827-a8c3-4807-9755-cf709b26cff9)
Author
Owner

@wxiaoguang commented on GitHub (Aug 18, 2023):

Then the "modules/normalize.css" should also be changed accordingly

@wxiaoguang commented on GitHub (Aug 18, 2023): Then the "modules/normalize.css" should also be changed accordingly
Author
Owner

@silverwind commented on GitHub (Aug 18, 2023):

BTW, there is also this useless style in effect on these strings, which results in the too-early truncation. We should remove it, text truncates fine without it as well.

.dashboard.feeds .filter.menu .item .text.truncate,
.dashboard.issues .filter.menu .item .text.truncate {
  width: 75%;
}

Then the "modules/normalize.css" should also be changed accordingly

Not sure I follow. Value is the same there, but I agree we could variablize it.

@silverwind commented on GitHub (Aug 18, 2023): BTW, there is also this useless style in effect on these strings, which results in the too-early truncation. We should remove it, text truncates fine without it as well. ```css .dashboard.feeds .filter.menu .item .text.truncate, .dashboard.issues .filter.menu .item .text.truncate { width: 75%; } ``` > Then the "modules/normalize.css" should also be changed accordingly Not sure I follow. Value is the same there, but I agree we could variablize it.
Author
Owner

@yp05327 commented on GitHub (Aug 21, 2023):

Does --line-height related to screen resolution?
My display is 1920 x 1080.

@yp05327 commented on GitHub (Aug 21, 2023): Does --line-height related to screen resolution? My display is 1920 x 1080.
Author
Owner

@silverwind commented on GitHub (Aug 21, 2023):

No, line-height only depends on the font's intrinsic height.

@silverwind commented on GitHub (Aug 21, 2023): No, `line-height` only depends on the font's intrinsic height.
Author
Owner

@wxiaoguang commented on GitHub (Aug 21, 2023):

-> Use line-height: 1.2 for default #26635

@wxiaoguang commented on GitHub (Aug 21, 2023): -> Use line-height: 1.2 for default #26635
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11464