github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-22 22:45:27 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Test failure: Race detected in TestGit/SSH #11428

New Issue
Closed
opened 2025-11-02 09:37:20 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 09:37:20 -06:00
Owner
Copy Link

Originally created by @silverwind on GitHub (Aug 9, 2023).

Description

Seen this for the first time:

https://github.com/go-gitea/gitea/actions/runs/5808995595/job/15746928976?pr=26409

=== TestGit/SSH (tests/integration/git_test.go:95)
==================
WARNING: DATA RACE
Read at 0x00c00501a5b8 by goroutine 221160:
  github.com/gliderlabs/ssh.(*sshContext).Err()
      <autogenerated>:1 +0x31
  database/sql.(*Rows).awaitDone()
      /opt/hostedtoolcache/go/1.21.0/x64/src/database/sql/sql.go:2973 +0x2a8
  database/sql.(*Rows).initContextClose.func1()
      /opt/hostedtoolcache/go/1.21.0/x64/src/database/sql/sql.go:2949 +0x8f

Gitea Version

main

Originally created by @silverwind on GitHub (Aug 9, 2023). ### Description Seen this for the first time: https://github.com/go-gitea/gitea/actions/runs/5808995595/job/15746928976?pr=26409 ``` === TestGit/SSH (tests/integration/git_test.go:95) ================== WARNING: DATA RACE Read at 0x00c00501a5b8 by goroutine 221160: github.com/gliderlabs/ssh.(*sshContext).Err() <autogenerated>:1 +0x31 database/sql.(*Rows).awaitDone() /opt/hostedtoolcache/go/1.21.0/x64/src/database/sql/sql.go:2973 +0x2a8 database/sql.(*Rows).initContextClose.func1() /opt/hostedtoolcache/go/1.21.0/x64/src/database/sql/sql.go:2949 +0x8f ``` ### Gitea Version main
GiteaMirror added the type/bugtype/upstream labels 2025-11-02 09:37:20 -06:00
GiteaMirror commented 2025-11-02 09:37:20 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Aug 9, 2023):

Related: https://github.com/gliderlabs/ssh/pull/211

@silverwind commented on GitHub (Aug 9, 2023): Related: https://github.com/gliderlabs/ssh/pull/211
GiteaMirror commented 2025-11-02 09:37:21 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Aug 9, 2023):

This is coming up a lot recently on CI. I wonder whether a recent change in our code exposed this race. Assuming upstream does not merge this quickly, we may need to put a bandaid fix in our code, or if possibly selectively disable the race detector for those code paths.

@silverwind commented on GitHub (Aug 9, 2023): This is coming up a lot recently on CI. I wonder whether a recent change in our code exposed this race. Assuming upstream does not merge this quickly, we may need to put a bandaid fix in our code, or if possibly selectively disable the race detector for those code paths.
GiteaMirror commented 2025-11-02 09:37:21 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Aug 9, 2023):

OK, I will "bypass" the upstream in the PR #26409

Update: The patch works, CI passes

@wxiaoguang commented on GitHub (Aug 9, 2023): OK, I will "bypass" the upstream in the PR #26409 ---- Update: The patch works, CI passes
GiteaMirror commented 2025-11-02 09:37:21 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Aug 10, 2023):

Fixed in main branch and 1.20, leaving it open until we have a proper fix via https://github.com/gliderlabs/ssh/pull/211.

@silverwind commented on GitHub (Aug 10, 2023): Fixed in main branch and 1.20, leaving it open until we have a proper fix via https://github.com/gliderlabs/ssh/pull/211.
GiteaMirror commented 2025-11-02 09:37:21 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Sep 22, 2023):

The upstream is dead. I think this issue could also be closed since our "workaround" works well.

@wxiaoguang commented on GitHub (Sep 22, 2023): The upstream is dead. I think this issue could also be closed since our "workaround" works well.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug type/upstream
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#11428
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?